Giter Club home page Giter Club logo

moodledirectv2's Issues

Log into Turnitin via Plugin settings

In the previous Dan Marsden version of this plugin, there were links to "Log in as an Admin" and "Log in as a Teacher" in the plagiarism plugin settings. This allowed us to SSO and was very useful as we do allow users to log in via the Turnitin website.

There were also links for teachers on the assignment grading page to "Log in as a teacher".

Both are used quite a lot in our institutions, is there a possibility of them being reintroduced?

Using plagiarism plugin for Online Text assignments results in loads of 'junk' in the marking screen

To reproduce set up an Assignment with an Online text submission type. Get a student to submit some text and style it with some bold and italic (nothing fancy required). When available, go into Turnitin's grading screen. It's almost unusable for HTML added by the editor that is still visible.

Even worse, it totally skews the similarity score. The preamble in my test submission contributed 71% to the score rendering Online text completely unusable through Turnitin.

screen shot 2014-08-13 at 14 16 44

Plagiarism plugin - link to Grademark/Similarity report breaks for admins and managers

The link to bring up the grading/similarity report window does not work if the user is an admin or manager. However, it still looks like it should as the pointer turns to a 'hand' icon associated with a link. One must be an actual teacher in the course for the link to work.

This is unacceptable from a support point of view. Administrators need to be able to view the reports - as they can in the 'full' Turnitintool activity.

dependency on libxml should be checked

Turnitintooltwo uses the XMLWriter class but this is not a requirement for the installation of Moodle itself. A specific check and error message should be added somewhere to confirm that this class is available.

Moodle Plugin Review of TII Plugins

In anticipation of you adding these plugins to Moodle Plugins, I would like to suggest that you declare the dependencies in the version.php (if needed, see http://docs.moodle.org/dev/version.php for details). Each will need to be submitted as a separate plugin (block, mod, and plagiarism) but we can group them together as a set. Please do not hesitate to let me know if there is anything I can do to be supportive of your efforts. Peace - Anthony

Plagiarism plugin gives no indication of "bad" documents

If one uploads (for example) a PDF consisting of scanned images rather than readable-text, the user simply does not get a similarity score. In the Turnitin module they get a message back immediately that there isn't enough text in the document.

Given the number of support enquiries we get from students doing that sort of thing when they do get a message, I am seriously concerned about the support implications when they do not.

If a submission is made correctly and no score is returned can 'something' be displayed?

There is generally a lack of feedback for exception conditions using the plagiarism plug which is a worry.

Unified repository makes it impossible to use this code via git for administrators/devs

Hi

Thanks for the work you're doing to put these plugins together.

I am looking at starting to use them, helping to test/fix bugs, etc, but it is going to be very hard with all three plugins in one repo. It will involve downloading the repo, then manually copy/pasting the different code directories to where they need to be in the Moodle docroot. The normal way for me to work is to git clone the plugin directly to the /plagiarism or /blocks directory, from where git pull/push works seamlessly.

Is there any chance of splitting the repo up to make this workflow possible?

Cheers

Matt

There's no indication/status in plagiarism plugin if cron fails

Given that the cron for the (Assignment) plagiarism plugin has to interface with an external system there are plenty of opportunities for it to go wrong. If it does, it just mysteriously doesn't provide a link to Turnitin in Assignment.

Is there some way that the current status of the submission could be displayed if the similarity/link cannot be shown (e.g. "not yet submitted", "submission failed")? It would really speed up getting to the bottom of problems.

external entities

I've been testing the latest code and am still getting errors when libxml_disable_entity_loader(true)

libxml_disable_entity_loader(true) is reccomended to improve security - using and enabling external entities is generally considered to be a high security risk so many sites are now turning it off.

Compounding that is that libxml_disable_entity_loader is not "thread-safe" - this means that if a server is running mulitple applications and one application uses libxml_disable_entity_loader it will set the value for the whole server - not just the application it is using.

This means we get errors like this:
Message: SOAP-ERROR: Parsing WSDL: Couldn't load from
'/var/www/moodle/mod/turnitintooltwo/sdk/wsdl/lis-lineitem.wsdl'
: failed to load external entity
"/var/www/moodle/mod/turnitintooltwo/sdk/wsdl/lis-lineitem.wsdl"

Which prevents files from being sent to Turnitin.

The error posted above comes from testing code from the latest devlopment branch today.

Anonymous marking enabled - cannot set anonymous_marking_enabled field

We got the following error on a test server we have been using to evaluate this module:

 File: /var/www/beta/mod/turnitintooltwo/sdk/assignmentsoap.class.php | Line: 33 | Message: anonymous_marking_enabled - cannot set anonymous_marking_enabled field
 | Code: 0
* line 489 of /mod/turnitintooltwo/lib.php: call to print_error()
* line 127 of /mod/turnitintooltwo/turnitintooltwo_comms.class.php: call to turnitintooltwo_print_error()
* line 770 of /mod/turnitintooltwo/turnitintooltwo_assignment.class.php: call to turnitintooltwo_comms->handle_exceptions()
* line 982 of /plagiarism/turnitin/lib.php: call to turnitintooltwo_assignment::create_tii_assignment()
* line 1229 of /plagiarism/turnitin/lib.php: call to plagiarism_plugin_turnitin->sync_tii_assignment()
* line 1762 of /plagiarism/turnitin/lib.php: call to plagiarism_plugin_turnitin->event_handler()
* line ? of unknownfile: call to event_mod_created()
* line 299 of /lib/eventslib.php: call to call_user_func()
* line 343 of /lib/eventslib.php: call to events_dispatch()
* line 450 of /lib/eventslib.php: call to events_process_queued_handler()
* line 340 of /lib/cronlib.php: call to events_cron()
* line 61 of /admin/cli/cron.php: call to cron_run()
 ++
* line 366 of /lib/eventslib.php: call to debugging()
* line 450 of /lib/eventslib.php: call to events_process_queued_handler()
* line 340 of /lib/cronlib.php: call to events_cron()
* line 61 of /admin/cli/cron.php: call to cron_run()
done.

The odd thing is we'd only just installed and configured the module and created a single mod_assign activity with turnitin enabled (we're using the plagiarism plugin here) and the activity was not configured to use any anonymous/blind marking in either the Moodle mod_assign settings, nor in the Turnitin settings...

Using version 2014012402 of mod_turnitintooltwo and corresponding 2014012403 of plagiarism_turnitin

Tii Site outage(Degradation) causes cron/event queue to break

We had a degradation (Tii's term) today during which the API url was inaccessible. This caused the cron to break at the event queue stage. During this period there were problems accessing the plugins/blocks and a few other admin areas. The assignments were also unavailable during this period.

Are you able to fix this or tell us how the prevent such outages from having such a serious effect on the site?

Moodle Version 2.6.1
Moodle Direct V2 Version 2014012403

Would appreciate any assistance you could give.

Regards,
Vernon

Changing Turnitin Account raises error

So each year we've segregated our Turnitin Submissions by creating a new sub account.

This year we're also merging from using Direct V1 & Dan Marsden's plugin to using only Direct V2.

Our testing of this has led us to an interesting issue.

We have mod_assign activities in classes using the DM plugin. When we install the Direct V2 plagiarism plugin over the top (which we have to do since they have the same name) and change the sub account ID in the settings, we see new classes being created in Turnitin but not new assignments.

This appears fine at first, I was expecting that a student submission to maybe trigger creation. However if a student then submits a piece of work into one of these assignments the cron event handler throws an exception:

++ Handler function of component plagiarism_turnitin: s:26:"event_assessable_submitted"; threw exception :turnitintooltwo/There was an error trying to edit the assignment in Turnitin<br/><br/>Fault Code: unknownobject | File: /moodle/web/mod/turnitintooltwo/sdk/assignmentsoap.class.php | Line: 108 | Message: Assignment LineItem not found. | Code: 0
* line 489 of /mod/turnitintooltwo/lib.php: call to print_error()
* line 127 of /mod/turnitintooltwo/turnitintooltwo_comms.class.php: call to turnitintooltwo_print_error()
* line 791 of /mod/turnitintooltwo/turnitintooltwo_assignment.class.php: call to turnitintooltwo_comms->handle_exceptions()
* line 979 of /plagiarism/turnitin/lib.php: call to turnitintooltwo_assignment->edit_tii_assignment()
* line 1260 of /plagiarism/turnitin/lib.php: call to plagiarism_plugin_turnitin->sync_tii_assignment()
* line 1770 of /plagiarism/turnitin/lib.php: call to plagiarism_plugin_turnitin->event_handler()
* line ? of unknownfile: call to event_assessable_submitted()
* line 299 of /lib/eventslib.php: call to call_user_func()
* line 343 of /lib/eventslib.php: call to events_dispatch()
* line 450 of /lib/eventslib.php: call to events_process_queued_handler()
* line 340 of /lib/cronlib.php: call to events_cron()
* line 61 of /admin/cli/cron.php: call to cron_run()
 ++
* line 366 of /lib/eventslib.php: call to debugging()
* line 450 of /lib/eventslib.php: call to events_process_queued_handler()
* line 340 of /lib/cronlib.php: call to events_cron()
* line 61 of /admin/cli/cron.php: call to cron_run()

I'm going to see what happens if I turn the turnitin check off and then back on again...but this is quite problematic if we have to do this for every mod_assign activity that was using the previous DM Turnitin Plagarism Plugin.

Agreement of EULA

This is a little problematic for us. We've already had support requests as it's not very obvious.

As we already have the students agree to terms and conditions we'd like to consider rolling any other agreements under that so we don't have to have further popups etc that are obstacles, so if we do this it would be good to be able to have this agreed to already.

Also if we're using an integration method the end-user isn't get much choice about it, as effectively the institution has already mandated it, so an interactive EULA is sort of redundant...

These objections are purely from a user experience position I'm aware there may be legal reasons, but it would be good to try to make this a better process.

I suspect that we'd quite happy have some sort of audit process for TII to check that the T&Cs our students agree to include TII T&Cs.

Plagiarism plugin doesn't respect Assignment upload limit

Moodle's assignment get's its upload limit from whatever the course happens to be set to (100M in our case). The student can quite happily upload documents up to that size. Unfortunately, Turnitin only allows 20M but nobody finds out about this until it fails to return a similarity score. It would be difficult for us to set all Assignments to 20M as some are used for other things where it needs to be bigger.

Not sure what the solution to this is.

Historic submissions show EULA error

submissions from students that have returned a successful report prior to the EULA check show the error "This file has not been submitted to Turnitin because the user has not accepted the Turnitin End User Licence Agreement"
but that is not quite correct. - If the error needs to show for all historical users as well as current then it should use slightly different language like this:
'This user has not accepted the Turnitin End User Licence Agreement.';

Moodle 2.7 cannot create turnitintooltwo assignment

turnitintooltwo/There was an error trying to create the assignment in Turnitin

Fault Code: invaliddata | File: [dirroot]/mod/turnitintooltwo/sdk/assignmentsoap.class.php | Line: 33 | Message: institution_check - cannot set institution_check value for account | Code: 0

Setting the grade item's hidden until value on page views

Why does "turnitintooltwo_grade_item_update" set the hidden value when tutors view the page?

It strikes me as messing with the Gradebook settings which an activity module shouldn't really be doing? If a tutor wants to make the grade book column visible independantly of the activity this should be allowed.

It seems to be at odds with every other plugin...(IMHO)

Turnitin Class Title Limit (100 characters) causing problems in Moodle integration

I have turnitintooltwo set up on a Moodle 2.4+ site and I am running into problems with the 100 character limit on turnitin class titles.

The two functions are found in the tiiclass.class.php file in /mod/turnitintooltwo/sdk.

/**
 * Set the Title for this Class
 * 
 * A string between 5 and 100 characters to use as the Class title.
 * 
 * @param string $title
 */
public function setTitle( $title ) {
    $this->title = $title;
}

/**
 * Get the Title for this Class
 * 
 * A string between 5 and 100 characters to use as the Class title.
 * 
 * @return string
 */
public function getTitle() {
    return $this->title;
}

The problem is this function is taking into account the fullname of the course within Moodle and not just the title of the turnitin assignment.

I am getting this error when attempting to add a turnitin assignment to a specific course:

turnitintooltwo/Turnitin Class creation failed

Fault Code: invaliddata | File: [dirroot]/mod/turnitintooltwo/sdk/classsoap.class.php | Line: 30 | Message: title - Please limit to 100 characters. You submitted 107. | Code: 0

The fullname for the course is : Spring 2014-HRB604-SECTION 200-Frequently Used Herbs: Understanding for the Health Professional

I am naming the turnitin assignment "test" but in combination with the fullname of the course it is going over the title character limit of 100.

I could work with the school to trim down the course names but could you change the constraints on the function to allow more characters?

Or is there another piece of identifying data you can use aside from the fullname of the course when creating these courses within turnitin?

Pop up issue

when click the Similarity icon, Grade icon and Download icon in the Summission Inbox, the browser will handle the pop up windows as ad.

"Breaking" mod_assign if not configured

I'm not sure that completely breaking mod_assign if the plagiarism plugin isn't configured is a good idea!

Why can't the plugin simply disable itself from that instance and prevent any use of it?

It would also be good to notify the administrator that it's not configured properly via something like email as if an end-user suddenly sees that message it will freak them out (and they have no reason to need to see it)

mod/turnitintool/settings.php performance issue

the settings.php file makes a call to turnitintooltwo_updateavailable which is run every time the navigation tree is built - this function call is probably not needed anymore now that the plugin exists in the moodle.org plugins db as there are built-in version checks that link to the plugins db and notify the site admin.

ideally settings.php should only contain logic to build the navigation tree and should be very quick as it is included in a lot of places by Moodle code.

Plagiarism plugin - the students just don't notice the EULA link

We have had considerable number of students - I'm going to suggest a figure approaching everyone who has submitted something - who simply don't notice the EULA link.

I'm not sure what the answer is, but it needs to be much more "in your face" than a simple link. They need some sort of Modal screen that is presented to them before they can complete their submission. Expecting them yo notice that link isn't going to work.

Plagiarism plugin not working

I appreciate the Moodle Direct v2 set may still be in beta, but just wanted to report an possible issue with the plagiarism_turnitin component. Basically, for us (under Moodle 2.4.5 and the submit.ac.uk api) it's not working in relation to use within the regular assignment module - i.e. no originality score is displayed to either tutor or student, nor any link to a submission's GradeMark view. Interestingly, everything works fine when a submission is made via the turnitintooltwo component - with the score returned successfully and the GradeMark link functioning as expected:

screen shot 2014-01-17 at 14 22 45

screen shot 2014-01-17 at 14 23 30

screen shot 2014-01-17 at 14 19 09

Btw, as far as I can tell everything is set up correctly in terms of global settings, etc:

screen shot 2014-01-17 at 14 24 47

screen shot 2014-01-17 at 14 35 40

screen shot 2014-01-17 at 14 25 22

The cron is also running every minute and reports normal output.

I'm assuming of course the originality score and GradeMark link should show up within the assignment's grading overview/submission status table, as is the case with Dan Marsden's implementation - but apologies if I've misunderstood and should be looking elsewhere… We've also tested use of the plagiarism component within a forum but, again, no originality score or GradeMark Link are visible in relation an attached file.

If you know of anything else we can do to debug this I'd really be grateful.

need to handle long assignment names

Message: title - Please limit to 99 characters. You submitted 114

need something like this:
$maxnamelength = 85;
$shortname = (strlen($moduledata->name) > $maxnamelength) ? substr($moduledata->name, 0, $maxnamelength) : $moduledata->name;

Plagiarism plugins errors page isn't useful

The Errors page accessed via the plagiarism plugin settings page does show submissions that have failed but doesn't give any clue why they failed. It seems to be pretty useless without that.

Turnitin doesn't accept assignments that are uploaded after the due date.

Hi John

It looks like the module cutoff date check isn't working correctly.

The code here in particular:

// In Moodle 2.4 the preventlatesubmissions setting was removed and replaced by a cut off date
        if (isset($moduledata->preventlatesubmissions)) {
            $latesubmissionsallowed = ($moduledata->preventlatesubmissions = 1) ? 0 : 1;    // This is fine
        } else if (isset($moduledata->cutoffdate)) {
            if ($moduledata->cutoffdate == 0) {   // the default, which applies if the cutoff date isn't set
                $latesubmissionsallowed = 1;   // so this should be zero
            } else if ($moduledata->cutoffdate == $moduledata->duedate) {    // i don't think the cutoff date should ever match the due date
                $latesubmissionsallowed = 0;   // so this is correct
            }
        } else {
            $latesubmissionsallowed = 1;  // this is never reached, because the default is 0
        }

Environment:

  • Moodle 2.6.1

User symptom:

  • On the assignment grading page, some assignments do not display a turnitin result.

Testing instructions:

  • create an assignment and set the due date to before now.
  • submit a student assignment
  • run cron

Result:

  • turnitin returns an error (view in cron log or turnitin logs)
Handler function of component plagiarism_turnitin: 
s:17:"event_mod_created"; threw exception :turnitintooltwo/There was an error trying to create the assignment in Turnitin<br/><br/>
Fault Code: invaliddata 
| File: mod/turnitintooltwo/sdk/assignmentsoap.class.php 
| Line: 33 
| Message: date_due - due date must be after start date
date_post - post date must be after start date
  • the error is added to the events_queue and table.
  • later cron runs run into the same error
  • the events_queue and events_queue_handlers tables are filled with the same events each cron run.
  • the events are never cleared.

Workaround test:

  • Change the assignment due date to after now.
  • run cron.
  • the assignment will upload correctly.

Status reporting

There isn't much status reporting on the Plagiarims plugin if the file hasn't yet been submitted to turnitin.

It would be good if it displayed something along the lines as:

  • "Pending" - whilst the file has been uploaded to Moodle but not yet submitted to Turnitin
  • "Processing" - once it has been uploaded to Turnitin but no report has been returned
  • "Error" - if there was a problem submiting the file to turnitin (and a link to an error report).
    and then the current items displaying the originality score & link once everything is done.

No option to disable emails emitted by Turnitin

I just spoke with TII support and they indicated that there should be an option to prevent the emailing of students with information.

We're currently testing our upgrade to Moodle 2.6 & the TurnitinTool 2 plugin and we need to see what happens but without students actually being sent anything.

It would appear that in Turnitin Direct this is 3 settings:

  • Student Emails
  • Instructor Emails
  • Receipt Emails

These settings from what I can tell do not exist in the v2 module.

Note this is for enabling emails against the whole module, not individual assignments.

Colour coding mismatch

I've noticed the colour coding on the Moodle page is not consistent with the Tii colour coding (see screenshot). I think the new gradient may be confusing for some users - are there plans for this to be changed across Tii?

tiicolourcoding

Similarity score display problem when viewing submissions

Hi,

Similarity scores are not displayed for certain scores in default clean theme or where background white:

.tii_links_container .score_colour_ { background: #999999; color:#000000; }
.score_colour_0 { background-position: 0% 0%; color:#FFFFFF; }
.score_colour_10 { background-position: 0% 10%; color:#FFFFFF; }
.score_colour_20 { background-position: 0% 20%; color:#FFFFFF; }
.score_colour_30 { background-position: 0% 30%; }
.score_colour_40 { background-position: 0% 40%; }
.score_colour_50 { background-position: 0% 50%; }
.score_colour_60 { background-position: 0% 60%; }
.score_colour_70 { background-position: 0% 70%; }
.score_colour_80 { background-position: 0% 80%; color:#FFFFFF; }
.score_colour_90 { background-position: 0% 90%; color:#FFFFFF; }
.score_colour_100 { background-position: 0% 100%; color:#FFFFFF; }

The scores not displayed are the ones with color set to #FFFFFF;

I am also getting a 404 error for

.tii_links_container .score_colour {
    background-image:url(../../../../mod/turnitintooltwo/pix/gradback.jpg);

Cheers,

duplicate config settings

Hi John

Config settings are being duplicated for some course modules. For example

SELECT name,value FROM mdl_plagiarism_turnitin_config WHERE cm = 150850 order by name;

+-----------------------------------+-------------------+
|               name                |       value       |
+-----------------------------------+-------------------+
| plagiarism_anonymity              | 0                 |
| plagiarism_compare_institution    | 0                 |
| plagiarism_compare_institution    | 0                 |
| plagiarism_compare_internet       | 1                 |
| plagiarism_compare_internet       | 1                 |
| plagiarism_compare_journals       | 1                 |
| plagiarism_compare_journals       | 1                 |
| plagiarism_compare_student_papers | 1                 |
| plagiarism_compare_student_papers | 1                 |
| plagiarism_draft_submit           | 0                 |
| plagiarism_draft_submit           | 0                 |
| plagiarism_exclude_biblio         | 1                 |
| plagiarism_exclude_biblio         | 1                 |
| plagiarism_exclude_matches        | 0                 |
| plagiarism_exclude_matches        | 0                 |
| plagiarism_exclude_matches_value  | 0                 |
| plagiarism_exclude_matches_value  | 0                 |
| plagiarism_exclude_quoted         | 1                 |
| plagiarism_exclude_quoted         | 1                 |
| plagiarism_report_gen             | 1                 |
| plagiarism_report_gen             | 1                 |
| plagiarism_rubric                 |                   |
| plagiarism_show_student_report    | 1                 |
| plagiarism_show_student_report    | 1                 |
| plagiarism_show_student_score     | 1                 |
| plagiarism_show_student_score     | 1                 |
| plagiarism_submitpapersto         | 1                 |
| plagiarism_transmatch             | 0                 |
| turnitin_assign                   | Assignment-150850 |
| turnitin_assignid                 | 18377620          |
| turnitin_dtstart                  | 1372722579        |
| use_turnitin                      | 1                 |
| use_turnitin                      | 1                 |
+-----------------------------------+-------------------+

This is a minor issue, which only spits out a debugging message

"Did you remember to make the first column something unique in your call to get_records? Duplicate value 'plagiarism_show_student_score' found in column 'name'... line 1172 of plagiarism/turnitin/lib.php

But there may be a deeper bug that is creating the duplicates in the first place. I haven't been able to replicate the behaviour yet though.

settings.php 'calls home' for updates (bad) and does not use proxy settings

Settings.php attempts to access a url to check for updates. As settings.php is called all over the place in order to construct the administration menus this sort of thing is strongly discouraged. It can seriously slow down the site for admins. Worse - the update check does not honour the proxy settings, so if one is behind a proxy this feature will kill the site stone dead.

The check should be removed. The correct means of update checks is through Moodle's normal plugin interface.

Question: Are submissions by students with extensions uploaded to TII?

I have a Turnitin Assignment that had a due date of 11 June.

I've got a student account that has been granted an extension until the 15 Jun.

I can see the event being raised to send it to TII but the updated file never gets there.

If I modify the due date in tthe Moodle Assignment the file is submitted and appears in Turnitin.

I note that there is an option to allow submissions to Turnitin after the Due date within the TII service itself, but not in the plugin

Rubric selection not saving

Hi John, we're seeing a problem with the plagiarism plugin where, if you select a rubric in the "Attach a rubric to this assignment" setting of the "Turnitin plagiarism plugin settings" section on an assignment, and press either of the save buttons, the value isn't saved.

This is version 2014012403 of the plugin running on Moodle 2.6.3 (Build: 20140512)

In PP plugin, only original group uploader can access Grademark and/or OR reports

Platform: Moodle 2.6.4+ (Build: 20140731) with Turnitin Direct v2 plugin version 2014012405

Scenario: A Moodle Assignment is set to have students submit in groups and has the Turnitin Plagiarism Prevention plugin enabled. Teachers expect group submission Grademark and Originality Reports to be available to all group members.

Issue: When a group member makes a submission (and it is sent to Turnitin), the file appears for other group members in the instructor submissions interface, as expected. However, when the Grademark link or Originality Report (optionally) appears to students, only the group member who originally submitted the assignment can access these reports. Other group members cannot see the OR link. When other group members click the Grademark icon, they get the error:

Sorry, we could not process your request

You are not authorized to access this resource.

null similarityscore in plagiarism_turnitin_files but similarity score does exist

I can see a number of records in the table that have a null similarityscore but orcapable = 1 (and some entries orcapable = 0) - this means that the cron function doesn't pick them up to update the score and the files have been processed in Turnitin and a score and report does exist - having a null similarity score means that the link to the report doesn't appear even though one does actually exist.

any thoughts on what might cause it?

There seems to be no 'post date' in the plagiarism plugin version

I can't see any way to implement a 'post date' for when grades/comments become available to students. Staff only want students to see their results when all the submissions have been graded. At the moment it appears that students can access their results as soon as they are graded (in Grademark). Moodle allows the grade to be hidden in the (Moodle) Gradebook but this doesn't affect turnitin.

This would be a deal breaker for us unfortunately...

Settings and activity configuration

The settings page has a two options:

  • Use Anonymous Marking
  • Translated Matching
    image

which enable said functions, but also require them to be enabled on the actual turnitin service. It would appear that the when these are set to "Off" the corresponding options on the plagiarism plugin's settings still appear:
image

Shouldn't the corresponding elements on the form in the activity be hidden if they have been disabled at the server level?

When grading group submissions to Moodle Assignment with PP, only the original uploader's grade is sent to Moodle grade book

Platform: Moodle 2.6.4+ (Build: 20140731) with Turnitin Direct v2 plugin version 2014012405

Scenario: A Moodle Assignment is set to have students submit in groups and has the Turnitin Plagiarism Prevention plugin enabled. Teachers expect grades to apply to all group members.

Issue: When a group member makes a submission (and it is sent to Turnitin), the file appears for other group members as expected. However, when a teacher opens the Originality Report for any group member, then enters a score in the Turnitin Originality tab in the upper right (e.g. 51 OUT OF 100) and closes the window, the score is applied to the Moodle grade book, but only to the group member who originally submitted the file. So, if you clicked another group member's Originality Report link, the original submitter's submission appears. The score entered in that window does not apply to other group members.

What would be preferred: In cases where the Turnitin PP is used in Assignment groups, in the Originality window/tab, there should be a checkbox that is checked by default which says "Apply grade to entire group". This would be similar to behavior in the Moodle Assignment grading page for group submissions.

Trying to read array as object in plagiarism/turnitin/lib.php

At around line 1246 of lib.php there is this code...

                // If draft submissions are turned on then only submit to Turnitin if using newer than 2.3 and
                // the Turnitin draft submit setting is set.
                if ($moduledata->submissiondrafts && $CFG->branch > 23 &&
                    $plagiarismsettings->plagiarism_draft_submit == 1 &&
                    ($eventdata->event_type == 'file_uploaded' || $eventdata->event_type == 'content_uploaded')) {
                    return true;
                }

$plagiarismsettings->plagiuarism_draft_submit throws a notice as $plagiarismsettings (checked with var_dump just before this) is an array, not an object

SDK locking

I've just been trying to test various turnitin things as we migrate from TurnitinTool (TiiT) & Dan Marsden's turnitin plugin to TurnitinTool2 (TiiT2)

I've got a test server that has TiiT & TiiT2 installed on it.

TiiT runs it's connectivity check against TII and returns all fine, but TiiT2 returns "Could not connect to Turnitin. Double Check your API URL setting"

In both cases the URL set is "https://submit.ac.uk/api.asp"

Turning on the diagnostics and accessing the apilog shows:

2014-06-10 14:24:34 +0100 - ERROR -->
------------------------------------------------------------
Turnitin SDK Exception: VersionMismatch - Wrong Version
------------------------------------------------------------
------------------------------------------------------------
2014-06-10 14:24:35 +0100 - ERROR -->
------------------------------------------------------------
Turnitin SDK Exception: VersionMismatch - Wrong Version
------------------------------------------------------------

Does this mean that from now on Turnitin will be effectively protocol locking the module to a specific implementation of TII?

If so what is the intention of this being managed and notified to users? If TII update their SDK arbitrarily it could mean that submissions aren't passed across until their is an update made to the plugin, which we're not all in a position to simply do: there's planning for downtime and the (PR) effect of non-submission in the intervening period.

If this is going to happen we shall need to know well in advance of any changes that might result in there being a version mismatch.

Of course if this is just a bug, then this can all be disregarded...:-)

anonymous marking issue

I'm seeing this error in the logs too:
Handler function of component plagiarism_turnitin: s:19:"event_file_uploaded"; threw exception :turnitintooltwo/There was an error trying to create the assignment in Turnitin

Fault Code: invaliddata | File: /var/www/moodle/mod/turnitintooltwo/sdk/assignmentsoap.class.php | Line: 33 | Message: anonymous_marking_enabled - cannot set anonymous_marking_enabled field

not sure on the cause but it's holding up further file submissions - looking into it now.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.