latest version fails cron with "User has not accepted EULA" about moodledirectv2 HOT 6 CLOSED

Example (from cron run)...

User has not accepted EULA
++ Handler function of component plagiarism_turnitin: s:19:"event_file_uploaded"; requested resending of event! ++

• line 366 of /lib/eventslib.php: call to debugging()
• line 450 of /lib/eventslib.php: call to events_process_queued_handler()
• line 45 of /lib/classes/task/events_cron_task.php: call to events_cron()
• line 73 of /lib/cronlib.php: call to core\task\events_cron_task->execute()
• line 61 of /admin/cli/cron.php: call to cron_run()

from moodledirectv2.

Ok - this doesn't look like a problem. However, it might be easier from a debugging point of view to add a bit more information to the cron trace. Could the userid and something to identify the activity be displayed (e.g. the cmid) so that when an 'error' like that appears it is possible to see who/what it relates to?

from moodledirectv2.

Hi Howard, good to hear.
I'll add some info to help debugging in an upcoming release.
Cheers
John

from moodledirectv2.

this is a problem because the event_handler returns "false" in this state - preventing any further processing of any events of that type. holding up any further submissions and there is no way to clear it.

from moodledirectv2.

This has proven to be a major problem for us. A few students didn't accept the EULA and their submissions held up the queue for 5000+ other events over the course of a week or so.

We've now fixed it by moving the EULA link to the actual submission page (rather than the activity main page) and requiring that the student accepts the EULA before the submission will be accepted. That way the submission event never makes it to the queue until it's cleared for take-off to the Turnitin API.

This requires a change in Moodle core for which I have raised a tracker issue at https://tracker.moodle.org/browse/MDL-47453 (and submitted the code for review). The commits for the Turnitin plugins are:
lucisgit@cd90f37
lucisgit@2108962
lucisgit@ff87e6d

from moodledirectv2.

From version 2014012409 onwards the cron will remove submission events from the queue if the user has not accepted the EULA as the workflows aren't compatible with each other. With the EULA moving in to the submission page and the plugin hiding the form unless the EULA is accepted this scenario shouldn't occur going forward anyway.

from moodledirectv2.