Issue Description:

I am trying to archive my app, but I get 'No such module 'MaterialComponents' error. The app runs on simulator and real device.

This is my ppod file:

Uncomment the next line to define a global platform for your project# Uncomment the next line to define a global platform for your project# platform :ios, '10.0'*

Comment the next line if you're not using Swift and don't want to use dynamic frameworks use_frameworks!
# Pods for Učiti Engleski

pod 'Firebase/Core'

pod 'Firebase/Database'

pod 'Firebase/Auth'

pod 'Firebase/Crash'

pod 'Google-Mobile-Ads-SDK','~>8.0'

pod 'MaterialComponents/Cards'

pod 'OneSignal', '>= 3.0.0', '< 4.0'
end
target 'OneSignalNotificationServiceExtension' do

#only copy below line use_frameworks!
pod 'OneSignal', '>= 3.0.0', '< 4.0'end

Issue Description:

  1> (0..<10).map { x
  2.     x + 1
  3. }
error: repl.swift:1:10: error: cannot invoke 'map' with an argument list of type '(@escaping () -> ())'
(0..<10).map { x
         ^

repl.swift:1:10: note: expected an argument list of type '((Self.Element) throws -> T)'
(0..<10).map { x
         ^

I've also seen, "Contextual type for closure argument list expects 1 argument, which cannot be implicitly ignored" (small reproducer harder to generate). Either way we should have an error saying "in" is missing and a fixit to insert it.

Issue Description:

Given the following code:

class MyFunc {
    init(param: String) {}
}

The position of `initKeyword` returns the incorrect values:

(lldb) po syntax.initKeyword.position
▿ AbsolutePosition
  - utf8Offset : 14
  - line : 1
  - column : 15

Expected values are:

line: 2

column: 5

offset: 19

Issue Description:

I get a crash running a visitor over this Swift code:

extension AnyError: LocalizedError {
    public var failureReason: String? {
        return (error as? LocalizedError)?.failureReason
    }
}

Here's the top of the backtrace:

* thread #​27, queue = 'com.apple.root.user-initiated-qos', stop reason = EXC_BAD_ACCESS (code=2, address=0x70000602ffd8)
    frame #​0: 0x00000001003526a2 SwiftSyntax`outlined copy of SwiftSyntax.TokenKind + 130
    frame #​1: 0x00000001003525fd SwiftSyntax`outlined copy of SwiftSyntax.(RawSyntaxData in _387FCEF5221330B5D0404835477A54E9) + 93
    frame #&#8203;2: 0x000000010035cf77 SwiftSyntax`initializeWithCopy for RawSyntax at <compiler-generated>:0
    frame #&#8203;3: 0x000000010139d9c6 libswiftCore.dylib`initializeWithCopy value witness for (extension in Swift):Swift.ClosedRange< where A: Swift.Strideable, A.Stride: Swift.SignedInteger>.Index + 86
    frame #&#8203;4: 0x0000000101122dc3 libswiftCore.dylib`Swift.Array._getElement(_: Swift.Int, wasNativeTypeChecked: Swift.Bool, matchingSubscriptCheck: Swift._DependenceToken) -> A + 83
    frame #&#8203;5: 0x0000000101122cc2 libswiftCore.dylib`Swift.Array.subscript.getter : (Swift.Int) -> A + 130
    frame #&#8203;6: 0x0000000101123727 libswiftCore.dylib`protocol witness for Swift.BidirectionalCollection.subscript.getter : (A.Index) -> A.Element in conformance Swift.Array<A> : Swift.BidirectionalCollection in Swift + 23
    frame #&#8203;7: 0x00000001013c6559 libswiftCore.dylib`protocol witness for Swift.Collection.subscript.getter : (A.Index) -> A.Element in conformance Swift.Array<A> : Swift.Collection in Swift + 9
    frame #&#8203;8: 0x00000001010ec5ee libswiftCore.dylib`(extension in Swift):Swift.Collection.map<A>((A.Element) throws -> A1) throws -> Swift.Array<A1> + 494
  * frame #&#8203;9: 0x0000000100377e17 SwiftSyntax`SyntaxData.init(raw=SwiftSyntax.RawSyntax @ 0x00007000060306c0, indexInParent=0, parent=0x000060c0000e7000, self=0x000060c0000e7b00) at SyntaxData.swift:95
    frame #&#8203;10: 0x0000000100377b77 SwiftSyntax`SyntaxData.__allocating_init(raw:indexInParent:parent:) at SyntaxData.swift:0
    frame #&#8203;11: 0x000000010037886e SwiftSyntax`SyntaxData.realizeChild(index=0, self=0x000060c0000e7000) at SyntaxData.swift:232
    frame #&#8203;12: 0x0000000100378382 SwiftSyntax`closure #&#8203;1 in SyntaxData.cachedChild(self=0x000060c0000e7000, index=0) at SyntaxData.swift:120

Attachment: Download

Issue Description:

I created a bare-bones Visitor and fed it the generated interface that Xcode shows from the Swift stdlib. It crashes here on the last line:

  public func child(at index: Int) -> Syntax? {
    guard raw.layout.indices.contains(index) else { return nil }
    guard let childData = data.cachedChild(at: index) else { return nil }
    return makeSyntax(root: _root, data: childData)
  }

I've attached the generated interface that I'm trying to visit. Since it's the generated interface, it doesn't have definitions for any of the functions. That might be what's causing problems.

But I think this should still work and it definitely shouldn't crash.

Issue Description:

Due to the recursion in SwiftSyntax's SyntaxVisitor, it's easy to trigger a stack overflow due to too much recursive calls. This is especially easy to trigger if you run visitors on multiple threads concurrently, if you compile with a debug configuration or if you run with tsan. For example:

ThreadSanitizer:DEADLYSIGNAL
==720==ERROR: ThreadSanitizer: stack-overflow on address 0x7e8000189b00 (pc 0x00010601afd1 bp 0x7e800018c790 sp 0x7e8000186e50 T10952)
ThreadSanitizer:DEADLYSIGNAL
    #​0 SyntaxVisitor.visit(_:) SyntaxRewriter.swift:1699 (libSwiftSyntax.dylib:x86_64+0x683fd0)

SUMMARY: ThreadSanitizer: stack-overflow SyntaxRewriter.swift:1699 in SyntaxVisitor.visit(_:)
==720==ABORTING
Received 'abort trap' signal

Example here: realm/SwiftLint#2480

If it would help, I can take some time to create a more focused repro case, just ask.

Attachment: Download

Issue Description:

In swift-format, we were using the following code snippet to test how we handled syntax trees that contained Unknown*Syntax nodes:

{{ @unknown foo class Bar {}}}

At some point fairly recently in main (I'm using the 2021-04-26 development snapshot), the parser behavior changed and it now parses this as valid; the result is two CodeBlockItems:

1. a TypeExpr containing the AttributedType @unknown foo

2. the ClassDecl class Bar {}

Something similar happens with a malformed @unknown default:

{{ switch a {}}
{{ case x: break}}
{{ @unknown foo default: break}}
{{ }}}

This body of case x is parsed as two CodeBlockItems (break, then @unknown foo), and then the next SwitchCase starts at the default.

Are these changes expected?

To reproduce:

1. Download the attached project.

2. Use a development toolchain that is syntax-compatible with swift-syntax's main branch (at the time I'm writing this, 2021-04-26 worked).

3. Run swift run UnknownAttr.

4. Observe the tree output.

Issue Description:

On Ubuntu 18.04, at commit c43eb9b (~noon Aug 9 HEAD), I'm getting memory leaks when doing code completion. To reproduce,

1. swift/utils/build-script --release --enable-lsan --debug-swift-stdlib

2. llvm/utils/lit/lit.py build/Ninja-ReleaseAssert+stdlib-DebugAssert/swift-linux-x86_64/test-linux-x86_64/IDE/complete_repl_identifier_prefix_1.swift -a

LSAN should print out leaks. Here's what I get: https://gist.github.com/marcrasi/7d1f5e5766833c605b92873687eb49ca

This does not occur at commit 482d062 and does occur at commit 1a211e6, so I suspect that swiftlang/swift#26403 caused it.

Attachment: Download

Issue Description:

All contextual keyword's token kind is `identifier` for now, but I would like to have them as keyword kind instead.

For example, I was expecting to have `weakKeyword` for below variable declaration, but I got `identifier("weak")` in SwiftSyntax. In this context, it can tell keyword, not identifier.

Same thing happens to other contextual keywords as well.

@IBOutlet private weak var button: UIButton!

Sample code:

// sample.swift
class View {
 @IBOutlet private weak var button: UIButton!
}

 $swiftc -frontend -emit-syntax sample.swift  

Expected:

"tokenKind":{"kind":"kw_weak"} 

Actual:

"tokenKind":{"kind":"identifier","text":"weak"}

Environment:

Xcode 10.2 beta 3 (10P99q)

Apple Swift version 5.0 (swiftlang-1001.0.63.8 clang-1001.0.43)
Target: x86_64-apple-darwin18.2.0

Issue Description:

In the Swift 4.2 release, childen of a `MemberDeclListSyntax` type were typed, thus the following code was working:

let enumCaseDeclarations: [EnumCaseDeclSyntax] = enumDeclaration.members.members.children.compactMap { $0 as? EnumCaseDeclSyntax }

But after updating to Xcode 10.2 today, which includes the Swift 5.0 release, all `children` members are of type `Syntax` and casting to `EnumCaseDeclSyntax` fails, although that's the type I'm expecting here. You can find an example Swift file being parsed here.

Why was this API changed to be less informative? And how am I supposed to cast it to the appropriate type going forward with the 5.0 release?

It would be great to get feedback soon, so I can make a Xcode 10.2 compatible release of my tool BartyCrouch. See also the appropriate line here.

Thank you for your help in advance!

Issue Description:

Currently Swift Syntax vends a dynamic product (https://github.com/apple/swift-syntax/blob/master/Package.swift#L8).

This creates issues when trying to link a static executable that uses Swift Syntax. Is there any way this could be changed to a normal product?

Attachment: Download

Issue Description:

SourceLocationConverter has 2 initializers, one uses a String and the other uses a SourceFileSyntax. Based on my testing, the String based initializer is noticeably faster than using a SourceFileSyntax.

For a test case, I selected a relatively large file from swift-syntax (~ 10k LOC). The initializer that accepts a string takes ~ 2ms while the other initializer takes ~ 70 ms.

Issue Description:

Using Xcode 12.5 I have identified an issue with this instruction "(Self.self)" when it runs on a build created setting SWIFT_OPTIMIZATION_LEVEL to -O (Optimize for speed).

The instruction above is executed in a superclass (subclass of UIView) when it to load a NIB:

Bundle.main.loadNibNamed("\(Self.self)", owner: self, options: nil)

Instead of getting the right subclass name, it simply returns "Self" and this generate the following error:

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not load NIB in bundle: '...' with name 'Self''

This never happens before with previous versions of Xcode, and it still does not happen when the build is generate without using optimization -Onone.

To fix it I have changed "(Self.self)" with "(type(of: self))". This way it works, but I think that it should be investigate why the original version causes that kind of issue when Swift is optimized.

Forcing optimization in Debug, I was able to reproduce the issue. I have also tried to insert a breakpoint before the crash, trying to execute the instruction in Console with po command, but it works as expected, printing the right class name.

relates to:

• SR-10469 Unknown syntax for interpolated string literal

Issue Description:

Background
I would like to have a better way to extract raw string without quotes from `StringLiteralExprSyntax`. `StringInterpolationExprSyntax` looks well-organized because its cursor has openQuote, segments and closeQuote to express strings and quotes separately.

My proposal

Can we have quotes in children of StringLiteralExpr like StringInterpolationExpr?
https://github.com/apple/swift/blob/c04a7dec9f739fbe53f3c305a32e8d426972bfd8/utils/gyb_syntax_support/ExprNodes.py#L266:L269

https://github.com/apple/swift/blob/c04a7dec9f739fbe53f3c305a32e8d426972bfd8/utils/gyb_syntax_support/ExprNodes.py#L468:L481

References

Data structures and examples are below.

public struct StringLiteralExprSyntax: ExprSyntax, _SyntaxBase, Hashable {
  enum Cursor: Int {
    case stringLiteral
  }
}

// let foo = "foo"
print(node.stringLiteral.text) // "\"foo\""

public struct StringInterpolationExprSyntax: ExprSyntax, _SyntaxBase, Hashable {
  enum Cursor: Int {
    case openQuote
    case segments
    case closeQuote
  }
}

// let foo = "foo \(bar)"
print((node.segments[0] as! StringSegmentSyntax).content.text) // "foo"

Issue Description:

I want to develop about function decleare syntax rewriter library and I found withEllipsis(_🙂 function under the FunctionParameterSyntax and I want to use this function.

But I can not find `SyntaxFactory.makeEllipsisToken` like `SyntaxFactory.makeCommaToken`. It means can not set new ellipsis token. I confirmed that generated of swift syntax code. . But I did not get that insntanciate token of ellipsis function.

Environment

Issue Description:

There's no release for SwiftSyntax that works with Xcode 11 GMs out-of-the-box.

Issue Description:

Not sure if this is a bug, or a feature request, so I'm filing it as a bug for the moment.

I am using SwiftSyntax to parse a definition file (to be clear, I'm talking about the file generated by Xcode when you right click on a symbol and select "jump to definition").

For example, a stripped-down piece of the SwiftUI definition file looks like this:

public struct Binding<Value> {
  public var wrappedValue: Value { get nonmutating set }
  public var projectedValue: Binding<Value> { get }
}

The projectedValue variable is properly parsed as VariableDeclSyntax, but wrappedValue is parsed as UnknownDeclSyntax. The "set" part is what makes SwiftSyntax to not detect a variable.

This makes sense in a way, as that is not a valid syntax to use while writing code. However, in the context of the definition file it is ok. The color coding in Xcode also provides a hint, as the "nonmutating set" shows uncolored.

I tried to dig a little more, but I think the problem (if it is such), resides in the lib_InternalSwiftSyntaxParser.dylib library.

Issue Description:

When FunctionParameterSyntax.ellipsis property access, It returned wrong token about `tokenKind.kind == "comma"`.
You can check problem with after exec SwiftSyntax-issue-ellipsis.
And It can check result SwiftSyntax-issue-ellipsis repository's README.

SwiftSyntax-issue-ellipsis: https://github.com/omochi/SwiftSyntax-issue-ellipsis/blob/master/Sources/SwiftSyntax-issue-ellipsis/main.swift

Result

ccc: Int, 
---ellipsis---
TokenSyntax
, 
---
no trailing comma
Program ended with exit code: 0

So, I access `ellipsis`(...), But I got `comma`(,) token.

And I confirmed more case for $ swiftc -emit-syntax swift-syntax-source.swift result json.
It estimates in the specifity range in gist.

I guess that expected order of layout.

But I got

So, `Elilpsis=,` and `TrailingComma=null` are wrong result.

Attachment: Download

relates to:

• SR-2373 Trailing doc comment should not be attached to the next declaration

Issue Description:

According to the libSyntax documentation:

1. A token owns all of its trailing trivia up to, but not including, the next newline character.
2. Looking backward in the text, a token owns all of the leading trivia up to and including the first contiguous sequence of newlines characters.

The following code should have leading / trailing trivias as follows:

let x = 1 // This should be "1"'s trailing trivia
/// This should be `var`'s leading trivia
var y = 2

But actually, both comments are bundled as `var`'s leading trivia.

You can test the code at https://swift-ast-explorer.kishikawakatsumi.com/ (screenshot attached).

By the way, in TypeScript, it seems to work as is:
https://github.com/basarat/typescript-book/blob/master/docs/compiler/ast-trivia.md

relates to:

• SR-245 Missing @warn_unused_result attributes in Standard Library

Issue Description:

Try the following code:

var x = 0
let capture: () -> Int = { [x]
  return x
}
x++
capture()

Expected result: because there is a capture list [x] that should capture x by value, we expect the result of the final call to be 0. However, it is 1. This is because we forget the in keyword, and [x] gets parsed as an array literal.

A possible solution would be to warn about [x] being an unused expression.

Issue Description:

The 0.40200.0 release is unable to parse #warning("msg") and #error("msg") directives, despite being part of 4.2.

Issue Description:

After the PR for SR-11580 merged, there was consensus, based on feedback, that the new convenience methods floatingValue and integerValue, should be optional in order to prevent potential crashes. This story is for implementation of this change. There was additional feedback involving naming and genericity. Depending on PR-review feedback, this story may encompass implementation of these changes as well.

Issue Description:

SwitchCaseList syntax node currently has Syntax type for element.

# switch-case-list -> switch-case switch-case-list?
Node('SwitchCaseList', kind='SyntaxCollection',
  element='Syntax', element_name='SwitchCase',
  element_choices=['SwitchCase', 'IfConfigDecl']),

However, I think we can make it SwitchCase instead of Syntax. Is there any case for SwitchCaseList to have multiple types of Syntax other than SwitchCase?

Issue Description:

While implementing SR-11580, I noticed that the filename CustomReflecatbleTests.swift is misspelled. This is a perfect starter bug. The only steps to fix it are to correct the filename and ensure that SwiftSyntax unit tests still pass.

I myself am a newcomer to compiler development, so the following build-script invocation may be suboptimal, but it should work to build Swift and SwiftSyntax (if necessary) and run the SwiftSyntax unit tests. Run this from the parent folder of swift and swift-syntax. Build-and-test output will go to ~/Desktop/allout.txt.

time swift/utils/build-script --swiftsyntax --swiftpm --llbuild -t --skip-test-cmark --skip-test-swift --skip-test-llbuild --skip-test-swiftpm --infer > ~/Desktop/allout.txt 2>&1

I got build errors before adding the --infer argument, and I am unclear why it is not the default.

Issue Description:

Often, when dealing with FloatLiteralExprSyntax or IntegerLiteralExprSyntax, you want to get the value they represent. SwiftSyntax should provide computed properties that return these.

The catch with it is, that we need to support all kinds of literals that are supported in Swift. In addition to the obvious ones this includes:

• Literals with underscores

• Hexadecimal int literals

• Octal int literals

• Binary int literals

• Exponential float literals (e.g. 5e+2)

• Hexadecimal float literals with possible exponents (e.g. 0x5.fp+2)

#148 started implementing these but gave up on the less obvious literals.

Issue Description:

Hi,

I tried to parse the following file Signal-iOS/ProfileFetcherJob.swift at master · signalapp/Signal-iOS · GitHub with SwiftSyntax and received multiple errors about unresolved syntax (especially in value bindings)

E.g. the highlighted snippet on the code was marked as UnresolvedPatternExprSyntax. It can be reproduced using code:

        let sourceSyntax: SourceFileSyntax = try SyntaxParser.parse(URL(fileURLWithPath: source))
        class UnresolvedSyntaxVisitor: SyntaxVisitor {
            override func visit(_ node: UnresolvedPatternExprSyntax) -> SyntaxVisitorContinueKind {
                print(node)
                return .skipChildren
            }
        }
        UnresolvedSyntaxVisitor().walk(sourceSyntax)

Attachment: Download

Issue Description:

For example, when `StructDecl`'s inner `VariableDecl` has semicolon, AST will have `UnknownDecl`.

struct Foo {
    let x = 1;
}

Issue Description:

Overview

It seems like that `StringInterpolationExpr` doesn't have syntax info of raw strings literal(#). Is this expected behavior? If so, formatter/rewriter tools might have an issue because generated swift code from libSyntax/SwiftSyntax would be a bit different from input swift code.

Examples

As you can see below example, raw strings literal `#` is eliminated in syntax tree.

// sample.swift
#"foo \#(bar)"#

// swift -frontend -emit-syntax sample.swift
{"id":18,"kind":"SourceFile","layout":[{"id":17,"kind":"CodeBlockItemList","layout":[{"id":14,"kind":"CodeBlockItem","layout":[{"id":13,"kind":"StringInterpolationExpr","layout":[{"id":1,"tokenKind":{"kind":"string_quote"},"leadingTrivia":[],"trailingTrivia":[],"presence":"Present"},{"id":12,"kind":"StringInterpolationSegments","layout":[{"id":3,"kind":"StringSegment","layout":[{"id":2,"tokenKind":{"kind":"string_segment","text":"foo "},"leadingTrivia":[],"trailingTrivia":[],"presence":"Present"}],"presence":"Present"},{"id":9,"kind":"ExpressionSegment","layout":[{"id":4,"tokenKind":{"kind":"backslash"},"leadingTrivia":[],"trailingTrivia":[],"presence":"Present"},{"id":5,"tokenKind":{"kind":"l_paren"},"leadingTrivia":[],"trailingTrivia":[],"presence":"Present"},{"id":7,"kind":"IdentifierExpr","layout":[{"id":6,"tokenKind":{"kind":"identifier","text":"bar"},"leadingTrivia":[],"trailingTrivia":[],"presence":"Present"},null],"presence":"Present"},{"id":8,"tokenKind":{"kind":"string_interpolation_anchor"},"leadingTrivia":[],"trailingTrivia":[],"presence":"Present"}],"presence":"Present"},{"id":11,"kind":"StringSegment","layout":[{"id":10,"tokenKind":{"kind":"string_segment","text":""},"leadingTrivia":[],"trailingTrivia":[],"presence":"Present"}],"presence":"Present"}],"presence":"Present"},{"id":1,"tokenKind":{"kind":"string_quote"},"leadingTrivia":[],"trailingTrivia":[],"presence":"Present"}],"presence":"Present"},null,null],"presence":"Present"}],"presence":"Present"},{"id":16,"tokenKind":{"kind":"eof","text":""},"leadingTrivia":[{"kind":"Newline","value":1}],"trailingTrivia":[],"presence":"Present"}],"presence":"Present"}

Qestions

Can we have the raw strings literal as token kind like pound in syntax tree? This can be eliminated in AST as it is.

Issue Description:

Please checkout the code below.

import Foundation

func test(_ work: () throws -> Void) throws {
    try work()
}

do {
    try test {
        
/* Error is not handled because the enclosing function is not declared 'throws' */
        defer { throw NSError(domain: "", code: 0, userInfo: nil) }
        
        print("hello")
    }
    
} catch {
     print(error.localizedDescription)
}

This code emits error that says "Error is not handled because the enclosing function is not declared 'throws'" for throwing in defer statement.

Issue Description:

I'm trying to build SwiftSyntax for iOS using the simple steps described in the README: https://github.com/apple/swift-syntax/blob/main/README.md

git clone https://github.com/apple/swift.git
./swift/utils/update-checkout --clone
./swift/utils/build-parser-lib --release --no-assertions --build-dir /tmp/parser-lib-build-ios --host iphoneos --architectures arm64

Unfortunately that fails pretty quickly in the CC detection:

-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - broken
CMake Error at /usr/local/Cellar/cmake/3.20.3/share/cmake/Modules/CMakeTestCCompiler.cmake:66 (message):
  The C compiler

    "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /tmp/parser-lib-build-ios/arm64/obj/CMakeFiles/CMakeTmp
    
    Run Build Command(s):/usr/local/bin/ninja cmTC_3a1e2 && [1/2] Building C object CMakeFiles/cmTC_3a1e2.dir/testCCompiler.c.o
    [2/2] Linking C executable cmTC_3a1e2
    FAILED: cmTC_3a1e2 
    : && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -arch arm64 -target arm64-apple-ios10.0  -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk -miphoneos-version-min=10.0 -Wl,-search_paths_first -Wl,-headerpad_max_install_names  CMakeFiles/cmTC_3a1e2.dir/testCCompiler.c.o -o cmTC_3a1e2   && :
    ld: warning: ignoring file /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk/usr/lib/libSystem.tbd, missing required architecture x86_64 in file /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk/usr/lib/libSystem.tbd (4 slices)
    ld: dynamic main executables must link with libSystem.dylib for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.

Issue Description:

For a file containing the following code:

#if swift(<4)
 print(1)
#endif

a Syntax tree produced using sourcekitd generates an UnknownSyntax node but with swiftc -emit-syntax it works fine.

Issue Description:

In the following code, the guard statement is misspelled, and it results in 6 errors, plus notes and warnings! It'd be neat if the compiler detected when the "consecutive statements" error starts with the identifier gaurd, and assumed that guard was what was meant (along with a fixit so the user swaps it). I think that only doing this when that error occurs is important, because someone could legitimately have var gaurd = 1; gaurd = 2; print(gaurd), and none of those should change to guard.

func foo() -> Int? { return 0 }
func bar() {
    gaurd let x = foo() else { return }
    print(x)
}

guard.swift:3:10: error: consecutive statements on a line must be separated by ';'
    gaurd let x = foo() else { return }
         ^
         ;
guard.swift:3:24: error: consecutive statements on a line must be separated by ';'
    gaurd let x = foo() else { return }
                       ^
                       ;
guard.swift:3:25: error: expected expression
    gaurd let x = foo() else { return }
                        ^
guard.swift:3:5: error: use of unresolved identifier 'gaurd'
    gaurd let x = foo() else { return }
    ^~~~~
guard.swift:3:30: error: closure expression is unused
    gaurd let x = foo() else { return }
                             ^
guard.swift:3:30: note: did you mean to use a 'do' statement?
    gaurd let x = foo() else { return }
                             ^
                             do 
guard.swift:4:11: warning: expression implicitly coerced from 'Int?' to 'Any'
    print(x)
          ^
guard.swift:4:11: note: provide a default value to avoid this warning
    print(x)
          ^
            ?? <#default value#>
guard.swift:4:11: note: force-unwrap the value to avoid this warning
    print(x)
          ^
           !
guard.swift:4:11: note: explicitly cast to 'Any' with 'as Any' to silence this warning
    print(x)
          ^
            as Any

Possible new version:

guard.swift:3:10: error: consecutive statements on a line must be separated by ';'; did you misspell 'guard'?
    gaurd let x = foo() else { return }
    ^~~~~
    guard

Issue Description:

I had seen it before on an `#if !os(macOS)` but I wasn't able to replicate.

Basically, SwiftSyntax crashes on pound syntax, notably `#file`

Version:
`.package(url: "https://github.com/apple/swift-syntax", from: "0.40200.0"),`

Repro:
```
func example() {
let _ = #file
}
```

Create a SyntaxVisitor that visits functions. It was crashing with a `bus 10` error.

Issue Description:

Xcode 12 just went GM today and iOS 14 is scheduled to be released tomorrow but we don't have a Swift 5.3 version available in SwiftSyntax to be able to update the libraries that use it in Xcode 12.

I've tried using the last available release to date https://github.com/apple/swift-syntax/releases/tag/swift-DEVELOPMENT-SNAPSHOT-2020-09-11-a and the last Xcode available (Version 12.0 (12A7208)) and I'm getting

> stderr: Error: The loaded '_InternalSwiftSyntaxParser' library is from a toolchain that is not compatible with this version of SwiftSyntax

when running SwiftSyntax.

Attachment: Download

Issue Description:

I've more-or-less copied the Package.swift from the SwiftSyntax README, but it fails to build with Xcode 10 beta 6. From what I understand from the README, this should work. I'm not sure what I'm doing wrong.

I've attached the project I'm using and with the log (it's quite long).

Attachment: Download

Issue Description:

This is a repro of a case that recently started failing in one of swift-format's tests against the main branch (I'm using the 2021-04-26 development snapshot as my current environment).

When parsing the following source code:

{{ let x: (A -> B)}}

(Note that "A" should have its own parentheses surrounding it for this to be valid.)

The parser crashes with the following message:

Assertion failed: (isValid() && "length does not make sense for an invalid range"), function getByteLength, file /Users/buildnode/jenkins/workspace/oss-swift-package-macos/swift/include/swift/Basic/SourceLoc.h, line 218.

I would expect this to fail in some other, non-crashing fashion, such as expressing the syntax using Unknown* nodes.

To reproduce:

1. Download the attached project.

2. Use a development toolchain that is syntax-compatible with swift-syntax's main branch (at the time I'm writing this, 2021-04-26 worked).

3. Run swift run TriviaCrash.

Issue Description:

Invoking swift-syntax/build-script.py as per instructions in the README plainly doesn't work. Instead, it produces an error: argument --toolchain is required. Providing a path to the toolchain doesn't work either. The instructions must be updated to show something that can actually be invoked.

Attachment: Download

Issue Description:

Attempting to make an api call, unable to identify why I am getting the below message.

Failed to produce diagnostic for expression; please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project

// code placeholder
    var body: some View{
        //Nationgation View..
        
        NavigationView{
           
            ScrollView(.vertical, showsIndicators: true, content:{
                VStack(spacing: 15){
                    
                    //Search Bar...
                    HStack(spacing: 10) {
                       
                        Image( systemName: "magnifyingglass")
                            .foregroundColor(.gray)
                        
                        TextField("Search Character", text: $homeData.searchQuery)
                            .autocapitalization(.none)
                            .disableAutocorrection(true)
                    }
                    .padding(.vertical,10)
                    .padding(.horizontal)
                    .background(Color.white)
                    
                    //Shadows...
                    .shadow(color: Color.black.opacity(0.06), radius: 5, x: 5, y:5)
                    .shadow(color: Color.black.opacity(0.06), radius: 5, x: -5, y: -5)
                }
                .padding()
                if let characters = homeData.fetchedPorn{
                    
                    if characters.isEmpty{
                        
                        //No Results
                        Text("No Result Found")
                            .padding(.top,20)
                    }
                    else{
                        
                        // Displaying results
                        ForEach(characters){data in
                            
                           CharacterRowView(character: data)
                            
                            
                        }
                    }
                }
                else{
                    if homeData.searchQuery != ""{
                    //Lokading Screem
                    ProgressView()
                        .padding(.top,20)
                    }
                }
            })
            .navigationTitle("Marvel Characters")
        }
    }

Issue Description:

It's not possible to build swift-syntax with a downloaded Swift snapshot toolchain - it requires to clone the swift repository to use the gyb dependencies.

see discussion: #69 (comment)

Issue Description:

From the SwiftSyntax README:

Swift-CI will automatically run the code generation step whenever a new toolchain (development snapshot or release) is published. It should thus almost never be necessary to perform the above build yourself.

However, this appears to have only worked once:

$ git tag --list
0.40200.0
swift-4.2-DEVELOPMENT-SNAPSHOT-2018-08-25-a
swift-DEVELOPMENT-SNAPSHOT-2018-08-25-a

This makes it hard to use SwiftSyntax using the Swift Package Manager with any changes that have been merged in the last 3 months.

Issue Description:

Each syntax node has a contentLength property, which does not count the length of trivia. It would be great to have a way to get the text corresponding to this content. Currently, achieving this task is not super easy.

@harlanhaskins @akyrtzi

Attachment: Download

Issue Description:

The expectation is that SwiftRewriter and SwiftVisitor would behave exactly the same when visiting noted.

This doesn't seem to be the case, since in the attached code SwiftRewriter is triggered, while SwiftVisitor is not.

Confirmed this is a bug here

Small repro attached.

Issue Description:

Given the following code:

class MyClass {
    func myFunc(param1: String,
                param2: String) {}
}

The line position of the FunctionParameterSyntax for param2 is incorrectly identified as 2, it should be 3. The line for param1 is correctly identified as 2.

Issue Description:

I'm trying to create and use a SyntaxRewriter subclass from a thread other than main. I'm not sharing between threads, so it seems like it should be fine. However, I get an EXEC_BAD_ACCESS inside of SwiftSyntax. Here's some sample code that demonstrates the problem, which is adapted from the SwiftSyntax README's sample code:

let string = """

protocol P {
    var x: Int? { get set }
}


"""

let queue = DispatchQueue.global()
let sourceFile = try! SyntaxParser.parse(source: string)
let semaphore = DispatchSemaphore(value: 0)
queue.async {
    _ = Renamer().visit(sourceFile)
    semaphore.signal()
}
semaphore.wait()
print("done")

It crashes with an EXEC_BAD_ACCESS, typically in `SyntaxRewriter.visitChildren()`. Trying to print any variables in the debugger outputs "Trying to put the stack in unreadable memory at <some memory address>".

I can't reproduce this in an optimized build.

Attachment: Download

Issue Description:

I have a test project using swift-syntax. Project can parse and dump a .swift file successfully. Same project cannot parse and dump a .swiftinterface file.

It would be super-useful to be able to parse .swiftinterface files too.

Attachment: Download

Issue Description:

Hey there folks. I greatly appreciate your time. If there's anything at all I can supply to help solve this - or to help produce a better bug/support ticket - please let me know!

The context

I am attempting to build a custom version of `lib_InternalSwiftSyntaxParser.dylib` to embed in iOS as described in the repositories below:

https://github.com/apple/swift-syntax
https://github.com/apple/swift

My configuration is:

# swift-DEVELOPMENT-SNAPSHOT-2020-09-23-a installed at /Library/Developer/Toolchains
$ echo $TOOLCHAINS
swift

$ xcrun --find swift
/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2020-09-23-a.xctoolchain/usr/bin/swift

$ xcrun --toolchain default --find swift
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift

$ xcrun --toolchain swift --find swift
/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2020-09-23-a.xctoolchain/usr/bin/swift

# showing that --toolchain with bad input goes back to default
$ xcrun --toolchain random_string_that_shouldnt_do_anything --find swift
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift

So far, I have successfully built the main swift repository with

$ ./swift/utils/build-script --clean

... and I am using the built `.dylib` from that effectively in a macOS application.

The crash

$ ./swift/utils/build-parser-lib --release --no-assertions --build-dir /tmp/parser-lib-build-ios --host iphoneos --architectures arm64

[ ... many many lines of build information later ...]

[1/2] Linking CXX shared library lib/lib_InternalSwiftSyntaxParser.dylib
FAILED: lib/lib_InternalSwiftSyntaxParser.dylib
: && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -arch arm64 -miphoneos-version-min=10.0 -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -Wno-nested-anon-types -Werror=switch -Wdocumentation -Wimplicit-fallthrough -Wunreachable-code -Woverloaded-virtual -DOBJC_OLD_DISPATCH_PROTOTYPES=0 -O2 -g -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.0.sdk -dynamiclib -Wl,-headerpad_max_install_names -Wl,-exported_symbols_list,"/tmp/parser-lib-build-ios/arm64/obj/tools/swift/tools/libSwiftSyntaxParser/libSwiftSyntaxParser.exports" -Wl,-dead_strip -target arm64-apple-ios10.0 -Xlinker -dead_strip -Xlinker -compatibility_version -Xlinker 1 -o lib/lib_InternalSwiftSyntaxParser.dylib -install_name @rpath/lib_InternalSwiftSyntaxParser.dylib tools/swift/tools/libSwiftSyntaxParser/CMakeFiles/libSwiftSyntaxParser.dir/c-include-check.c.o tools/swift/tools/libSwiftSyntaxParser/CMakeFiles/libSwiftSyntaxParser.dir/libSwiftSyntaxParser.cpp.o lib/libswiftParse.a lib/libswiftSyntaxParse.a lib/libswiftParse.a lib/libswiftSyntaxParse.a lib/libswiftAST.a lib/libswiftBasic.a lib/libLLVMSupport.a -lm lib/libLLVMDemangle.a lib/libswiftDemangling.a ./lib/libclangBasic.a lib/libswiftSyntax.a && :
Undefined symbols for architecture arm64:
 "clang::MacroInfo::dump() const", referenced from:
 swift::ClangNode::dump() const in libswiftAST.a(Decl.cpp.o)
 "clang::Type::dump() const", referenced from:
 swift::UnexpectedClangTypeError::dump() in libswiftAST.a(ExtInfo.cpp.o)
 "clang::Decl::dump() const", referenced from:
 swift::ClangNode::dump() const in libswiftAST.a(Decl.cpp.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
ERROR: command terminated with a non-zero exit status 1, aborting

(You can find the full, gorey, exciting log at https://gist.github.com/tikimcfee/75c24cdce8cc352645da78da4b015daf)

There are a couple of things I noticed in the build log that have me questioning some kind of cache or local configuration. Specifically, lines that mention build tools from a different toolchain:

-- Found libtool - /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool
[...]
-- CMake (/usr/local/Cellar/cmake/3.18.2/bin/cmake) Version: 3.18.2
-- CMake Make Program (/usr/local/bin/ninja) Version: 1.10.1
-- C Compiler (/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc) Version: 12.0.0.12000032
-- C++ Compiler (/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++) Version: 12.0.0.12000032

I'm guessing I'm doing something wrong with the invoking of this script, but I've also tried a number of path hacks within the actual build script to try to point to a different toolchain or compiler - all of which are things I am completely unfamiliar with and am stabbing at in the dark with print debugging.

Issue Description:

It appears that TernarySyntax is not being parsed correctly. For instance, the following statement is parsed as a SequenceExprSyntax.

helper_func() == p1 ? true : false

However, the following is parsed correctly as a TernarySyntax.

p1 ? true : false

This problem is observed with SwiftSyntax 5.2

Issue Description:

Looks like depends on how the classification is checked, the result may be different. Let's consider this sample:

  public func testClassification1() {
    let source = """
public final class Foo {}
"""
    let tree = try! SyntaxParser.parse(source: source)
    for token in tree.tokens {
        for classification in token.classifications {
            print("\(token.text) - \(classification.kind)")
        }
    }
  }

output:

public - keyword
class - keyword

Missing:

final - attribute

Now let's try this sample:

    public func testClassification2() {
        let source = """
public final class Foo {}
"""
        let tree = try! SyntaxParser.parse(source: source)
        for classification in tree.classifications {
            print("\(classification.kind)")
        }
    }

output:

keyword
attribute
keyword

Issue Description:

This arose out of the discussion on swiftlang/swift#19347 which allows #sourceLocation directives to occur in collections. Rather than have Syntax accept #sourceLocation as an alternative for an array/dictionary element it was suggested perhaps Syntax should treat #sourceLocation as trivia going forward.
See swiftlang/swift#19347 (comment)

Issue Description:

SwiftSyntax is currently only supported on Darwin, we should make the necessary changes to make it available for linux as well. For example SwiftSyntax depends on Foundation, for the linux build it can depend on swift-corelibs-foundation.