[SR-14553] Previously unknown syntax is now parsed as AttributedTypeSyntax; not sure if expected about swift-syntax HOT 6 CLOSED

@swift-ci create

from swift-syntax.

@allevato How recently were you seeing the changes? With which toolchain were you still seeing the unknown syntax nodes? If it’s a toolchain from before October last year, this might be due to swiftlang/swift#34257

As far as I’m concerned, I’m also fine with the new parsing behavior and don’t see a reason to revert it.

from swift-syntax.

@allevato Ping

from swift-syntax.

Sigh, I apologize for the late reply. It looks like I'm not getting e-mail updates from Jira even though everything looks like it's configured correctly.

The first time I noticed the change in behavior was in the 2021-04-26 development snapshot. Unfortunately my workstation released its magic smoke a couple weeks ago so I can't check my history, but a colleague says that he has toolchains from 2021-01-17 and 2021-03-25 installed from work on other swift-format PRs, so I think the change affecting this unknown syntax must have occurred at least after 2021-01-17 or else we would have detected it during testing of swiftlang/swift-format#249

My suspicion was that it might have been related to some of the recent work around local property wrappers or property wrappers in function signatures, but I couldn't pinpoint anything specific.

FWIW, I also don't have any issues about the way that it's parsed now—I primarily wanted to make sure that this wasn't an unintended change. Since it sounds like you feel the same way, feel free to resolve this—thanks!

from swift-syntax.

There was some bug in the JIRA instance for a bit where none of us were receiving emails. It was fixed in the evening on May 19.

from swift-syntax.

Thanks for your feedback on this @allevato. I’ve closed this as “Won’t do”.

from swift-syntax.