[SR-9616] SwiftSyntax is not following trivia rule about swift-syntax HOT 4 CLOSED

I agree this is a bug.

https://github.com/apple/swift/blob/75033ed05a8f5ecf79e77b41dabd2c3863cbc9e5/lib/Parse/Lexer.cpp#L2560
I intentionally did this because, currently, we want such comments to be attached to the next token (i.e. possible start of a declaration on the next line).

https://bugs.swift.org/browse/SR-2373

Lexing trailing-comment as trailingTrivia makes parsing difficult as long as we keep current "trailing doc-comment" behavior. @nkcsgexi @akyrtzi What do you think?

from swift-syntax.

This example inamiy (JIRA User) gave here is an obvious bug since the comments are in different forms ("//" and "///"), so it's reasonable to assume they're
commenting different pieces.

If they are both "///", i have no strong opinion on whether we split them as trailing and leading trivia or combine them as leading trivia, because the lexer cannot
be always right in either way.

from swift-syntax.

Comment by Yasuhiro Inami (JIRA)

@nkcsgexi

If they are both "///", i have no strong opinion on whether we split them as trailing and leading trivia or combine them as leading trivia, because the lexer cannot
be always right in either way.

I think trailing and leading trivias should be separated in the above case too, and it's probably possible to distinguish them by checking if token exists in the same line or not.

If this can be done, it's exciting to see SR-2373 trailing-doc support can be implemented as well 🙂

from swift-syntax.

rdar://95639215

from swift-syntax.