[SR-10241] A way to get raw string without quotes from StringLiteralExprSyntax about swift-syntax HOT 8 CLOSED

CC: @nkcsgexi @akyrtzi

from swift-syntax.

Seems good idea to me. The benefit is you will be able to structurally distinguish what kind of quotes (multiline or single) were used, instead of searching the string literal text string in order to distinguish.

If we do this we should probably get rid of 'string_literal' token kind and use 'string_segment' token kind for the non-interpolation case as well.

from swift-syntax.

Comment by Yusuke Kita (JIRA)

Exactly.

Can I implement this fix? Seems quite interesting to dive into more details.

from swift-syntax.

Sure! Note that after changing the syntax definition file it would need a change on the C++ parser side.

from swift-syntax.

Comment by Yusuke Kita (JIRA)

I have a question about literal expression for this. I'm looking into Parser and wondering whether I should extend 'StringLiteralExpr' or create new one like 'NonInterpolatedStringLiteralExpr'. Which one do you think is better? @akyrtzi

I figured out how 'string_segment' is parsed in 'parseExprStringLiteral' func, but I haven't had conclusion for the interface yet.

from swift-syntax.

I think we should generalize StringLiteralExpr.
Basically, syntax change would be:

• Remove StringLiteralExpr

• Rename StringInterpolationExpr to StringLiteralExpr

• Rename StringInterpolationSegments to StringLiteralSegment

like:

    Node('StringLiteralExpr', kind='Expr',
         children=[
             Child('OpenQuote', kind='Token',
                   token_choices=[
                       'StringQuoteToken',
                       'MultilineStringQuoteToken',
                   ]),
             Child('Segments', kind='StringLiteralSegments'),
             Child('CloseQuote', kind='Token',
                   token_choices=[
                       'StringQuoteToken',
                       'MultilineStringQuoteToken',
                   ]),
         ]),

We can easily check whether it's interpolated or not by (segments.count == 1 && segments[0] is StringSegmentToken)

from swift-syntax.

I'm not a big fan of adding `NonInterpolatedStringLiteralExpr` either. The reason is users are likely to have two overrides for either visit or rewrite functions to handle all string literal cases. We should strive to help users reduce code duplication. However, feel free to add a convenient function to `StringLIteralExpr` indicating whether there are interpolations in the node.

from swift-syntax.

Comment by Yusuke Kita (JIRA)

What Rintaro suggested makes sense to me. I'll go with `StringLiteralExpr` for the case. Thanks for your feedbacks!

from swift-syntax.