Giter Club home page Giter Club logo

Comments (3)

akyrtzi avatar akyrtzi commented on September 15, 2024

@swift-ci

from swift-syntax.

beccadax avatar beccadax commented on September 15, 2024

@swift-ci create

from swift-syntax.

ahoppen avatar ahoppen commented on September 15, 2024

I was able to reproduce this to some degree with the following test:

import SwiftSyntax
import SwiftParser
import Foundation

let str = try! String(contentsOfFile: "/Users/alex/Downloads/SR-12972/SyntaxBuilders.swift")

let tree = try! Parser.parse(source: str)

// Warm up caches
for _ in 0..<10 {
  _ = SourceLocationConverter(file: "", source: str)
}
for _ in 0..<10 {
  _ = SourceLocationConverter(file: "", tree: tree)
}

do {
  let start = Date()
  for _ in 0..<100 {
    _ = SourceLocationConverter(file: "", source: str)
  }
  print("String based initializer took: \(Date().timeIntervalSince(start)/100 * 1000) ms")
}

do {
  let start = Date()
  for _ in 0..<100 {
    _ = SourceLocationConverter(file: "", tree: tree)
  }
  print("Tree-based initializer took: \(Date().timeIntervalSince(start)/100 * 1000) ms")
}

The output was as follows:

String based initializer took: 11.692179441452026 ms
Tree-based initializer took: 35.53478002548218 ms

This matches my expectations because the tree needs to first be converted into a source string before SourceLocationConverter can build up its line table. I suspect the original discrepancy was larger because the reporter was using a debug build of SwiftSyntax.

I’m closing this as correct behavior. If the performance of SourceLocationConverter is a bottleneck for someone in release builds, we can re-consider creating an optimized initializer for SourceLocationConverter that doesn’t convert the tree into a string first.

from swift-syntax.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.