Comments (3)
from swift-syntax.
@swift-ci create
from swift-syntax.
I was able to reproduce this to some degree with the following test:
import SwiftSyntax
import SwiftParser
import Foundation
let str = try! String(contentsOfFile: "/Users/alex/Downloads/SR-12972/SyntaxBuilders.swift")
let tree = try! Parser.parse(source: str)
// Warm up caches
for _ in 0..<10 {
_ = SourceLocationConverter(file: "", source: str)
}
for _ in 0..<10 {
_ = SourceLocationConverter(file: "", tree: tree)
}
do {
let start = Date()
for _ in 0..<100 {
_ = SourceLocationConverter(file: "", source: str)
}
print("String based initializer took: \(Date().timeIntervalSince(start)/100 * 1000) ms")
}
do {
let start = Date()
for _ in 0..<100 {
_ = SourceLocationConverter(file: "", tree: tree)
}
print("Tree-based initializer took: \(Date().timeIntervalSince(start)/100 * 1000) ms")
}
The output was as follows:
String based initializer took: 11.692179441452026 ms
Tree-based initializer took: 35.53478002548218 ms
This matches my expectations because the tree needs to first be converted into a source string before SourceLocationConverter
can build up its line table. I suspect the original discrepancy was larger because the reporter was using a debug build of SwiftSyntax.
I’m closing this as correct behavior. If the performance of SourceLocationConverter
is a bottleneck for someone in release builds, we can re-consider creating an optimized initializer for SourceLocationConverter
that doesn’t convert the tree into a string first.
from swift-syntax.
Related Issues (20)
- Setting of Swift_MODULE_DIRECTORY (and probably other directories) inappropriate. HOT 3
- trimming trivia nodes corrupts source ranges HOT 1
- Add GitHub Release (as a pre-release) for pre-release tags HOT 3
- Adopt Swift-Testing in test utils such as `SwiftSyntaxMacrosTestSupport` HOT 2
- `assertMacroExpansion` passes 0 protocols to `ExtensionMacro`. HOT 4
- Improperly escaped backslash in fix-it message HOT 1
- New 600.0.0 prerelease HOT 4
- FixItApplier crash when generating diagnostics for whole tree but applying them to a subtree HOT 11
- Further generalize parse diagnostics functions HOT 1
- Body Macro formatted despite formatMode disabled HOT 2
- Improve diagnostics for C-style parameter declaration with structural type HOT 1
- [Parser] Misparsed function parameter with keyword argument '_const' HOT 1
- `600.0.0-prerelease-2024-07-24` fails to build on macOS 12 with Swift 5.10 HOT 12
- swift-syntax doesn't give negative integer literals special treatment while the Swift compiler does. HOT 2
- Source location retrieving doesn't work in body macro expansion assertion HOT 1
- KeyPath `.self` cannot be resolved in earlier Swift versions HOT 1
- Detect recursive attached macro expansion HOT 1
- Macro protocols lack `async` from `expansion` function requirements despite proposals stating they should have it HOT 17
- DeclModifierListSyntax adds redundant space after private modifier HOT 2
- Multiple SPM frameworks with macros fail Xcode app project build HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-syntax.