Giter Club home page Giter Club logo

lrorpilla / jidoujisho Goto Github PK

View Code? Open in Web Editor NEW
774.0 19.0 53.0 313.79 MB

A full-featured immersion language learning suite for mobile.

License: GNU General Public License v3.0

Dart 76.19% Swift 8.26% Objective-C 0.05% Ruby 0.14% Java 11.54% CSS 0.06% HTML 2.97% JavaScript 0.23% Shell 0.03% Python 0.02% CMake 0.16% C++ 0.34% C 0.01%
japanese-language japanese japanese-study japanese-dictionary android-application flutter dart ankidroid japanese-language-learners android

jidoujisho's Issues

Option to autopause after a subtitle

I personally enjoy reading the subtitles. When I watch content in MPV, I use a script to autopause after every subtitle, to listen the sentence and then repeat what it said, after that, un-pause the video and do it again and again.
It would be great to have that feature in jidoujisho too.

Thanks!

Feature request: Showing local file name in the player

Great app that's close to perfection. I mainly use the app for playing local videos and since file names are sometimes too long I can't see the full title of the episode from the file picker. This results in me opening an episode to realize it's the wrong one.
It would be great if I could see the file name inside the player or maybe change the view to list in the file picker (don't no if you can control it).

Crash when selecting a subtitle file

I have an anime episode and subtitles for that episode as an .ass file. When I select "Load External Subtitles" from the player menu and select that .ass file, the player crashes every time.

I seem to be able to work around this crash if I first select "no subtitles" and then select the .ass file.

I suspect this may have something to do with the fact that the video file has an embedded English subtitle that is selected by default.

I'm using the latest version, 0.13.1 beta.

I realize this is not a lot to go by, so let me know what I could provide to help investigating this.

Subtitle remains visible until the next one is displayed

In some cases, a subtitle line lasts for a couple of seconds, say, and then it should end according to the transcript, followed by a break of some time before the next subtitle line.

So

  • sub1 should be shown for 5s
  • there should be no subtitle visible for 5s
  • a new subtitle line should be shown

In my case the second step is skipped, meaning the first line is not hidden.

Exported cards' images and audio not synced in Ankidroid

Here is an issue l just ran into.

How to reproduce:

  • jidoujisho 0.13.0-beta
  • latest ankidroid (2.14.6)
  • desktop anki Version 2.1.22 (0ecc189a)

Steps:

  • in jidoujisho, open a video and "export the current context to anki" to create a card
  • in ankidroid, verify that the created card can display its image and play its audio
  • in ankidroid, sync changes
  • in desktop anki, likewise sync so the new card becomes available
  • in desktop anki, Browse to see the card
  • press Ctrl+L to verify that the card is missing its image, and can't play its audio

A workaround is to run "Check Media" in ankidroid before syncing. After this, the image and audio are synced just fine.

Be able to select the screenshot when exporting multiple subtitles in a same card.

When I export multiple subtitles in a same card, the screenshot is taken from the first subtitle. May be convenient to be able to select the screenshot based on one of the subtitles that I selected to be export on the same card just touching the subtitle, or just be able to take a screenshot freely and put it into the card.

Thanks!

[Feature Request] A way of dealing with furigana in subtitles.

I've found a problem with subs that have furigana, mainly those you find on Netflix subs.
Screenshot_2021-07-11-20-15-59-816_com lrorpilla jidoujisho
Screenshot_2021-07-11-20-16-37-395_com lrorpilla jidoujisho
Screenshot_2021-07-11-20-22-36-690_com lrorpilla jidoujisho
Screenshot_2021-07-11-20-22-44-318_com lrorpilla jidoujisho
The word can't be parsed at all because there's furigana on almost every kanji. My request is:

  • Skip furigana when parsing;
  • Option to turn furigana on and off (because it might be helpful for some users);
  • Automatically remove furigana when a cards is created.

You can find the subtitle in the screenshots here. But it's pretty common to have furigana in subs — I personally find them annoying.
I'm not aware of other patterns to indicate furigana, so far I've only encountered the one present in the screenshots. There might be more patterns.

Support for kanji dictionary.

As of now if I import kanji dictionary the app treats it as word dictionary and cant read it. Is there a way to make kanji dictionary work? Speaking of Kanji dictionary frequency lists are also treated as dictionaries.

Pause video when bluetooth headphone pause button is pressed

My bluetooth headphones have a pause+resume button and two volume controls. The volume controls work right now, but the pause button does nothing.

If I use the same headphones with Netflix or YouTube (vanced), the video is paused and resumed like one would expect.

[Feature Request] Forvo audio and NHK Pitch Accent audios

First of all, I'd like to tell you that I've done a factory reset on my phone and that I'm able to open local videos ever since. Thanks, again, for all the time you invested on my own personal issue.

I've been thinking about this request for a long time — you too might've thought about it, I suppose. My feature request is: automatically download and export Forvo audios to Anki and support for NHK Pitch Accent audios that Migaku Japanese uses. I believe that such feature would improve everybody's learning journey with Anki, plus it's a feature to make your project better.

(I've loving the manga feature. I was about to start reading mangas, and you made a tool for it)

[Feature Request] Custom dictionary support

Current method for monolingual dictionary seem make http calls for each look up.

Which is:

  • Extremely slow
  • Limits to one dictionary (missing quite a lot of entries)
  • Very dependent on the way this website index the words

Recursive lookups for monolingual definitions

Some definitions in monolingual dictionaries point to other definitions and aren't that useful in their own. Here is an example.

もご-もご [1] (副)スル
(1)「もぐもぐ」に同じ。「―(と)かむ」
(2)うごめくさま。もぞもぞ。「着ぶくれて―する」

Would be great if I could click on もぐもぐ and see that definition.

2 Ideas - A Reading Mode, and Double-Tap to Pause/Unpause

Not sure if these are possible, but I feel like a reading mode would be pretty handy for people who want to learn to read.
Have it pause at the beginning of the line.

The pause button that appears when paused and works when the middle of the screen is tapped is ok, but I feel like setting a Double-Tap to pause would be much more useful, especially on tablets.
Not sure if it's doable with the current media player that is incorporated.

.null files

Files generated by Jidoujisho were supposed to be .null files or is it a bug?
Screenshot_2021-07-06-10-30-07-637_com ichi2 anki
Screenshot_2021-07-06-10-30-13-252_com ichi2 anki
Screenshot_2021-07-06-10-30-21-815_com ichi2 anki

Doesn't load external .srt by default and can't locate any to load manually 0.3.2/0.4.2(non android 11 version)

Samsung Galaxy S7 running Android 8

When selecting a video through Play Local Media you can see both the video and .srt files, but when clicking Load External Subtitles no files can be located, there's no dropdown arrow to change location away from recent, and the "open from" menu doesn't show the phone's local storage.

Play Local Media

ss1
ss2

Load External Subtitles

ss3
ss4

0.3.1 loads .srt files by default but doesn't have the Load External Subtitles option so couldn't test that.

[Feature Request] External Video Player For Plex

I like streaming video from my pc to my phone via plex, and the app gives the option to watch the video with an external app. I would love to use jidoujisho for that so I can do lookups on subs while I watch, but the app doesn't appear on the list of external apps.

I believe that the external players are just all of the apps that android recognizes as video players. For example, if I go to change android's default video player, jidoujisho is not on the list.

Better subscriptions import

Would be convenient to be able to import the subscriptions directly from youtube, newpipe, and other similar youtube-based apps.

Thanks!

2 Bugs/Improvements - Subtitle won't refresh when changing tracks / Load External Subtitle By Default?

Hello,

One issue I'm having is on a show with multiple subtitle tracks, it won't actually change to the selected subtitle track. It loads the first subtitle in alphabetical order that's embedded on a .mkv, so Arabic in my example. I try to change it to Chinese Simplified, and after I select the new subtitle, it won't reload the subtitles for the video, so it's stuck just displaying Arabic.

My second thing is a suggestion: Use a fuzzysearch to open related subtitle files and add them into the subtitle list - this would help dealing with lots of shows with external subtitles.
example:
Are You OK Episode 01 iQiyi 1920x1080.mp4
Are You OK Episode 01 iQiyi 1920x1080.en.srt
Are You OK Episode 01 iQiyi 1920x1080.zh-CN.srt

This is the common naming convention, where all subtitles include the full filename, and append a language code after a period (.)
I think this is related to the File Picker, but I'm not sure how to override that on Android...

I hope to see these fixes or a clarification with this app, if no one else is experiencing the issue.

Vlad

How about Netflix?

Hello. It is a really very interesting app. I think it has a lot of potential. By the way, can it be applied to Netflix?

Don't confirm ending playback when video has ended

I figured I'd open some issues that seem like low hanging fruit.

When the video has ended and I navigate back to leave it, I'm still asked if I want to leave.

Kind of makes sense but idk if it would be nice to just leave without asking in this case.

Sub not displaying properly

I was watching 史上最強の弟子ケンイチ and noticed that some lines were cut due to the way the sub file is formatted.
Here's an example of the error: https://streamable.com/l8epm5
Here's the lines:
Dialogue: 0,0:02:07.12,0:02:09.37,a,,0,0,0,,(田中(たなか))\N前から\N気になってたんだけど Dialogue: 0,0:02:09.58,0:02:10.38,a,,0,0,0,,(島山(しまやま))\Nん?

Dialogue: 0,0:02:25.60,0:02:29.52,a,,0,0,0,,(田中)\Nでも 風林寺ってさ\Nどっか近寄りがたいよな Dialogue: 0,0:02:29.64,0:02:32.19,a,,0,0,0,,住んでる世界が違うっていうか…

Couple of feature idea.

I think the following features will help advanced learners.

Show subtitle on pause.
Keeps the subtitle hidden and only shows it when the video is paused.

Show subtitle on repeat.
Keeps the subtitle hidden and shows it when the part of the video is repeated.

Thanks a lot for such a great app 😀.

Filters option

May be good to have a filters option while searching content.
Some examples are:
-Close captioning available videos
-Videos
-Channels
-Songs
-Newer/Older
And others like those

Thanks for your work!

Can't select Japanese audio in dual-audio files

Just as the title says, I have a local dual-audio file that plays in English only although it has Japanese. I can't select the option for Japanese although it's already there.
This how it looks
Screenshot_20210724_215637_com lrorpilla jidoujisho

Anki cards are not being created in ankidroid.

I did edit the note type slightly so migaku support would appear but I don't think that it would stop the exportation of cards, other than that all the setting were done correctly. I made sure the cards were being sent to the correct deck multiple times and even rebooted my phone but the cards were not present in ankidroid. The app also crashed a few times today for no reason.

Exporting to Ankidroid issue

When I try to export to ankidroid, it exports the current snapshot but no audio. It only happens with one anime in specific. It works with the other ones. How can I fix this issue?

[Feature Request] Portrait orientation in Player mode

As the title says, currently the app switches to landscape orientation when playing a video and it's not possible to change orientation. It would be useful to use it in portrait so that when exporting cards to Anki there is enough vertical space to se all the fields.

Configure subtitle font size

I'm using a Galaxy Tab S6 Lite (2000 x 1200px) and I find the size of the subtitles too small to read comfortably.

It seems to be hardcoded to 16px atm, would it be possible to make it configurable?

Screenshot_20210625-131429

Optimization for older devices

I tested the app in 3 devices, one with Android 7, and two with Android 9. In the Android 9 devices, it runs perfectly, but in the older Android 7 device it has some performance issues while loading or/and playing videos. Also, when I search a definition on the fly while watching, it takes much more time to auto-pause the video, and usually it shows the following subtitles before it pauses (in some cases, 2 or 3 subtitles are shown before).

Thanks!

Error when installing

When I try to install the app I get this error: (INSTALL_PARSE_FAILED_NO_CERTIFICATES)

[Feature Request] White Mode

I really would love to use the reader and viewer aspects of this app with my ink reader but since it's only available in black, it's currently impossible to use. Would it be possible to have some sort of theme or light mode in the future by any chance?

Either way the app is amazing!

Add "share to/open with jidoujisho"

In YouTube, the search is actually pretty good, so I like to use it for most videos. But occasionally something comes up with subs and I'd like to watch that in jidoujisho just because it's convenient.

It would be nice to have an option to open the current youtube video in jidoujisho for this reason.

Bug when I rotate the phone while video is loading.

When the video is loading and I rotate the phone without having the auto-rotation option activated, for some reason the video player detects it and this bug happens. The audio is good, but the image stills the same for the rest of the video.
Screenshot_20210424-034636

Idea for Rudimentary Support of Chinese?

Greetings,

I know that currently, there isn't a parser setup for Chinese.
Is there any way to create a rudimentary way to do Chinese parsing with tap, since we already have some Chinese Dictionaries for Yomichan that work?
Currently, I don't have huge issues using Yomichan to read in Chinese, but with the tapping on the app, it tries to lookup the entire sentence when I tap over certain words.

Is there a way you could create a crude temporary solution in the options, where it just does a lookup starting at the first character you tap, and looks up the word in the dictionaries?

Here is an example sentence from this show Hilda:
我们就要辨识并采集到十种本地植物的样本
If I do a search for ANY of the words starting halfway through the sentence with the hanzi 十, the dictionary will try and do a lookup of the entire phrase. I can't lookup things like "植物" even though this is in the Japanese-English and Chinese-English dictionaries I have.
O6pB23t

I'm not sure if this is doable to make it work as least as well as Yomichan does.

Video of Yomichan on the sentence:
https://user-images.githubusercontent.com/9376306/129407452-2a174b5f-ca78-4b84-ab96-e20995fc8be6.mp4

Thanks~

[Feature Request] Resize/movable dictionary overlay for reader

First off, thank you for such an amazing app! I was looking for alternatives to Typhon and stumbled upon this gem :')

So far, the dictionary has been relatively easy to use, but I find that it does get in the way when looking up the definition/pronunciation of any kanji near the top of the screen. Being able to drag it around or resize the overlay would make it feel less intrusive and easier to use. Also, while less important, highlighting the current word/phrase being looked up would also be great (similar to Typhon).

Mouse support

When I use a mouse on my tablet I can highlight text and everything but I am unable to scan the text to get dictionary results. Is there a way to set a hotkey or something I yomichan so I can use the middle mouse button to scan? Thank you for your hard work on this amazing project.

Dictionary term search should be smarter

Currently if one searches for 原色擬似概念 on a local dictionary, it report that it has no results, even tho 原色 exists in the dictionary.

My suggestion is to make the search more lenient so that it supports words shorter than the highlighted ones.

Local videos don't load anymore (only on my phone?)

I've recently flashed LineageOS on phone — a Xiaomi Redmi Note 5. Local videos stopped working since version 0.25.8 — 0.25.7 is working well. I've tried scopedstorage versions, it didn't work as well. Since no one has reported this problem, it might have something to do with LineageOS?

Fr: pause playback when looking up a definition

Typically when I look up a new word, I need some time to read the definition and understand the word in the context.

I think it would be a good idea to pause automatically when a lookup is done because of this.

Please consider this, and thanks for all your work!

Reading only online?

Do i need to have internet connection to read a local book? Are there third party readers that can be used along side jidoujisho?
The mining process is pretty neat in the app and I would like to use it for reading as well.

A continuation to dual adio problem.

This is a problem that arised after the recent update that was intended to fix a problem where selecting Japanese audio was not possible.
A new problem arised. If I open the a video file that has dual audio the app crashes and exit. If I try to open the video from the file manger it works fine.
This is a link for a video that has the problem.
https://ouo.press/Tz0aKr
Note: other files that are mono-audio work just fine anywhere.
Take your time to fix it. It's a bit of a pain but I can still watch.
Thi

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.