Giter Club home page Giter Club logo

Comments (4)

mikavilpas avatar mikavilpas commented on May 24, 2024

Just verified this doesn't make exporting that sub line any longer (audio wise) than what the transcript says. So maybe this is not that bad.

from jidoujisho.

lrorpilla avatar lrorpilla commented on May 24, 2024

I consider this a feature and design choice, not a bug. Yes, there are instances where there may be something like an opening playing and the subtitle will be left playing, but this solves many nuances with subtitles being too hard to catch or the very slightest bits of text too hard to rewind for.

from jidoujisho.

lrorpilla avatar lrorpilla commented on May 24, 2024

Found an elegant solution for this that should hide the subtitle while keeping it as the current context (if the subtitle end time is past, the widget hides -- internally, the previous subtitle is still kept so export and seek backs should still be the subtitle, just hidden from view). Should be included in the next version.

from jidoujisho.

lrorpilla avatar lrorpilla commented on May 24, 2024

I have implemented this feature in 0.13.4.

See the relevant line in the release notes:

  • Subtitle widget will now be hidden from view if the current player position is not within a 100ms range of the last subtitle viewed

With that, I am closing this issue.

from jidoujisho.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.