Giter Club home page Giter Club logo

Comments (6)

mikavilpas avatar mikavilpas commented on May 24, 2024

It seems the workaround I described is not that reliable... A better workaround seems to be to start playing a different file and then switch back to the first file.

Looks like it tries to load the subs that have the same name dna the extension but they are empty (the transcript is empty) but when I manually load the subs, they work fine.

This is a bit messy, maybe multiple issues occurring at the same time.

from jidoujisho.

lrorpilla avatar lrorpilla commented on May 24, 2024

I have a guess at the cause but to confirm the issue, please attach the subtitle file so I can have a look at it.

Cheers.

from jidoujisho.

mikavilpas avatar mikavilpas commented on May 24, 2024

Here is one of the files I have had problems with,

[Doki] Usagi Drop - 02 (1920x1080 Hi10P BD FLAC) [94E10265].ass.zip

from jidoujisho.

lrorpilla avatar lrorpilla commented on May 24, 2024

I have implemented a fix for this in 0.13.5.

The issue was that the code for loading the default subtitles assumed that the format was in SRT. Therefore, any ASS files could not be loaded by default -- Conversely, when importing them, the file was converted appropriately.

I also fixed an issue with subtitles where timestamps may show in the transcript as text as artifacts.

See the relevant lines in the release notes:

  • Fixed an issue with default ASS/SRT subtitles with the same filename as the video file were loaded as a raw string SRT
  • Fixed an SRT parsing issue which showed timestamps in the transcript where the line after the timestamp showed up as blank

I am closing this issue. If the problem persists, please do report and I will reopen this issue.

from jidoujisho.

mikavilpas avatar mikavilpas commented on May 24, 2024

Unfortunately this is still occurring for me.

Before the new version, I would see the embedded English ass subs as well as the Japanese ass subs that are in a file with the same name as the video.

After the fix, I only see the English subs in the subtitle selection menu.

In both cases, loading the Japanese subs as an external sub will crash or close the application.

from jidoujisho.

lrorpilla avatar lrorpilla commented on May 24, 2024

After investigations, I believe that this issue is an extremely low-end device-specific issue. I can't do much about it except to suggest sourcing the video and subtitles elsewhere -- the video and subtitle in question appear to load in multiple devices and emulators I have tested with.

If ever more information arises, I may look over this again but for now I am closing this issue.

from jidoujisho.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.