Comments (14)
All right, it downloads now without errors! If @murt can confirm that too, that would be great.
from gdcef.
@murt Thank to you I just realized that I forgot to copy prerequisite section from the original project:
https://github.com/stigmee/install#step-2-install-python3-packages
from gdcef.
@murt Ok I fixed the doc. Please re-open the ticket if this documentation is still unclear.
from gdcef.
Installed the recommended package "wget" instead of "python3-wget" as stated in the README, but I'm still getting this error while running build.py:
urllib.error.HTTPError: HTTP Error 404: Not Found
File link downloads fine through the webbrowser.
I'm going to look at the version number parser in build.py
because it's quite sophisticated for downloading a single file.
from gdcef.
Turns out that URL percent encoding is causing the issue. I'm going to open a PR with the fix, and while I am at it, I'll update the CEF version, too.
from gdcef.
Installed the recommended package "wget" instead of "python3-wget" as stated in the README, but I'm still getting this error while running build.py:
Hi @raphipod install python3-wget ! Do not install wget :) I'm a Python noob: is wget more official than python3-wget ? Except you and @murt people on my team did not get issues with URL encoding with python3-wget
from gdcef.
No worries. It seems that python3-wget is "just" a rewrite for Python 3.
Concerning the URL encoding issues, I really don't know why it fails at my end
from gdcef.
@raphipod I tried quickly: I uninstalled python3-wget and installed back wget and the +
seems working but not the %2B
(by the way, when you copy the URL from your browser you have %2B
). At the opposite, from my memory, python3-wget does not like +
but prefer %2B
, and both uses import wget
and requirements.txt generates wget for python3-wget :( :(
from gdcef.
Concerning the URL encoding issues, I really don't know why it fails at my end
I think this is a mix up between python3_wget and wget while using import wget
from gdcef.
Yeah, we should use python3-wget, already corrected that in #2
from gdcef.
@raphipod @murt I have radically changed of python package for downloading :) no more wget ! I added the requirement file and updated README. I also updated CEF version. I hardly checked. Tell me if this is ok for you. If ok @raphipod you can cancel your PR
from gdcef.
Sure!
from gdcef.
I just noticed that you've commented out the colon in line 346, it exits.
from gdcef.
I just noticed that you've commented out the colon in line 346, it exits.
:( I've git push force. You can do git pull --rebase origin master
from gdcef.
Related Issues (20)
- License HOT 4
- Windows demo crashing immediately on play HOT 6
- Locale is in French
- Looking for MacOs and/or Godot and/or CEF developer HOT 1
- User-configutable resource directory HOT 9
- Add CI for Windows HOT 2
- New tab links open a new OS window HOT 4
- Merging the last std::cout with GDCEF_ERROR and godot::Godot::print HOT 1
- Add example of JS injection in demo
- Add Godot smoke test HOT 1
- Upload compiled library artifacts as part of CI HOT 1
- Windows CEF crashing on play HOT 5
- Widevine support? HOT 2
- FileNotFoundError on compile HOT 6
- Please add support for Godot-4.0 HOT 9
- Build Error for GDCEF HOT 11
- API: Add save the page as html HOT 1
- Missing information
- Wrong folder organisation HOT 5
- No SConstruct file found HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gdcef.