User-configutable resource directory about gdcef HOT 9 CLOSED

@daniel-sanche nice work :) I'll test it. For the few I reviewed, your code seems good.

from gdcef.

I've merged them. I do not have time right now:

• for non public member variables I use m_
• Merging the last std::cout with GDCEF_ERROR and godot::Godot::print.
• Add in the documentation all the CEF setting/dictionary entries and add them explicitly in the demos.
• Rename the CEFHello demo to CEF2D.
• Add mouse and keyboard event to the active area in CEFHello demo.
• Add example of JS injection in demo. As a non JS-dev I do not really understand why people want to execute JS

from gdcef.

@daniel-sanche Finally waiting my wife getting ready, I added time to fix several points on my list. I'll commit them to night or tomorrow.

from gdcef.

Sounds good, let me know if you want me to take a look at anything on the list. I'd add:

• Add documentation for configuration dictionary fields

from gdcef.

Add example of JS injection in demo. As a non JS-dev I do not really understand why people want to execute JS

My motivation was to use it to inject tokens to avoid a sign-in page. I don't do a lot of JS either, so I'm not sure what a good demo scenario would look like

from gdcef.

@daniel-sanche

• [DONE] for non public member variables I use m_
• Merging the last std::cout with GDCEF_ERROR and godot::Godot::print.
• [DONE] Add in the documentation all the CEF setting/dictionary entries and add them explicitly in the demos.
• [DONE] Rename the CEFHello demo to CEF2D.
• [DONE] Add mouse and keyboard event to the active area in CEFHello demo.
• Add example of JS injection in demo. As a non JS-dev I do not really understand why people want to execute JS

Also:

• I fixed some settings that the user shall not modify.
• You can add an example of JS in demos if you wish.
• You can help fixing my poor English sentences ;)
• I does not really like replacing _init by initialize and passing non default arguments (default dictionary will be {}) and CEF sub process shall be known and canonical and no more exportable. In my previous code, the path to it was directly computed, letting no risk to the user to give bad path. CEF does not pardon any error if you do not want your OS does infinite fork of processes and kill your OS.

from gdcef.

Now initialize() only takes Dictionary. Ideally would be nice to use back _init() like done before and define global CEF config with the dictionary.

from gdcef.

Cool, looks great! Feel free to close this issue if you think it's all done

from gdcef.

Not all but mostly. let open other tickets if needed

from gdcef.