Giter Club home page Giter Club logo

ruby-hello-world's Introduction

ruby-hello-world's People

Contributors

bparees avatar brenton avatar coverprice avatar danmcp avatar dulek avatar jackorp avatar jhadvig avatar junaruga avatar maria avatar mfojtik avatar mnagy avatar php-coder avatar pvalena avatar sappy000 avatar thesteve0 avatar thoraxe avatar voxik avatar vrutkovs avatar wanghaoran1988 avatar wewang58 avatar yselkowitz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ruby-hello-world's Issues

Hello-world

G- - - [ ] #nk_mir@list travel . Www.momondo.ru/discover/chem-- [ ] zaniatsia-na-karantive

Don't delete the beta2 branch

...until the beta is over.

This is just a reminder. We needed a stable point in time since this example is used for the training materials.

cut tags based on ruby version for openshift/origi

@bparees - @adambkaplan had a good idea to help avoid the recent openshift/origin e2e breakage when @vrutkovs did his 2.5 to 2.7 migration

cut a tag like ruby-2.7, and then we can change the openshift/origin e2e's that pull in this repo to use that ref vs. the master branch ref

then next time we could bump the ruby version here first, cut a new tag, and then update openshift/origin, where in the interim existing job runs would still point to the old tag

WDYT ?

openshift-origin

$ docker run -d --name "openshift-origin" --net=host --privileged
-v /var/run/docker.sock:/var/run/docker.sock
openshift/origin start

database is not created by default

Tried for the first time origin and running the command advised after issuing a new-project to launch ruby-hello-world :

oc new-app centos/ruby-22-centos7~https://github.com/openshift/ruby-hello-world.git

and it does not seem to create a database with it (I was under impression it did when trying with OSE). It would be nice to document this in the README how to add a database to the application, for example I this :

MYSQL_PASSWORD=moto
MYSQL_USER=hello
MYSQL_DATABASE=hellomoto

oc new-app centos/mysql-56-centos7:latest -e MYSQL_PASSWORD=${MYSQL_PASSWORD} -e MYSQL_USER=${MYSQL_USER} -e MYSQL_DATABASE=${MYSQL_DATABASE} --name=mysql
oc new-app centos/ruby-22-centos7~https://github.com/openshift/ruby-hello-world.git -e DATABASE_SERVICE_HOST=mysql \
    -e MYSQL_USER=${MYSQL_USER} -e MYSQL_PASSWORD=${MYSQL_PASSWORD} -e  MYSQL_DATABASE=${MYSQL_DATABASE}

Hello world

("Hello world")=first code ~jaybird*
End
End

New branch needed in order to fix a build test for ARM

The config branch is currently used by the [sig-builds][Feature:Builds][Slow] starting a build using CLI start-build test context Trigger builds with branch refs matching directories on master branch Should checkout the config branch, not config directory test. That branch is way behind master, and in order to fix this test for ARM which only has modern versions of ruby and only for UBI8, it would have to be significantly updated. However, that would break the test, which uses the commit message to verify the branch checked out.

Therefore, unless I'm missing something, in order to fix this test, there are two options:

  1. Create a new branch here off of master whose name matches a different directory in the repo, e.g. 'test'. Then someone creates a PR to distinguish this branch from master (e.g. remove the README). Finally, update that test in origin in master/4.9+ with s/config/test/g and the new commit message.
  2. Merge the changes into the current config branch, then update the commit message in the test in origin, and backport that to all applicable stable branches.

Option 1 seems cleaner, but afaik I can't make a PR to create a new branch, so I'll need your help for that in addition to the subsequent reviews. Please let me know how you want to proceed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.