New branch needed in order to fix a build test for ARM about ruby-hello-world HOT 13 CLOSED

/cc @gabemontero

from ruby-hello-world.

@yselkowitz you just want a new branch that's up to date with master but has the README removed? i can do that if so.

from ruby-hello-world.

Basically, but for the purposes of the test in question, the branch name has to match a directory name in the repo (e.g. 'test') and its tip has to have a unique commit message.

from ruby-hello-world.

here you go:
https://github.com/openshift/ruby-hello-world/tree/test

i removed README.md in that branch.

from ruby-hello-world.

though now i'm wondering if we couldn't have just rebased the existing config branch?

from ruby-hello-world.

That would be option 2 above, but would have resulted in a change to the commit message at the tip of the branch, which would cause the test in question to fail on all OpenShift versions until we backported a fix through all the still-supported branches in origin.

from ruby-hello-world.

That would be option 2 above, but would have resulted in a change to the commit message at the tip of the branch

pretty sure i should be able to make it happen w/o changing the commit message.

from ruby-hello-world.

Can you rebase merge commits in git? Usually when you rebase, merge commits are dropped.

from ruby-hello-world.

Can you rebase merge commits in git? Usually when you rebase, merge commits are dropped.

i can just push directly to the openshift:config branch. Since the test just cares about the commit text, i can just make the text match.

from ruby-hello-world.

e.g. i just created this one:
https://github.com/openshift/ruby-hello-world/tree/newconfig

i should be able to do the same to the existing config branch

from ruby-hello-world.

I guess there was a third option after all. If you're comfortable with that approach, then by all means, and you can drop the 'test' branch. Thanks!

from ruby-hello-world.

done:
https://github.com/openshift/ruby-hello-world/tree/config

from ruby-hello-world.

The test in question still passes in CI, so we should be set. Thanks!

from ruby-hello-world.