Giter Club home page Giter Club logo

Comments (10)

bparees avatar bparees commented on September 26, 2024

honestly i'd rather just fork this repo elsewhere and move the tests to use the fork. One of the main problems w/ this repo is that it is both a public example and required for certain tests. Once upon a time we considered that a benefit (we ensure we don't break our public facing example) but now i'm more inclined to have a clear distinction/indication that "this repo is used by tests, don't change it unless you understand the tests that consume it"

from ruby-hello-world.

bparees avatar bparees commented on September 26, 2024

(note that either approach requires a bunch of test updates being backported through all the release branches)

from ruby-hello-world.

gabemontero avatar gabemontero commented on September 26, 2024

(note that either approach requires a bunch of test updates being backported through all the release branches)

yep understood, but those existing tests would not be broken in the interim

from ruby-hello-world.

gabemontero avatar gabemontero commented on September 26, 2024

honestly i'd rather just fork this repo elsewhere and move the tests to use the fork. One of the main problems w/ this repo is that it is both a public example and required for certain tests. Once upon a time we considered that a benefit (we ensure we don't break our public facing example) but now i'm more inclined to have a clear distinction/indication that "this repo is used by tests, don't change it unless you understand the tests that consume it"

sure ... the question is where exactly, in particular which org vs. github.com/openshift ?

create a new one?

github.com/redhat-developer?

we do not want to do somebody's personal repo, right?

from ruby-hello-world.

bparees avatar bparees commented on September 26, 2024

the question is where exactly, in particular which org vs. github.com/openshift ?

might as well be openshift org.

we do not want to do somebody's personal repo, right?

right

If tagging is easier, i'm fine with that as the path of least resistance. Note that you could also just use an explicit commit rather than a branch or tag, if you go that path. And then just update the commit ref as needed.

from ruby-hello-world.

gabemontero avatar gabemontero commented on September 26, 2024

the question is where exactly, in particular which org vs. github.com/openshift ?

might as well be openshift org.

we do not want to do somebody's personal repo, right?

right

If tagging is easier, i'm fine with that as the path of least resistance. Note that you could also just use an explicit commit rather than a branch or tag, if you go that path. And then just update the commit ref as needed.

true ... the human readability could be viewed as a thing. Remembering a year from now that commit is there cause we are aligned with ruby-2.7, whereas it is obvious from the tag

from ruby-hello-world.

openshift-bot avatar openshift-bot commented on September 26, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from ruby-hello-world.

openshift-bot avatar openshift-bot commented on September 26, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

from ruby-hello-world.

openshift-bot avatar openshift-bot commented on September 26, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

from ruby-hello-world.

openshift-ci avatar openshift-ci commented on September 26, 2024

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from ruby-hello-world.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.