Giter Club home page Giter Club logo

Comments (7)

wewang58 avatar wewang58 commented on June 24, 2024

@adambkaplan @gabemontero @coreydaley anyone takes time to update this to be compatible with ruby 2.5, now our qe ci automation failed of this, though I saw it's in todo e2e list: https://github.com/openshift/origin/blob/master/test/extended/builds/start.go#L284, thanks very much.

from ruby-hello-world.

adambkaplan avatar adambkaplan commented on June 24, 2024

@wewang58 you can probably give this a shot yourselves, we'd be happy to review a PR.

What you'll need to do is as follows:

  1. Switch the Dockerfile to use the ruby-25-centos7 image
  2. On a machine or container with ruby 2.5, update the Gemfile to use compatible versions of the gems. Run bundle install and commit the resulting Gemfile and Gemfile.lock files.
  3. Submit a PR with the results.

from ruby-hello-world.

pvalena avatar pvalena commented on June 24, 2024

Implemented in #85 AFAICT.

from ruby-hello-world.

openshift-bot avatar openshift-bot commented on June 24, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from ruby-hello-world.

openshift-bot avatar openshift-bot commented on June 24, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

from ruby-hello-world.

openshift-bot avatar openshift-bot commented on June 24, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

from ruby-hello-world.

openshift-ci-robot avatar openshift-ci-robot commented on June 24, 2024

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from ruby-hello-world.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.