kroitor / gjk.c Goto Github PK

When I run it, I get ~1.4% failing test cases. Here's an example of one:

    {4.000010, 11.000005}, {4.999991, 4.999999}, {8.999989, 8.999995}
    {3.999999, 10.999990}, {5.000005, 4.999998}, {9.000001, 8.999989}

Here's another:

    {3.999993, 11.000011}, {4.999998, 5.000003}, {8.999994, 9.000011}
    {3.999994, 10.999999}, {5.000001, 4.999989}, {9.000001, 9.000003}

Thanks again for such a wonderful Readme.md you have done. I've shared your repository with others, and they did give some feedback. I am wondering if you're able to answer them.

One of them said the following:

I'm not sure why you feel the need for Minkowski-Space. Surely R^n suffices and if I'm any judge that is what you use. Please note that M^n and R^n are not the same thing. In fact, I can't see why Minkowski-Space is really used here.

The GJK algorithm relies on Minkowski sums + differences, which transforms the problem into a space sometimes called the collision space - what he calls the Minkowski space. Source

Perhaps, it could be that there may be some sort of mixup between the Minkowski space mentioned in the Readme.md, and the Minkowski space related to physics.

Randy Gaul, game engine developer, gave another feedback on your code.

Please take a look here:

https://www.reddit.com/r/gamedev/comments/6wivay/gilbertjohnsonkeerthi_gjk_collision_detection/dm9g3mk/

Hello,
How can i download your package in python3?
I downloaded the files: gjk.c gjk_wrapper.c and setup.py, then when i do the command: python setup.py build it creates a file gjk.cpython-35m-x86_64-linux-gnu.so in build folder....
What i should do after ?