jeroenpardon / skin.grid Goto Github PK

Hi,

There's something bugging me about the main menu, I feel like the submenu items should be offset to the right a little bit, as well as being displayed in a smaller font. Only because when the submenu is activated, it appears to just blend in too much with the main menu items and becomes a bit messy to navigate, especially when the are a lot of submenu items.

I edited the skin to quickly to test this and it did look much better to me.. However I quickly realised that because of the way the submenu is designed this cannot be achieved without affecting the unfocussed main menu items.

Perhaps having the main menu as a seperate list? It will allow you much greater flexibility and in turn probably help fix a lot of the focus issues that keep being mentioned. I know you're probably trying to minimise code, but sometimes it's just needed.

Time and date on homescreen is showing double vision after recent update lol

Are there supposed to be unwatched indicators? I don't see them or an option to enable them.

As the title suggests. I like the poster view but I love to see what ratings the movies have as this helps guide me to watch certain films/shows.
However, I can see that this may clutter the design, so I can understand why you wouldn't add this to the poster view.

Having said that, can we get the ratings visible on the movie info page?? right now you have the MPAA rating but no user ratings.

Right now when using the poster view there's absolutely no way to know the rating as it cannot be found on either of the windows which is a little frustrating.

Play / pause buttons missing from OSD controls using pvr.

issues 2.0

1. skin shortcuts - if you're customising the home menu, select a menu entry and press right to highlight any of the two edit buttons,
   then press up or down. You'd expect that pressing up/down should take you to the next menu entry, but instead the onup/ondown actions are mapped the same as the onleft action...
   Makes for really unpleasant navigation

reproduce:

• press "customize home menu and widgets"
• move right twice and select "Add Shortcut"
• Press "right" to highlight the options button (represented by the 3 vertical dots)
• From here, pressing "up" should take you up... but instead takes you left.

2. Pressing "back" on the options menu within a library takes you "back" instead of just closing the options menu.
   this causes a bug where entering back into the library shows a blank options menu to the left, even though the options menu isn't in focus.
   see here:http://imgur.com/nJdcyog

3. Should context menus perhaps appear in the center or align to the left if there's no art to display? looks odd having all that dead space to the left... Could be done by simply adding a slide animation with the appropriate conditions.
   http://imgur.com/yoBxlGb

4. perhaps align square images to the top of the screen instead of the bottom in the context menus?
   This would probably go against the design though i guess... and might make the reflections look a little weird.
   http://imgur.com/hH1jJFw

5. no recording/timer icons in EPG grid

6. channel icons are still overlapping the watched status in recordings window.

In Skin Settings, Set Background Type, It would be awesome to have a setting for Fanart that allows me to exclude Music, as most of my music library is jacked, and I prefer the TV and Movie fanart.

In reFocus, one of my favorite features was the TV In Progress widget showing me the shows in the order in which they were last watched. On top of that, pressing on an in progress show would automatically play the first unwatched episode. It would be awesome to see that functionality again.

With the vertical minimal home screen and widget feed as statusbar info, the recently added movie info is missing.

Question: did you make the youtube widget view in refocus? It was cool that it showed the thumbnail on top of the fanart. Not a huge miss, but it was a nice touch.

1/ Are the chapters still in WIP? Need to be organized. I like to see the chapters well labeled :)
http://prntscr.com/f65hf9

2/ http://prntscr.com/f65ipg
The text information to disappear? !!.

Search subtitle : The page information (top left this mix)
http://prntscr.com/f65m2l

https://pastebin.com/Cpxum5BK

Reboot on OSMC after selecting Grid as skin.

Interestingly, I managed to get the skin going briefly using another profile – was even able to adjust settings. However, when I exited to 'home' screen it only showed the grid wallpaper.

I can't remember if I told you this already but the Now Playing info is showing up over video screensaver again.

Welcome!

You are now a member of the Grid beta testing team. This Github repository will be the home of Grid's source. Currently this repository is set to private, only people I have invited have access to it's contents.

This means I also trust you to not share anything you find here. This includes (the source of) the skin, but also any information about it including features, screenshots and so on. World peace doesn't depend on it, but I really want to keep details on the skin under wraps for the moment. I will probably share some information about the skin before the public release, but that hasn't been decided just yet.

Installing Grid

With that out of the way, let's talk about testing. It will not be long before I will push the first commit to this repository. For anyone not familiar with Github, when you are ready to install Grid:

1. Go to the Code tab. There you will find the green Clone or download button.
2. Click that button and choose Download zip
3. Save it anywhere you want (I recommend saving it to the device you are going to install Grid on. Installing from network shares has been known to sometimes cause isssues)
4. Install the skin in Kodi by going to the Addon browser and choosing Install from zip

Required add-ons

Depending on what add-ons you already have installed on your device, you may have to install additional add-ons before you are able to install Grid. The public release will be distributed through Kodi's repository, and any required add-ons will then be installed automatically. Until then, this has to be done manually. For more information on this, please refer to this page.

Posting bug reports

When you have a bug to report please:

1. Go to the Issues tab above,
2. Check if someone else has already reported the bug
3. If not submit a new issue and describe the problem. You can attach files if needed.
4. After reviewing your report, I will label the issue and of course will give you feedback on when I expect to fix it or ask you for more information.
5. When I upload a fix I will label your bug report with rework test which means the issue should be solved but I would like a confirmation.

Whenever you report a bug, please always make sure you are using the latest commit.

Questions / discussion

If you have any questions please post them here on Github. There's no forum, but we can "abuse" the Issues tab for this. Simply post an issue, but apply the yellow Discussion label to it (see Labels on the right hand of the page). That way I can separate discussions / questions from the bugs.

Final note

I think that should cover the basics. As said, don't hesitate to ask questions.

I hope you will like Grid obviously, and I hope you will enjoy being part of this project. I would like to thank you all very much for helping out!

Add programme title and end time to DialogPVRChannelsOSD

Widgets need a "busy" indicator to indicate they are loading / refreshing and can't be accessed yet.

"Skin Settings" – "Other" – "Show date" places date directly over current time (maybe if "Show Time" is selected too?)

In a TV show with multiple seasons; when using slide or poster view, the poster displays on each season, but does not display on the *All Seasons entry.

In various Movie and TV views, most obvious in gallery, and in the Widgets, a movie title over a white background completely disappears. Perhaps a drop shadow or a slight dark opacity would resolve this cleanly.

Welcome!

You are now a member of the Grid beta testing team. This Github repository will be the home of Grid's source. Currently this repository is set to private, only people I have invited have access to it's contents.

This means I also trust you to not share anything you find here. This includes (the source of) the skin, but also any information about it including features, screenshots and so on. World peace doesn't depend on it, but I really want to keep details on the skin under wraps for the moment. I will probably share some information about the skin before the public release, but that hasn't been decided just yet.

At the moment of writing this, Grid is not yet made available. I expect it to be some time this week.

Installing Grid

With that out of the way, let's talk about testing. It will not be long before I will push the first commit to this repository. For anyone not familiar with Github, when you are ready to install Grid:

1. Go to the Code tab. There you will find the green Clone or download button.
2. Click that button and choose Download zip
3. Save it anywhere you want (I recommend saving it to the device you are going to install Grid on. Installing from network shares has been known to sometimes cause isssues)
4. Install the skin in Kodi by going to the Addon browser and choosing Install from zip

Required add-ons

Depending on what add-ons you already have installed on your device, you may have to install additional add-ons before you are able to install Grid. The public release will be distributed through Kodi's repository, and any required add-ons will then be installed automatically. Until then, this has to be done manually. For more information on this, please refer to this page.

Posting bug reports

When you have a bug to report please:

1. Go to the Issues tab above,
2. Check if someone else has already reported the bug
3. If not submit a new issue and describe the problem. You can attach files if needed.
4. After reviewing your report, I will label the issue and of course will give you feedback on when I expect to fix it or ask you for more information.
5. When I upload a fix I will label your bug report with rework test which means the issue should be solved but I would like a confirmation.

Whenever you report a bug, please always make sure you are using the latest commit.

Questions / discussion

If you have any questions please post them here on Github. There's no forum, but we can "abuse" the Issues tab for this. Simply post any questions in this issue. That way I can separate discussions / questions from the bug reports.

Final note

I think that should cover the basics. As said, don't hesitate to ask questions.

I hope you will like Grid obviously, and I hope you will enjoy being part of this project. I would like to thank you all very much for helping out!

Jeroen, the new update fixed the problem of hard drive access and storages. Now I can go get my images for the background Home menu.
This works fine (some problem with image slideshow), although I have a hard time understanding why there is Single image with Single and Multi image as choice
And Image slideshow, with simple and Multi image too. I have not seen what that changes.

On the other hand when I activate Single image, or Image slideshow now, there is no longer the follow-up of the fanarts on the views. It remains blocked on a only fanart (random).

I'll share a video for you to understand well my new problem ^^.
Video : ( pass = Grid )
Ps : https://pool185.seedbox.fr/files/index.php/s/FODnal537DXdVGX

Possibly something animated, to indicate the skin is preparing the home screen.

I know PVR provably drives you nuts so I do apologise.

I'm happy you've fixed the channel logo thumbs overlapping the watched indicators in recordings, but can we get some watched indicators for recordings? Even if this means getting rid of the logo thumbs and using indicators instead as they're probably more important.

Also, some skins show the storage capacity information for the recordings folder (total space/used space) so we can see how much storage we have left. Is there anywhere we can fit this in the window?

Adding "Favourites" common menu item to home menu or sub menu doesn't list contents. Another "common" menu item, "Movies", works fine – might just be "favourites"

The Big List viewtype is currently missing TV Show logo's when browsing nodes like watchlist, recently added episodes, etc.

Hi Jeroen,

I made a comment on this commit: bfaccd7

Thought I'd better post here as I'm not sure if you're seeing the comments on the commits or not.
Just a couple lines of code needed for the pvr scraper to work on the recordings window as well.

Vertical Minimal Menu - If I enter the movies sub menu and choose an item lower in the submenu (ex. Recently added), after navigating around the movies and backspacing out to the main menu, Movies is no longer in focus, instead the menu item in the position of the lower item (ex. Recently added) is highlighted, in my case, Add-ons.

Hi everyone,

All of the reported bugs should either be solved, or I am working on them.

I would like to try if we can get the beta 1 release ready at some point next week. That should give us a stable base for Beta 2 in which I will be looking to implement some requests and things I had already planned.

The beta 2 testing period I hope we can limit to about 2 weeks max.

After that I think we will be ready for a public preview release.
I will possibly start a separate branch for a Kodi 18 / Leia compatible version, but I am not sure yet, will depend on how beta 2 goes.

So, I hereby kindly request to let me know of any bugs you encounter. If it is already an open issue you don't need to report it (unless you have new findings of course).

Thanks so far everybody for all your time, efforts and feedback!

Cheers,
Jeroen

Music Library, Artists, Context Menu, Artwork Options, Manual Configure, Fanart, Browse, 1) there is no option for selecting a network share, 2) there is a folder icon to the right of the X icon that cannot be selected, and 3) pressing right highlights the X icon but then the arrow keys become nonresponsive. To choose something other than X you need to use the mouse.

Entering Skin Settings - Library and navigating below "Ratings" heading I can't navigate back up again, can only go down. I can cycle all the way down and re-appear at the top again (or exit and re-enter category) but I don't think that's what you want.

It's the only settings category that does this, I think.

It appears that in Slide view the scrolling does not work. I put Fast and nothing changes.

When I configure list view artwork type to Fanart and Landscape artwork to Fanart the list view for Movies displays landscape artwork.

TV Shows display fanart in list view and then when you enable Logos the fanart is shown together with the logo.

This is what should be the expected behaviour for Movies.

#2 When setting the background to Fanart (Movies and TVShows Only) does that mean the images are only fanart from Movies and TVShows OR the background is set for the menu items Movies and TVShows only?

I don't see any difference when I set the background to Fanart or Fanart (Movies and TVShows only)

Please use this space for discussion, questions, etc.

Possibly addon issue.

Make use of the pvr artwork scraper in skin helper.

Selection made in skin settings for video shouldn't affect music.

Just updated.
1.You've reintroduced the logos overlaying the watched status in recordings lol

2.I like the logo overlay on the fanart.

3. There's a microphone icon to the right of the channel list now.

4. PVR OSDInfo doesn't show the channel name. Only shows the channel list number and program title.

5. Watched status is now working on all views.

6. Random 'back' arrows are now fixed on submenu items.

I would post photos but I'm in a rush. Let me know if you need more info.

Using reFocus for so long, I forgot how ugly the TVNextAired GUI is. It would be awesome to have it styled a la reFocus.

For example in certain addon's settings windows.

Add option in info windows to open plot description in textviewer dialog

When choosing visualisation in now playing artwork, i don't see the visualisation.
If you enable animated backgrounds it shows the visualisation for a second when the animation 'resets'.
It does work when you choose blend.

And long album names overlap with the now playing bar in the songs view. It shows three dots ... when the bar gets activated but the text doesn't get cut off. I see some text overlapping in other areas too. But you're probably aware of those (subtitle d/l e.g.)

Request:
I've been asking this a couple of times... sorry, you spoiled me in an earlier version of refocus.
I loved the stretched out album artwork on the home screen when playing music without fanart.
Also the visualisation visible on the home screen would be awesome too.

Hi Jeroen,
I tried some point of view. Save and load backup backup point of view. Here is an example that you should load and see some rendered. In the gallery view the plot text is too dark, otherwise too light. There are automatic settings in Kover with possibility to load (I work on this skin Kover to create different color set.)

I have encountered problems to load color backup after reset Grid origin.
https://www.dropbox.com/s/mbpck7zx1tu50ak/Grid%20ColorTheme%20-%20White%20background%20.zip?dl=0
Grid could have community trading for custom colors. If you have custom colors of you, you can trade me and I can see if the exchange from Grid to Grid is functional.

https://www.dropbox.com/s/p46lziz0enqha9y/screenshot000.png?dl=0

Perhaps I'm just dopey, but I think some kind of small widget indicator on the right hand side of the main menu screen in Vertical Minimal might be helpful for those that Don't think to press right to bring up the widget.

Additionally, it may be good to default the widget stream to Spotlight instead of full or add a bottom of the screen widget indicator as it took me quite a while to figure out that pressing down would show the other widgets.

First of all... WOW, I just found my favourite skin.
This blows them all out of the water mate, hats off to you. Excellent work!

ok, let's get into it....
I'll list a few things that I've discovered after a short test, all cosmetic for now.
I'll list more as I find them.
First, I have a few questions/suggestions if you'll hear me out..

1. "select scrolling type" ... active/passive Doesn't appear to do anything ... is this to change from a standard list to a "Fixed list" ? if not , refer to question 2.

2. can we get an option to have all lists act as fixed lists with the focused item in the center of the screen? , it just feels so much better when navigating a list to have my eye focused on the center while the list is scrolling, otherwise once you reach the bottom of the page, you're just blindly scrolling the
list and can't anticipate what the next item is.

4. can you make use of the pvr artwork scraper in skin helper. You can create the following variable and point the blown up icon texture to it:
<variable name="PVRThumb"> <value condition="!IsEmpty(Window(Home).Property(SkinHelper.ListItem.Art.Fanart))">$INFO[Window(Home).Property(SkinHelper.ListItem.Art.Fanart)]</value> <value condition="!IsEmpty(Window(Home).Property(SkinHelper.ListItem.Art.Thumb))">$INFO[Window(Home).Property(SkinHelper.ListItem.Art.Thumb)]</value> <value condition="Window.IsVisible(MyPVRRecordings.xml)">$INFO[ListItem.Icon]</value> <value condition="Window.IsVisible(DialogPVRInfo.xml)">$INFO[ListItem.Icon]</value> </variable>

5. perhaps pressing up on video info should bring up a custom dialog that shows a fullsceen plot overlay with enlarged font... So if we want to clearly read the plot without struggling to make out the text we can do so easily from the info screen. See arctic zephyr for example.

6. I love using the slide view, but is there any chance you can make the posters a little samller so we can fit about 7 on the screen? as you can see, I have 700 movies... having only 4 visible on the screen at a time can be a little frustrating, see the beolow images for a comparision between Grid and AZ.
http://imgur.com/jODjoAY
http://imgur.com/E8wQWa7

7. Can you perhaps display a video window in the EPG grid when background video is detected?
and if nothing is currently playing, perhaps display the scraped fanart or thumb from the variable mentioned above?
http://imgur.com/dhGm3vQ

ISSUES:

I'll provide pictures... As it's easier to just point to the problem.

1. PVR Recordings - Icons are overlapping watched indicators:
http://imgur.com/m5jqmcp

2. Currectly playing dialog is showing up on top of video screensavers.... I actually don't mind this, but it's not how it should work. It should not be visible over a screensaver.
http://imgur.com/TkwkzGo

3. OSD Info is not aligned with the bottom of the screen
http://imgur.com/mlCW0mV
http://imgur.com/naQsE2x

4. OSD Channel List is too small and too transparent... nearly impossible to see the list as the background video shows through too much. perhaps changing it to a white colour like the options menus or that of Refocus.
http://imgur.com/QelfHwG

5. OSD Video/Audio settings header is meshing with another header
http://imgur.com/9XgvJPu
http://imgur.com/YBVELqz

6. No IMPAA Ratings in list view info line even though the setting is enabled.
http://imgur.com/xyMUd0x

7. OSD player control suffering from the same transparency issue
http://imgur.com/SsI3b1S

8. If you assign the variable mentioned above, we'll be able to see scraped fanart or thumbnails for PVR channels instead of a massive pixely version of the channel icon
http://imgur.com/xxrY0LT

9. When viewing cast information 'onright' and 'onback' function should act the same as pressing left, currently pressing right does nothing... Naturally its the first thing I tried, just feels weird pressing left to get back to the buttons
http://imgur.com/Smcugi8

10. EPG grid info does not scroll, I have the setting enabled.

11. Search - fullscreen visual keyboard says "enter search string" but doesn't display the search string.

12. No currently recording indicators on channels in channel list or timeline.... and no timer icon indicator in the timeline on programs that are scheduled for recording.

13. Weird characters displayed in timeline when an empty item is selected. Should probably display "No Information Available" instead.
http://imgur.com/v2KFfAl

14. Pressing "BACK" on the PVR timeline should take you back, not bring up the view options. the current "onleft" action is fine.

15. There seems to be a bunch of settings missing from the "PVR & LIVE TV SETTINGS" window.
have a look at estuary and you'll see

16. when header too long it'll overlapthe time/date
http://imgur.com/FwcGJM2

https://ibb.co/hKCEwQ

I noticed last night that the TV widget displays the clearart on the right side of the screen. It would be tremendous to have a settings option to change this to logos instead. Additionally, it would be nice to have this functionality on the movie widget as well. I'm a big fan of logos but have always found clearart odd, inconsistent, and often unavailable.

Hi Jeroen

Have a lot of catching up to do after being on the road the last week. Read through most of the issues reported and fixed.

Installed latest commit. Skin visually looks great, love your choice of font type for the headings.

Feature request:
In skin settings when customising submenu if you want to move the placement of items up or down you can only complete the move one position incrementally from the menu selection before it exits. Can the focus be maintained in the window so you can move multiple positions before exiting?

Are you considering displaying a message or indicator on the GRID splash screen so you know to wait while it completes loading the homepage. After installation I wasn't sure what was happening and was about to exit KODI when the homepage launched.

For Video OSD can the default position be set to the Pause or Stop button?

Will report back with more feedback after putting it through its paces.

When I activate the Grid Backup, it tells me succes full directly. I do not have access to the depot site. Then for restore, it opens the storage slots, but I can not find my backup. How is it named? Where is it stored? Thank you
Sorry if it is clear to find, but I am lost for a while on this point :(

In Movies; when using landscape, list, and big list view, the movie logos display on single movies, but do not display on movie sets. When entering movie sets, the individual movies display their logo.

https://pastebin.com/raw/XbCtHwYg
When I use Thumbnail in the widget view, home menu and widget crashes

and And it would be nice to have the title on the scenery on the widget too.
http://prntscr.com/f5seev