Comments (11)
- Fixed
- Fixed
- I agree, but it is more complicated than it seems as the skin can't always check whether there is artwork. And if it could, an animation would be able to move it to the left, but it can't resize the list, so it would look out of place too. Maybe making two versions of the context menu list and using parameters to include them when applicable would work, but generally Kodi doesn't like multiple controls with the same ID. And as the context menu is generated internally by Kodi it cannot have a different ID.
Will think about possible solutions later - Yeah, I don't particularly like it either, but I dislike breaking consistency more
- Will look into it
- Didn't even know it showed channel icons there, the PVR Demo Add-on doesn't at least. Will look into it
from skin.grid.
BTW, could you confirm whether #11 is working?
from skin.grid.
BTW, could you confirm whether #11 is working?
No, it's not working. I actually commented on the commit with the solution.
8b688e4
the code does not like your addition : String.StartsWith(pvr://channels/) +
Also,
With the addition of PVR scraping, there should be an option in the "context menu" for "artwork options" which allows you to manually scrape and fine tune the scraped results. This does not appear in your skin, so i'm assuming you have to specify a dependency for this or something?
In order for it to work, I have to change to a skin that supports it, like Arctic Zephyr.... Then I have to change back to Grid, then the artwork will start to populate and I can edit it etc. Provided I remove String.StartsWith(pvr://channels/) + from your code.
from skin.grid.
also left a comment here regarding fullscreen info :
20e57b1
from skin.grid.
Didn't even know it showed channel icons there, the PVR Demo Add-on doesn't at least. Will look into it
see here PVR recordings window:
http://imgur.com/iMxdZBi
from skin.grid.
I mentioned to you that there were settings missing from the PVR & Live TV Settings window.
I have kodi set to "EXPERT" in both skins, and you can see in the images below that quite a few settings are missing in grid.. Not sure what's going on here ? perhaps you'll have to compare Grid with Estuary.
http://imgur.com/MOh0KRT
http://imgur.com/5L7rQn4
from skin.grid.
Not sure what the go is but kodi crashes for me when i'm using Grid and try to change to the Estuary theme. happening on Libreelec and Windows. can you try change to the Estuary theme and see if you get the same crash?
from skin.grid.
Also, I thought you fixed the "Now playing" info showing up on top of video screensavers, but the problem is back again...
http://imgur.com/mW6sfea
from skin.grid.
Question,
Do you plan on adding submenu support for the "Stream" style main menus?
from skin.grid.
The crash when changing to Estuary is a known issue, no Idea what the cause of it is at the moment.
Submenu on vertical stream: possibly, on stream: no
from skin.grid.
Will make a separate issue for no recording/timer icons in EPG grid
The rest should be fixed, or is under consideration, so closing this to keep things organized
from skin.grid.
Related Issues (20)
- Request: Smaller slides (option or another view) to give fanart a bit more visibility HOT 2
- Request: OSD playback progress indicator when pressing "enter" in addition to showing the menu HOT 6
- Option to disable genre colours HOT 2
- Vertical widget focus 2.3.1 HOT 2
- Add in progress tv shows as hub source HOT 1
- Feature Request - Episode Number in TV Slide View HOT 3
- Skin failed to install on Leia HOT 4
- Impossible to find LibreElec settings HOT 1
- OSD settings audio/video lose focus when video is in pause with information HOT 1
- PVR - Please show "extra text" within a directory of recordings
- PVR - Picon missed for tvshows under Kodi 18
- Downloading subtitles dialog and no feedback, when there's none
- Support for "playtempo" in skin
- No button for CMS in OSD
- PVR Feature Request - New timeshift functionalties for pvr osd
- TV season posters defaulting to TV Show poster
- [Feature Request]: Search feature
- Unable to set custom library background. Kodi Freez
- workaround for Kodi 18 v18
- REMOVE ME FROM THE PARTICIPANTS!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skin.grid.