Giter Club home page Giter Club logo

Comments (11)

jeroenpardon avatar jeroenpardon commented on May 16, 2024
  1. Fixed
  2. Fixed
  3. I agree, but it is more complicated than it seems as the skin can't always check whether there is artwork. And if it could, an animation would be able to move it to the left, but it can't resize the list, so it would look out of place too. Maybe making two versions of the context menu list and using parameters to include them when applicable would work, but generally Kodi doesn't like multiple controls with the same ID. And as the context menu is generated internally by Kodi it cannot have a different ID.
    Will think about possible solutions later
  4. Yeah, I don't particularly like it either, but I dislike breaking consistency more
  5. Will look into it
  6. Didn't even know it showed channel icons there, the PVR Demo Add-on doesn't at least. Will look into it

from skin.grid.

jeroenpardon avatar jeroenpardon commented on May 16, 2024

BTW, could you confirm whether #11 is working?

from skin.grid.

loggio avatar loggio commented on May 16, 2024

BTW, could you confirm whether #11 is working?

No, it's not working. I actually commented on the commit with the solution.
8b688e4

the code does not like your addition : String.StartsWith(pvr://channels/) +

Also,
With the addition of PVR scraping, there should be an option in the "context menu" for "artwork options" which allows you to manually scrape and fine tune the scraped results. This does not appear in your skin, so i'm assuming you have to specify a dependency for this or something?
In order for it to work, I have to change to a skin that supports it, like Arctic Zephyr.... Then I have to change back to Grid, then the artwork will start to populate and I can edit it etc. Provided I remove String.StartsWith(pvr://channels/) + from your code.

from skin.grid.

loggio avatar loggio commented on May 16, 2024

also left a comment here regarding fullscreen info :
20e57b1

from skin.grid.

loggio avatar loggio commented on May 16, 2024

Didn't even know it showed channel icons there, the PVR Demo Add-on doesn't at least. Will look into it

see here PVR recordings window:
http://imgur.com/iMxdZBi

from skin.grid.

loggio avatar loggio commented on May 16, 2024

I mentioned to you that there were settings missing from the PVR & Live TV Settings window.

I have kodi set to "EXPERT" in both skins, and you can see in the images below that quite a few settings are missing in grid.. Not sure what's going on here ? perhaps you'll have to compare Grid with Estuary.
http://imgur.com/MOh0KRT
http://imgur.com/5L7rQn4

from skin.grid.

loggio avatar loggio commented on May 16, 2024

Not sure what the go is but kodi crashes for me when i'm using Grid and try to change to the Estuary theme. happening on Libreelec and Windows. can you try change to the Estuary theme and see if you get the same crash?

from skin.grid.

loggio avatar loggio commented on May 16, 2024

Also, I thought you fixed the "Now playing" info showing up on top of video screensavers, but the problem is back again...
http://imgur.com/mW6sfea

from skin.grid.

loggio avatar loggio commented on May 16, 2024

Question,
Do you plan on adding submenu support for the "Stream" style main menus?

from skin.grid.

jeroenpardon avatar jeroenpardon commented on May 16, 2024

The crash when changing to Estuary is a known issue, no Idea what the cause of it is at the moment.

Submenu on vertical stream: possibly, on stream: no

from skin.grid.

jeroenpardon avatar jeroenpardon commented on May 16, 2024

Will make a separate issue for no recording/timer icons in EPG grid
The rest should be fixed, or is under consideration, so closing this to keep things organized

from skin.grid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.