Giter Club home page Giter Club logo

Comments (4)

BastiaanOlij avatar BastiaanOlij commented on June 21, 2024

Still no clue whats causing this, but was able to reproduce this without needing XR hardware:
StereoFogOmniBug.zip

image

from godot.

BastiaanOlij avatar BastiaanOlij commented on June 21, 2024

This took a lot of puzzling but I found it:

For sky we are using uniform location 4 and optionally 5 for respectively out directional light buffer and our multiview buffer.
In our scene shader we've reserved uniform location 4: SCENE_EMPTY, // Unused, put here to avoid conflicts with SKY_DIRECTIONAL_LIGHT_UNIFORM_LOCATION.
But uniform location 5 is our omni light buffer.

Ergo, in multiview we're using the wrong buffer

from godot.

Fire551 avatar Fire551 commented on June 21, 2024

opened the project on my end using 4.2, it was still green, checked again on 4.3, it was blue. downgraded to 4.1, it was green.

heres 4.1
image

how has this never been brought up in detail?? this is such a blatant visual error. wouldn't almost every quest3 dev run into this??

i noticed it doesnt cause a change on a albedo color of (0,0,255) like the grass, but when using a value of (255, 255, 0) it darkens the color?? what operation can cause this?? some kind of averaging?

image

this is light on
image

this is light off
image

back to 4.3
which seems to be different from yours, where it makes it glow.
also worthwhile noting that the grass still isnt affected

weirdly enough ive noticed something.
so apparently, the bug acts completely different depending if shadows are enabled, it seems to be an "additive" force only to anything with a blue hue. affects end result of albedo
image
image

from godot.

BastiaanOlij avatar BastiaanOlij commented on June 21, 2024

@Fire551 basically it was just getting junk data for Omni lights, using multiview data from the sky shader instead. So the output will be very unpredictable but definitely completely wrong.
I'm pretty sure this bug goes all the way back to Godot 4.0.

from godot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.