Comments (7)
Huh this sucks, I will look into this
from three-customshadermaterial.
I solved it by creating the material in a useAsset
block - caching it "globally" - then passing it in as an attribute <mesh material={myMaterial} ...
and not inline as a jsx element. But it's not as nice.
from three-customshadermaterial.
Yeah you could do the same with useMemo, I’ll be refactoring this library again with the patterns I learnt working on other projects to make it solid and easy to work with.
from three-customshadermaterial.
Im not sure where to add console.log(material.current)
to test this. Do you mean to useFrame
?
I added it outside useFrame
and It's only recreated every time the component is re-rendered. Adding it inside useFrame shows that the UUID of the material remains unchanged, which implies it is not re-initialized on each renader
from three-customshadermaterial.
Sorry - unclear language :D
It's recreated every time react calls the render function (not for every threejs render!)
That is still not great though - and not the way other react three fiber components work - the reconcilliation part should only recreate three objects when their properties change. Look at this slightly contrived example: https://codesandbox.io/s/getting-started-01-forked-j5d2r?file=/src/App.js
The material remains constant, although the state changes and the App is re-rendered.
I think the problem happens because you do {...rest}
- this creates a new props object each time, and react uses === for matching them.
At the same time, I am confused, since the using {...rest} to pull out the props you care about and passing the rest on seems like a common pattern 🤷
from three-customshadermaterial.
OK so I added a log to the constructor of the CustomShaderMaterial class to see how many times its initialized.
The water example currently initializes it twice, however, moving the <Water />
component outside of <Suspense />
makes it only initialize once. I have pushed the "fixed" example to the repo and sandbox.
Suspense might be forcing a re-render of everything within it. Does this solve it?
from three-customshadermaterial.
Closing as solved, reopen if necessary
from three-customshadermaterial.
Related Issues (20)
- Is it possible to output a normal from a fragment shader? HOT 2
- "Multiple instances of Three.js being imported" issue HOT 3
- Can you disable projection in the vertex shader? HOT 3
- CustomShaderMaterial error HOT 6
- Add csm_Bump? HOT 5
- If the base material has a map, a CSM from it throws an error on three >= 0.151.0 HOT 1
- Shader compilation failure if csm_Feature used is not compatible with base material HOT 2
- Warning: Function copy already exists on CSM, renaming to base_copy HOT 2
- Support macro defines like THREE.ShaderMaterial HOT 1
- Waves example seems to be broken HOT 3
- Extended meshBasicMaterial does not have access to cameraPosition uniform HOT 3
- Problem with using csm_PositionRaw and InstancedMesh HOT 9
- TresJs implementation HOT 2
- How to change the opacity of extended material ? HOT 3
- Couldn't extend `<MeshReflectorMaterial/>` from `drei` HOT 1
- Feature request addition of transmision and thickness maps HOT 1
- Cannot use both csm_DiffuseColor and csm_FragColor in if/else HOT 3
- Extending ShadowMaterial HOT 22
- Accessing csm_FragColor values in if statement causes white rendering HOT 3
- Failed to resolve module specifier "crypto" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from three-customshadermaterial.