Giter Club home page Giter Club logo

Comments (3)

FarazzShaikh avatar FarazzShaikh commented on July 20, 2024

I've looked into it. Unfortunately, the fix is not as simple as just setting isShaderMaterial to true, being a ShaderMaterial means the WebGLRenderer handles the material differently in terms of creation, disposal and caching. The main issue being that the pre-build shader IDs are hardcoded into the renderer here:
https://github.com/mrdoob/three.js/blob/74939a623cf06ef68b6eb3e2c66f36d127f8bd1a/src/renderers/webgl/WebGLPrograms.js#L20

This means that setting isShaderMaterial runs some code ment for ShaderMaterial and some code meant for baseMaterial. Reuslting in things breaking.

I think the best thing for CSM is to simply pretend to be its baseMaterial all the way through. It is a shame ThreeJS doesnt have a first class system for material extentions but this is the best were going to get for now.

You can also pass in the uniforms you need manually and use them as needed

from three-customshadermaterial.

chasedavis avatar chasedavis commented on July 20, 2024

Thanks for looking into it @FarazzShaikh. The good news is that there are plenty of workarounds but I wanted to file in case it helped to improve CSM.

Appreciate it!

from three-customshadermaterial.

FarazzShaikh avatar FarazzShaikh commented on July 20, 2024

Appreciate you using it! Glad to look into any possible improvements 😄

from three-customshadermaterial.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.