Comments (5)
Perhaps a dumb question, but what part of this can actually "crash"? It seems more likely users will just get errors, which can be logged but not all of them should be directly sent somewhere.
from vanilla-installer-python.
Perhaps a dumb question, but what part of this can actually "crash"? It seems more likely users will just get errors, which can be logged but not all of them should be directly sent somewhere.
There's cases where it might hang, but I couldn't actually find a sys.exit
in the main.py, which is interesting. It's probably worth implementing some exits in cases where we know it'll fail, if we run into them.
from vanilla-installer-python.
Right. Well, currently I am against this idea and would rather suggest making it really easy for users to report this stuff (stack trace + version/system data templates, direct links to GitHub and Discord).
Can be reconsidered later if there still seems to be a need for this.
from vanilla-installer-python.
what part of this can actually "crash"?
Oh, I think I have expressed incorrectly. I mean errors in general.
from vanilla-installer-python.
I am against this idea and would rather suggest making it really easy for users to report this stuff
Okay! I'm OK with your choice since I was also unsure. But I agree with your point that we should make error reporting easier. I can do this.
from vanilla-installer-python.
Related Issues (20)
- [Feature Request]: macOS 13 support for Vanilla Installer itself HOT 2
- [Feature Request]: Pojav Launcher support HOT 10
- [Feature Request]: Translation support HOT 2
- [Bug]: Font won't apply immediately HOT 5
- [Bug]: GUI is too big in size HOT 5
- [Bug]: GUI takes too long to open HOT 2
- [Bug]: Minecraft won't launch (1.19.2/1.16.5) HOT 5
- [Bug]: Blank terminal window pops up on install HOT 7
- [Bug]: Install button can be clicked during the install HOT 1
- [Feature Request]: Rename/simplify "data" folder HOT 4
- [Feature Request]: Separate instance HOT 6
- [Bug]: Long versions are unreadable HOT 2
- [Bug]: FO won't install (1.19.3) HOT 6
- [Feature Request]: Prevent "Modpack is already up to date!" HOT 6
- [Bug]: Logs save to the parent directory
- [Feature Request]: Warn on downgrades HOT 3
- [Feature Request]: Allow advanced cmdlines in installer. HOT 1
- [Bug]: Separate instance Fabric installation
- [Feature Request]: Explanatory tooltip next to versions HOT 2
- [Feature Request]: Scripts for *nix HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vanilla-installer-python.