Comments (6)
Still present on beta 2
from vanilla-installer-python.
For later, I can reproduce and it gives an UnboundLocalError
...
from vanilla-installer-python.
Having looked into this a bit more, I think it's an issue going back to installing Fabric - because the UnboundLocalError
is with version_id
, which is only used in that function. But how is that variable not being assigned?
from vanilla-installer-python.
Figured out the issue here - it's looking for a folder named "1.19.3 (beta)" because that's what's shown in the UI, but the backend doesn't resolve that to look for the folder in FO repo named "1.19.3" (or rather, Packwiz/1.19.3).
from vanilla-installer-python.
In that case the JSON could have separate visible name and folder name.
from vanilla-installer-python.
I also figured out that when installing Fabric, we're manually resolving the version, instead of using the JSON (which was used in get_pack_mc_versions
and newest_version
) - so resolving from the JSON instead should fix this issue and prevent other similar ones.
from vanilla-installer-python.
Related Issues (20)
- [Feature Request]: macOS 13 support for Vanilla Installer itself HOT 2
- [Feature Request]: Pojav Launcher support HOT 10
- [Feature Request]: Translation support HOT 2
- [Bug]: Font won't apply immediately HOT 5
- [Bug]: GUI is too big in size HOT 5
- [Bug]: GUI takes too long to open HOT 2
- [Bug]: Minecraft won't launch (1.19.2/1.16.5) HOT 5
- [Bug]: Blank terminal window pops up on install HOT 7
- [Bug]: Install button can be clicked during the install HOT 1
- [Feature Request]: Rename/simplify "data" folder HOT 4
- [Feature Request]: Separate instance HOT 6
- [Bug]: Long versions are unreadable HOT 2
- [Feature Request]: Prevent "Modpack is already up to date!" HOT 6
- [Bug]: Logs save to the parent directory
- [Feature Request]: Warn on downgrades HOT 3
- [Feature Request]: Allow advanced cmdlines in installer. HOT 1
- [Bug]: Separate instance Fabric installation
- [Feature Request]: Explanatory tooltip next to versions HOT 2
- [Feature Request]: Scripts for *nix HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vanilla-installer-python.