Giter Club home page Giter Club logo

Comments (6)

Madis0 avatar Madis0 commented on September 24, 2024 1

Still present on beta 2

from vanilla-installer-python.

osfanbuff63 avatar osfanbuff63 commented on September 24, 2024

For later, I can reproduce and it gives an UnboundLocalError...

from vanilla-installer-python.

osfanbuff63 avatar osfanbuff63 commented on September 24, 2024

Having looked into this a bit more, I think it's an issue going back to installing Fabric - because the UnboundLocalError is with version_id, which is only used in that function. But how is that variable not being assigned?

from vanilla-installer-python.

osfanbuff63 avatar osfanbuff63 commented on September 24, 2024

Figured out the issue here - it's looking for a folder named "1.19.3 (beta)" because that's what's shown in the UI, but the backend doesn't resolve that to look for the folder in FO repo named "1.19.3" (or rather, Packwiz/1.19.3).

from vanilla-installer-python.

Madis0 avatar Madis0 commented on September 24, 2024

In that case the JSON could have separate visible name and folder name.

from vanilla-installer-python.

osfanbuff63 avatar osfanbuff63 commented on September 24, 2024

I also figured out that when installing Fabric, we're manually resolving the version, instead of using the JSON (which was used in get_pack_mc_versions and newest_version) - so resolving from the JSON instead should fix this issue and prevent other similar ones.

from vanilla-installer-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.