Comments (4)
We don't need comments in the config file, these can be just documented to wiki itself. GUI users wouldn't need to edit it anyway and CLI users are used to wikis 😛
from vanilla-installer-python.
Yeah, I had considered making this some sort of config file - this was original when I started work on the project, and so that's been the 'tradition' so to speak. I do agree that one vanilla-installer.cfg
or similar would be better.
from vanilla-installer-python.
The only problem with the above solution...is the constant config file type debate. Here's some options off the top of my head:
Python's ini-like configparser
format
Since the library is already built into Python, it makes it a bit easier to do - however, its format is relatively unique and doesn't have a ton of specific standards afaik.
JSON
Another that's built into Python. This is a good option, but we can't use comments in JSON and it's not the most readable format on this list.
TOML
This would personally be my go-to. Since we already have tomllib
on 3.11 and tomli
, it wouldn't be hard to add the write companion. The advantages also include having a readable config file format - so if someone wants to look at just what are we storing in said config file, it's very easy to do. Comments can also show
Those are probably the best options, but I'm open to other suggestions.
from vanilla-installer-python.
CLI users are used to wikis
As someone who managed quite a few Minecraft servers, having comments in config files is really useful.
So sorry, but I have to disagree here.
from vanilla-installer-python.
Related Issues (20)
- [Feature Request]: macOS 13 support for Vanilla Installer itself HOT 2
- [Feature Request]: Pojav Launcher support HOT 10
- [Feature Request]: Translation support HOT 2
- [Bug]: Font won't apply immediately HOT 5
- [Bug]: GUI is too big in size HOT 5
- [Bug]: GUI takes too long to open HOT 2
- [Bug]: Minecraft won't launch (1.19.2/1.16.5) HOT 5
- [Bug]: Blank terminal window pops up on install HOT 7
- [Bug]: Install button can be clicked during the install HOT 1
- [Feature Request]: Separate instance HOT 6
- [Bug]: Long versions are unreadable HOT 2
- [Bug]: FO won't install (1.19.3) HOT 6
- [Feature Request]: Prevent "Modpack is already up to date!" HOT 6
- [Bug]: Logs save to the parent directory
- [Feature Request]: Warn on downgrades HOT 3
- [Feature Request]: Allow advanced cmdlines in installer. HOT 1
- [Bug]: Separate instance Fabric installation
- [Feature Request]: Explanatory tooltip next to versions HOT 2
- [Feature Request]: Scripts for *nix HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vanilla-installer-python.