Giter Club home page Giter Club logo

Comments (6)

osfanbuff63 avatar osfanbuff63 commented on June 22, 2024

This is already supported by the file dialog to select a folder so you could select any folder anywhere - especially since from everything I've heard recently, you shouldn't nest instances inside .minecraft, you should use a different folder inside pretty much anywhere else.

We might still want to implement this, but not sure.

from vanilla-installer-python.

Madis0 avatar Madis0 commented on June 22, 2024

Well, if I select a new folder outside .minecraft, e.g. .minecraft-2, it gets stuck on setting profiles.

from vanilla-installer-python.

osfanbuff63 avatar osfanbuff63 commented on June 22, 2024

Well, if I select a new folder outside .minecraft, e.g. .minecraft-2, it gets stuck on setting profiles.

Well that's apparently a bug...you don't need to file a new ticket for it unless you want to, we have enough 😅. What's probably happening is that dir is being passed to the create profile function, which needs to be .minecraft since that's the only place that file exists.

from vanilla-installer-python.

Madis0 avatar Madis0 commented on June 22, 2024

Indeed, the installer needs to know where .minecraft is, so I wouldn't exactly consider that a bug if I don't tell it where it is :D

So separate profiles should be either inside or next to .minecraft, IMO letting users define the specific path/folder name is not necessary.

from vanilla-installer-python.

tuxinal avatar tuxinal commented on June 22, 2024

What's probably happening is that dir is being passed to the create profile function, which needs to be .minecraft since that's the only place that file exists.

We could hardcode the .minceraft folder for the create profile function since the only way for it to need another value is to change the launcher's working directory which can only be changed through command line options. at which point we can assume the user knows enough to not be troubled by this.

from vanilla-installer-python.

Madis0 avatar Madis0 commented on June 22, 2024

We could hardcode the .minceraft folder for the create profile function since the only way for it to need another value is to change the launcher's working directory which can only be changed through command line options. at which point we can assume the user knows enough to not be troubled by this.

I don't agree with that, Minecraft Launcher can also be used as portable, in a different hard drive or various methods in Linux.

from vanilla-installer-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.