arpg / cvars Goto Github PK

Examples were still referening to cvars with uppercase letters, as well as some other includes which made building on Linux to fail with missing files. Demo2 is using usleep which needs unistd.h header to be included. I have forked/cloned master branch a new, and fixed those thus new pull request.

PS.
There are no CMake build files in this one :-).

The fix/tinyxml2 branch is still unmerged, and when I tried using it today on a fresh Ubuntu installation it failed to build with C++ errors related to the std library. My guess is that it's out of date with the current Ubuntu bionic libc-dev.

Goal here is to finally merge this fix and save some headache for those trying to install our version of Pangolin etc. from scratch. @JStech is the last person who worked on the branch so my guess is you could probably fix and I could test?

Default branch should be master, not homebrew

I am actually trying to test your library and have run into multiple annoyances. I don't know if it is just me, but I have problems with your use of upper and lower case letters in file names and include directives.

When I cloned your code, I got folder "include/cvars" (all lowercase letters) with some includes in it. The thing is your code is refering to include dir as "CVars" for example "CVars/CVar.h". That might work fine on windows which is case preserving but not case sensitive when it comes to file and directory names, but linux is case sensitive. I have to either fix all includes to be all lower case or rename folder from cvars to CVars which I thought would be simpler fix, just to find that some of your includes are refering to "cvars/Cvars.h" as well! :-)

I have finally just batch edited all references to be "cvars/filename.h" and changed all filenames to lowercase as well. I don't know if it was something on my part, but that's what I had to do to get your code to work.

Is possible change license on MIT?
then maybe I would integrate your library in my project instead myGUI console

It would be nice if the default didn't force OpenGL and GLEW. TextConsole and console-less usage have no need for either.

It looks like the OpenGL and GLEW dependency can be optional.

Remove the REQUIRED from:
find_package(OpenGL QUIET)
find_package(GLEW QUIET)

Remove line from CVars.h:
#include <CVars/glplatform.h>

If you like I could submit a PR, but the changes are pretty minimal.

I could not find any examples or some documentation. The .h files include too much code, to extract the interface in a short time.
Is there some sort of documentation? If not, is it welcomed if I may contribute it?

Cheers,
Benedikt S. Vogler