Comments (10)
PeterJohnson
commented on July 18, 2024
Those symbols are associated with protobuf. The cmake build pulls in protobuf via wpiutil, and transitive library dependencies should bring it in (libglassnt -> libglass -> wpiutil -> protobuf::libprotobuf). What libprotobuf is cmake picking up? This looks like the same error with another piece of software, but no response yet: BVLC/caffe#7019 (comment)
We also no longer frequently test the "make" build; could you also try the Ninja generator?
from allwpilib.
mfisher31
commented on July 18, 2024
Trying the Ninja generator now: Protobuf is from homebrew:
-- Found Protobuf: /opt/homebrew/lib/libprotobuf.dylib (found version "5.26.1")
from allwpilib.
PeterJohnson
commented on July 18, 2024
This also seems similar, so it could be a library link order issue in homebrew packaging of protobuf and/or abseil? bincrafters/community#176
from allwpilib.
mfisher31
commented on July 18, 2024
I was thinking that too, but order of libraries should only matter when linking against static versions.
Ninja lists these libraries as part of the Linker command. Only one protobuf* library in here.
lib/libntcore.dylib lib/libglass.dylib lib/libwpinet.dylib lib/libwpigui.dylib lib/libimgui.dylib lib/libglfw3.a -framework Cocoa -framework IOKit -framework CoreFoundation lib/libwpimath.dylib lib/libwpiutil.dylib /opt/homebrew/lib/libprotobuf.dylib lib/libfieldImages.dylib
But if I check with pkg-config, not *.cmake packages, several libraries are listed including -labsl_spinlock_wait
% pkg-config --libs protobuf
-L/opt/homebrew/Cellar/protobuf/26.1/lib -L/opt/homebrew/Cellar/abseil/20240116.2/lib
-L/opt/homebrew/Cellar/protobuf/26.1/lib -L/opt/homebrew/Cellar/abseil/20240116.2/lib
-lprotobuf -labsl_log_internal_check_op -labsl_leak_check -labsl_die_if_null
-labsl_log_internal_conditions -labsl_log_internal_message -labsl_examine_stack
-labsl_log_internal_format -labsl_log_internal_proto -labsl_log_internal_nullguard
-labsl_log_internal_log_sink_set -labsl_log_sink -labsl_log_entry -labsl_flags_internal
-labsl_flags_marshalling -labsl_flags_reflection -labsl_flags_private_handle_accessor
-labsl_flags_commandlineflag -labsl_flags_commandlineflag_internal -labsl_flags_config
-labsl_flags_program_name -labsl_log_initialize -labsl_log_globals -labsl_vlog_config_internal -labsl_log_internal_fnmatch -labsl_log_internal_globals -labsl_raw_hash_set -labsl_hash
-labsl_city -labsl_low_level_hash -labsl_hashtablez_sampler -labsl_statusor -labsl_status
-labsl_cord -labsl_cordz_info -labsl_cord_internal -labsl_cordz_functions
-labsl_exponential_biased -labsl_cordz_handle -labsl_crc_cord_state -labsl_crc32c
-labsl_crc_internal -labsl_crc_cpu_detect -labsl_bad_optional_access -labsl_strerror
-labsl_str_format_internal -labsl_synchronization -labsl_graphcycles_internal
-labsl_kernel_timeout_internal -labsl_stacktrace -labsl_symbolize -labsl_debugging_internal
-labsl_demangle_internal -labsl_malloc_internal -labsl_time -labsl_civil_time -labsl_time_zone -labsl_bad_variant_access -lutf8_validity -lutf8_range -labsl_strings -labsl_strings_internal
-labsl_string_view -labsl_base -labsl_spinlock_wait -labsl_int128 -labsl_throw_delegate
-labsl_raw_logging_internal -labsl_log_severity
However, this library doesn't get pulled in with protobuf. I tried adding protobuf::libprotobuf to libglassnt's link_libraries, but the same missing symbol errors appear.
Detecting protobuf with pkg-config over cmake packages might be the way to go. I don't have this problem in Linux.
Otool is showing that this homebrewed protobuf has been itself linked to this spinlock thing.
% otool -L /opt/homebrew/lib/libprotobuf.dylib | grep spinlock
/opt/homebrew/opt/abseil/lib/libabsl_spinlock_wait.2401.0.0.dylib (compatibility version 2401.0.0, current version 0.0.0)
from allwpilib.
PeterJohnson
commented on July 18, 2024
It definitely sounds like something is broken in homebrew if find_package on protobuf isn’t pulling in what it needs to actually work. We can do a workaround but I would recommend you open an issue there as well.
from allwpilib.
mfisher31
commented on July 18, 2024
So maybe this is just a newer v.s. older protobuf then, #6610? If that's the case, this #6609 might not be as much of a workaround by, in the cmake files, if/else'ing around the version number where abseil became a dependency.
from allwpilib.
mfisher31
commented on July 18, 2024
But I guess that still trickles back to protobuf not bringing it's own deps....
from allwpilib.
mfisher31
commented on July 18, 2024
Upstream issue previously reported:
protocolbuffers/protobuf#12637
from allwpilib.
PeterJohnson
commented on July 18, 2024
Also protocolbuffers/protobuf#15604 (comment)
from allwpilib.
mfisher31
commented on July 18, 2024
Fixed with #6609
from allwpilib.
Related Issues (20)
- roboRIO Team Number Setter crashes while refreshing status
- Segfault when destroying AprilTag detector
- be able to use InterpolatingDoubleTreeMap.put().put()... inline HOT 9
- Upgrade to PMD 7.1.0 HOT 1
- Remove RuntimeLoader and RuntimeDetector
- C++ command based examples don't all use CommandPtr HOT 3
- Example of LTVUnicycleController with path following
- ElevatorExponentialProfile example HOT 1
- Add usage reporting ID for DataLogManager (and/or DataLog)
- Add abseil-cpp as a 3rd party library HOT 2
- Add Example Command-Based Best-Practices
- Deprecate robotInit() HOT 2
- CommandRobot discussion HOT 1
- DifferentialDrivetrainSimTest doesn't converge (sometimes) because of LTVUnicycleController HOT 1
- Add `Twist2d ChassisSpeeds::ToTwist2d(units::second_t dt) const`
- Use Java StackWalker API instead of custom logic HOT 1
- Refactor default commands to be held by the subsystem (resource) not the scheduler. HOT 1
- `SimHooks.stepTiming()` hangs when called from a callback registered with `SimDeviceSim.registerValueChangedCallback()` if another `SimDeviceSim` has been created HOT 2
- Make usage of `Set` and `...` syntax more consistent HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from allwpilib.