Giter Club home page Giter Club logo

Comments (1)

KangarooKoala avatar KangarooKoala commented on July 18, 2024 1

Based on https://stackoverflow.com/questions/66122388/is-it-possible-to-walk-stack-frames-from-an-exception and looking through the StackWalker docs, I'm not sure the complete issue would be feasible. (We can do some parts of it but not all of it)

  1. Most of our usages of getStackTrace() are from reporting the stack trace of an already thrown exception. However, the StackOverflow post linked above indicates that StackWalker can't be used to process the stack trace of an already thrown exception, so DriverStation.reportError() and MathSharedStore.reportError() have to keep the StackTraceElement[] parameter for that use case. We could make DriverStation.reportError(String error, boolean printTrace) overload use StackWalker, but that would lead to code duplication since we still need the logic for the StackTraceElement[] case.
  2. This isn't the main point of this issue, but the efficiency seems to be from not having to create all of the stack trace elements, but because our usages of the stack traces are reporting errors, we have to process all of the stack trace elements anyways. (The only elements we skip are from the top of the stack, which means that the walker still has to create all of the elements for us to either determine we should skip or to report in the (processed) stack trace)

Summary: We could use StackWalker for DriverStation.reportError(String error, boolean printTrace), but that would lead to code duplication. If we want to use the stream API for more ergonomic processing, we could stream the array of stack trace elements (though that would add the stream API's overhead).

from allwpilib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.