Giter Club home page Giter Club logo

datalinkengineeringcanopen's People

Contributors

ulrikhagstrom avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

datalinkengineeringcanopen's Issues

Hi there

After to make the changes, can setup these adapters on vci driver for windows?

CANOpen SDO write buffer corruption when writing less data bits than the previous data write

Hi Ulrik,

Observing the CANbus when writing SDOs, a UINT32 with value 0xFFFFFFFF and then immediately writing a UINT8 with value 0x0C the value seen on the CAN bus is 0x0CFFFFFF. This creates a problem for the target CAN device I am using and throws it into an Emergency State.
To overcome this problem I have changed your code to reset to 0x00 the 4 data bytes in the buffer: not particularly elegant but it does seem to work.

canOpenStatus SDO :: setData(u32 val, u8 valid, u8 *n)
{
canOpenStatus ret = CANOPEN_ERROR;
if (valid > 0 && valid <= 4)
{
this->can_data_tx[4] = 0x00;
this->can_data_tx[5] = 0x00;
this->can_data_tx[6] = 0x00;
this->can_data_tx[7] = 0x00;
if (valid == 1)
{
::setU8Val((u8)val, this->can_data_tx, 4);
}
else if (valid == 2)
{
::setU16Val((u16)val, this->can_data_tx, 4);
}

I hope you can fix this issue for me, in the meantime I will use a modified version
Kind Regards
Guy Pender

Units of timeouts

It is unclear what units are used for the timeouts in e.g. the SDO client:

CANOPENDLL_API void setWriteObjectTimeout(unsigned int timeout);
CANOPENDLL_API void setReadObjectTimeout(unsigned int timeout);
CANOPENDLL_API void setNodeResponseTimeout(unsigned int timeout);

The scaling of the default values give an indication it might be microseconds.

#define WRITE_OBJ_TIMEOUT 200000
#define READ_OBJ_TIMEOUT 400000
#define TAIL_TO_TAIL_TIMEOUT 2000

Having to assume the units is unsafe. A suggestion is to rename the function parameters to e.g. timeout_microseconds, timeout_milliseconds etc and add suffixes to the default parameters.

License with support

Hi.

(sorry for using github issues, but contact form on http://www.datalink.se/ does not work at this time)

We recently purchased a license with no support but, after having completed library integration in our software, we hit a performance issue (i.e. time spent in a SDO transaction is about 75ms, much more than expected).

Could we extend license in order to get support about that issue?

Thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.