Giter Club home page Giter Club logo

nodl's People

Contributors

aprotyas avatar arnatious avatar artivis avatar emersonknapp avatar florcabral avatar guillaumebeuzeboc avatar kyrofa avatar

Stargazers

avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

arnatious mikaelarguedas seanyen linuxperia kyrofa terrorizer1980 aprotyas canonical emersonknapp rpjday

nodl's Issues

ros2 nodl show not finding nodl descriptions when installed from subdirectory with ament_nodl

So, I have a line like this in my example:

nodl_export_node_description_file(nodl/fake_imu.nodl.xml)

This installs the file and an ament_index marker file to:

$ tree install/
install/
├── ros2launch_security_examples
│   └── share
│       ├── ament_index
│       │   └── resource_index
│       │       ├── nodl_desc
│       │       │   └── ros2launch_security_examples
...
│       └── ros2launch_security_examples
│           ├── nodl
│           │   ├── fake_imu.nodl.xml
...

The ament_index marker file contains:

$ cat install/ros2launch_security_examples/share/ament_index/resource_index/nodl_desc/ros2launch_security_examples
share/ros2launch_security_examples/nodl/fake_imu.nodl.xml
share/ros2launch_security_examples/nodl/imu_sink.nodl.xml

But if I run ros2 nodl I get:

$ ros2 nodl show ros2launch_security_examples
ros2launch_security_examples has no NoDL files in its ament index.

The expected behavior is that it finds these files, but it does not.

If I move the .nodl.xml files out of the subdirectory, then everything works:

$ ros2 nodl show ros2launch_security_examples
{'name': 'imu_sink', 'executable': 'imu_sink', 'actions': {}, 'parameters': {}, 'services': {}, 'topics': {'imu': {'name': 'imu', 'type': 'sensor_msgs/msg/Imu', 'role': <PubSubRole.SUBSCRIPTION: 'subscription'>}}}
{'name': 'fake_imu', 'executable': 'fake_imu', 'actions': {}, 'parameters': {}, 'services': {}, 'topics': {'imu': {'name': 'imu', 'type': 'sensor_msgs/msg/Imu', 'role': <PubSubRole.PUBLISHER: 'publisher'>}}}

Based on the documentation of nodl_export_node_description_file() and the contents of the ament_index file, I would have expected any hierarchy of directories for the nodl description files to be ok. But the python library (and therefore the cli tool) seem to expect all description files to be in the root of the package's share directory:

nodl/nodl_python/nodl/_index.py

Line 38 in 3457cbf

path for path in package_share_directory.glob('*' + _FILE_EXTENSION) if path.is_file()

So is this expected behavior or maybe a bug?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.