Giter Club home page Giter Club logo

Comments (2)

tr7zw avatar tr7zw commented on June 20, 2024

If I remember correctly, skipping on shouldRender caused some unintended side effects, since that check assumes that the entity is outside of the frustum. Looking at it, it mainly just does the outline(glowing) preparations right after, which is the only "lot of unnecessary stuff". But then glowing entities can't be seen through walls. So I'd also need to check for glowing in my code... at which point this just gets done twice. So moving it into shouldRender wouldn't be any benefit.

from entityculling.

tr7zw avatar tr7zw commented on June 20, 2024

Ah, also I need some stuff like the pose stack to for example render the nametag of culled entities. Cancelling at shouldRender would also remove the nametag, and I'd be missing the posestack to render it myself(since shouldRender only has the entity and frustum).

from entityculling.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.