sfx-wow / masque Goto Github PK

Hi,

I'm getting the below error when trying to load Masque settings. None of my skins are showing.

Message: Interface\AddOns\Masque\Options\Skins.lua:457: attempt to index field 'Skins' (a nil value) Time: Mon Oct 28 10:18:31 2019 Count: 1 Stack: Interface\AddOns\Masque\Options\Skins.lua:457: attempt to index field 'Skins' (a nil value) Interface\AddOns\Masque\Options\Skins.lua:457: in function UpdateSkinOptions'
Interface\AddOns\Masque\Core\Group.lua:417: in function __Update' Interface\AddOns\Masque\Core\Groups.lua:84: in function <Interface\AddOns\Masque\Core\Groups.lua:58> Interface\AddOns\Masque\Core\Groups.lua:91: in function GetGroup'
Interface\AddOns\Masque\Options\Skins.lua:425: in function func' Interface\AddOns\Masque\Options\Core.lua:34: in function <Interface\AddOns\Masque\Options\Core.lua:31> Interface\AddOns\Masque\Options\Core.lua:118: in function func'
Interface\AddOns\Masque\Options\Core.lua:34: in function <Interface\AddOns\Masque\Options\Core.lua:31>
Interface\AddOns\Masque\Options\Core.lua:132: in function ToggleOptions' Interface\AddOns\Masque\Masque.lua:115: in function ?'
Interface\FrameXML\ChatFrame.lua:4839: in function ChatEdit_ParseText' Interface\FrameXML\ChatFrame.lua:4502: in function ChatEdit_SendText'
Interface\FrameXML\ChatFrame.lua:4538: in function `ChatEdit_OnEnterPressed'
[string ":OnEnterPressed"]:1: in function <[string ":OnEnterPressed"]:1>

Locals: self =

Include SFX-Widgets as an external rather than embedding it.

• Update .pkgmeta
• Remove Options\Widgets
• Update Libs\Libs.xml
• Update Options\Options.xml

Switch to unified packages that support all official game versions.

• Create Classic and Burning Crusade Classic .toc files. (Retail will use the default .toc)
• Move the LibDualSpec-1.0 external to the Retail .toc.
• Update the workflows.

Verison: 8.2.0-Beta
Addons/Skins: Weakauras + Masque

The latest 8.2 version of Masque is causing a 1 pixel misalignment between the cooldown sweep animation and the icon. The 8.1.5-Alpha-3 version is working correctly. This is present with all of the default Masque skins, and is especially bad for the "Classic" skin.

Notice the top part of the icon is showing, as well as the cooldown sweep extending 1 pixel too far down.
Zoomed skin example
Classic skin example

• .github/pre-release.yml
• .github/release.yml
• Masque.toc

Masque currently supports custom SpellAlert textures but does not support the custom shapes needed for them to work.

Ref: b5cf6b7

I noticed I have some issues with Masque not applying the skin properly at login. After some tests, I found it was related to custom skins and the order in which addon are loaded.

I have made a reproducible test case, using an addon written for this (whose files are there: https://gist.github.com/Adirelle/9b6f2078996305045824e74db8927953).

To do the test, I enabled only these addons :

• !MasqueTest
• Masque
• Masque_Caith

Here is the output (sorry for the guild MOTD):

Please notice that:

• !MasqueTest is loaded before Masque_Caith, and Caith skins are not available at that time.
• when the callback is called with "Caith" as skinID, the said skin is not available ("my skin: nil"). It means !MasqueTest is not skinned with its configured skin.

This happens because addons without dependency relationships are loaded in alphabetical order on Windows. Please note, that even if they were loaded in random order, this bug could still happen.

Would it be possible to reskin the groups when custom skins are added ?

@StormFX just here then, yeah? https://github.com/Stanzilla/nivBuffs/blob/37985f5f785023965eb033fe1fca1d3ec4066c4c/nivBuffs.lua#L275 I tested with checking that btn exists but that still errord.

Originally posted by @Stanzilla in #57 (comment)

Transfer to SFX-WoW to keep the repos organized.

I just realized I posted this on wowinterface and the correct method is to go through Github. Apologize for that!

I am having an issue with the strata of the CD text using blizzards in game cd text on action bars. https://i.imgur.com/EHxT6rn.png
The count of the item has a higher strata than the CD text. Without masque, dominos shows the cooldown above the count.

When changing from a texture to a color texture, the color and alpha must be reset to prevent a blending of two, resulting in the wrong color and/or alpha.

hi first put the error

Message: ...\LibKeyBound-1.0\LibKeyBound-1.0\LibKeyBound-1.0.lua:68: attempt to call method 'CreateTitleRegion' (a nil value)
Time: Sat Jul 21 15:13:52 2018
Count: 1
Stack: ...\LibKeyBound-1.0\LibKeyBound-1.0\LibKeyBound-1.0.lua:68: attempt to call method 'CreateTitleRegion' (a nil value)
...\LibKeyBound-1.0\LibKeyBound-1.0\LibKeyBound-1.0.lua:68: in function `Initialize'
...\LibKeyBound-1.0\LibKeyBound-1.0\LibKeyBound-1.0.lua:662: in function <...\LibKeyBound-1.0\LibKeyBound-1.0\LibKeyBound-1.0.lua:656>

Locals: self =

• Update the Retail ToC to 90001.

Language

• zhTW

Phrases

L["This action will increase memory usage."] = "這個動作會增加記憶體的使用量。"

The yellow charge cooldown spirale remains squared even when picking a round skin.
Additionaly, trying to set this in the skin lua does not seem to change anything at all

ChargeCooldown = { Width = 0, Height = 0, Color = {0, 0, 0, 0}, },

The wiki needs a major overhaul.

RealUI's cooldown meta method hook is being overwritten by Masque's widget hook. Need to hook a different method.

When I updated from 7.2.0 to 7.2.3, the hotkey text no longer gets placed where defined in my skin. No matter what values I use for HotKey.OffsetX or HotKey.OffsetY, it always ends up in the wrong place.

I am using Bartender with this skin (this happens even after setting Masque_Version = 70200)

I am currently trying to finish a new update to my UI, and for this i have a simple setup addon that simply sets a AceDB profile and copy settings from a profile i've made.

My Lua capabilities are very limited, but i managed to get the above behavior working for all addons i use, expect Masque.

local PrankUISetup = {};

local MasqueDB = LibStub("AceAddon-3.0"):GetAddon("Masque");

PrankUISetup.DB = function(addon)
    addon.db:SetProfile(UnitName("player").." - "..GetRealmName());
    addon.db:CopyProfile(ProfileName.."-default", true);
end

PrankUISetup.DB(MasqueDB);

This code, which i has just isolated to show an example, is how i do it for other addons.

Can you look into a solution where i can use :SetProfile() and :CopyProfile() for Masque?

Kind Regards
Dennis aka. Prankstar

• .github/pre-release.yml
• .github/release.yml
• Masque.toc

Hello,

Will Masque be updated for Classic WoW (1.13)? If so, is there an ETA?

Best Regards,
ManneN

Since Masque 8.1.2-Alpha, I'm getting the following error whenever a buff runs out.

Message: Interface\AddOns\Masque\Core\Regions\Normal.lua:50: attempt to index local 'Normal' (a nil value)
Time: Sun Apr  7 19:15:32 2019
Count: 3
Stack: Interface\AddOns\Masque\Core\Regions\Normal.lua:50: attempt to index local 'Normal' (a nil value)
[C]: ?
Interface\AddOns\Masque\Core\Regions\Normal.lua:50: in function <Interface\AddOns\Masque\Core\Regions\Normal.lua:45>
[C]: in function `SetNormalTexture'
Interface\AddOns\PitBull4\Modules\Aura\Controls.lua:220: in function `onDelete'
Interface\AddOns\PitBull4\Controls\Controls.lua:130: in function `Delete'
Interface\AddOns\PitBull4\Modules\Aura\Update.lua:650: in function <Interface\AddOns\PitBull4\Modules\Aura\Update.lua:582>
Interface\AddOns\PitBull4\Modules\Aura\Update.lua:758: in function `UpdateAuras'
Interface\AddOns\PitBull4\Modules\Aura\Aura.lua:77: in function `UpdateFrame'
Interface\AddOns\PitBull4\Modules\Aura\Update.lua:952: in function `OnUpdate'
Interface\AddOns\PitBull4\Modules\Aura\Aura.lua:21: in function <Interface\AddOns\PitBull4\Modules\Aura\Aura.lua:18>

Locals: 

Version:
8.2.5-beta

Settings:
Classic theme + Dominos + Clean Icons: Thin

Descriptions:

1. black pixels around the corner of buttons on action bars, which makes buttons looking aliased.
2. GCD cooldown animation would cover the GLOW effect, which just ruins the action bar in combat.

Something else:
The old "Blizzard" masque theme + dominos is just perfect for me. In fact, I haven't changed my action bar style since 2011. With this re-worked beta version, I have to retune Masque and Dominos and end up very SAD. Everything seems off and weird. The borders in Classic theme aren't as bright as Blizzard theme and with the increased size of Classic theme, I have to shrink action bar buttons via Dominos, which makes the borders thin and stack texts on buttons small.

Is it too much to ask for a built-in "Blizzard" legacy theme? Or a "Masque: Blizzard" standalone plug-in?

Hi Storm. I have a problem whit your creation . I use Bartender4 but, after the reset complete of pc, doesn't work. Sorry for my english, i'm italian guy. I need your big Addon and i belive in you. Help me, please!

The error:

e: Interface\AddOns\Masque\Core\Options.lua:237: bad argument #2 to 'format' (string expected, got no value)
Time: 02/14/18 21:43:30
Count: 1
Stack: Interface\AddOns\Masque\Core\Options.lua:237: bad argument #2 to 'format' (string expected, got no value)
[C]: ?
[C]: in function format' Interface\AddOns\Masque\Core\Options.lua:237: in function GetOptions'
Interface\AddOns\Masque\Core\Options.lua:131: in function UpdateOptions' Interface\AddOns\Masque\Core\Options.lua:77: in function LoadOptions'
Interface\AddOns\Masque\Core\Options.lua:99: in function ShowOptions' Interface\AddOns\Masque\Masque.lua:121: in function OnClick'
...e\AddOns\Masque\Libs\LibDBIcon-1.0\LibDBIcon-1.0.lua:116: in function <...e\AddOns\Masque\Libs\LibDBIcon-1.0\LibDBIcon-1.0.lua:116>

Locals:

Message: Interface\FrameXML\InterfaceOptionsFrame.lua:434: Usage: InterfaceOptionsFrame_OpenToCategory("categoryName" or panel)
Time: 02/14/18 21:43:38
Count: 11
Stack: Interface\FrameXML\InterfaceOptionsFrame.lua:434: Usage: InterfaceOptionsFrame_OpenToCategory("categoryName" or panel)
[C]: ?
[C]: in function assert' Interface\FrameXML\InterfaceOptionsFrame.lua:434: in function InterfaceOptionsFrame_OpenToCategory'
Interface\AddOns\Masque\Core\Options.lua:103: in function ShowOptions' Interface\AddOns\Masque\Masque.lua:121: in function OnClick'
...e\AddOns\Masque\Libs\LibDBIcon-1.0\LibDBIcon-1.0.lua:116: in function <...e\AddOns\Masque\Libs\LibDBIcon-1.0\LibDBIcon-1.0.lua:116>

Locals:

Remove the SetPoint replacement function for the HotKey region since the game hasn't used it since build 14732.

Note to self: Pay attention to API changes.

• Update deDE.
• Update ruRU.
• Update the Retail ToC to 90100.

The contents of .docs should be moved to the Wiki to clean up the repository and to make them more accessible.

• .docs/History.md
• .docs/Regions.lua

Update the esMX/esES file with additions from the WoW Ace localization application.

In the 'Zoomed' skin, the tick box for 'Background' is already ticked, but the option is greyed out and can not be changed. This means it is not possible to have a dark background like the other skins for empty parts of the action bars (in a similar way to the default bar option to 'Always show action bars'. Would it be possible to change it so that you can have the dark background for empty slots?

Game Version
Retail - 8.3.7

Add-On Version
8.3.0

Describe the Issue
Fresh install/update of of Masque via Twitch App. AceGUI-3.0: SFX-Widgets gets installed as a separate addon and thus gets loaded by default. I wasn't aware that it would be installed, so I was greeted with a Lua-error.

Error Message

1x ...dOns\AceGUI-3.0_SFX-Widgets\Widgets\SFX-Info-URL.lua:18: Cannot find a library instance of "AceGUI-3.0".
[string "=[C]"]: in function `error'
[string "@AceGUI-3.0_SFX-Widgets\LibStub\LibStub.lua"]:38: in function `LibStub'
[string "@AceGUI-3.0_SFX-Widgets\Widgets\SFX-Info-URL.lua"]:18: in main chunk

Locals:
(*temporary) = "Cannot find a library instance of "AceGUI-3.0"."

I know that you've set SFX-Widgets as an external, but it is also present in Libs\ and gets loaded by Libs\Libs.xml . I don't load AceGUI separately either. What is the intention here?

Switch to BigWigs packager and GitHub actions.

• CI
  • Disable Travis CI
  • Remove .travis.yaml.
• Packager
  • Remove Webhooks
  • Disable Curse Packager
  • Add .pkgmeta-classic
  • Add manual-lint.yml, pre-release and release.yml Files
• ToC
  • Add Conditional Interface Version

Currently, LibActionButton-1.0 adjusts the text position of the HotKey region based on its value. This is behavior that the official client removed in 4.3.0 (15005).

This issue was reported here and compatibility code was implemented in Masque to account for it. As of 0.35-6-g8c96488-alpha, this issue has been addressed. (👍@Nevcairiel )

Update various files in the repo.

• Move CONTRIBUTING to .github
• Update .gitattributes
• Update .pkgmeta
• Update CHANGELOG.md.
• Update LICENSE.txt
• Update README.md

• Update the Retail ToC to 80300.

Is there a planned TBC update? I tried using the current 9.0 or 1.13 versions of the addon on the Beta but im getting this errors:

2x ...dOns\Masque\Libs\LibDualSpec-1.0\LibDualSpec-1.0-19.lua:77: attempt to call global 'GetNumSpecializationsForClassID' (a nil value)
[string "@Masque\Libs\LibDualSpec-1.0\LibDualSpec-1.0-19.lua"]:77: in main chunk

Locals:
MAJOR = "LibDualSpec-1.0"
MINOR = 19
lib = <table> {
 registry = <table> {
 }
 options = <table> {
 }
 upgrades = <table> {
 }
 currentSpec = 0
 eventFrame = <unnamed> {
 }
 mixin = <table> {
 }
}
minor = nil
registry = <table> {
}
options = <table> {
}
mixin = <table> {
}
upgrades = <table> {
}
AceDB3 = <table> {
 db_registry = <table> {
 }
 frame = <unnamed> {
 }
 New = <function> defined @AtlasLootClassic\Libs\AceDB-3.0\AceDB-3.0.lua:709
}
AceDBOptions3 = <table> {
 optionTables = <table> {
 }
 handlers = <table> {
 }
 GetOptionsTable = <function> defined @Masque\Libs\AceDBOptions-3.0\AceDBOptions-3.0.lua:442
}
AceConfigRegistry3 = <table> {
 RegisterOptionsTable = <function> defined @Masque\Libs\AceConfig-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:315
 validated = <table> {
 }
 tables = <table> {
 }
 callbacks = <table> {
 }
 RegisterCallback = <function> defined @AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
 GetOptionsTable = <function> defined @Masque\Libs\AceConfig-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:360
 UnregisterCallback = <function> defined @AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
 IterateOptionsTables = <function> defined @Masque\Libs\AceConfig-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:346
 NotifyChange = <function> defined @Masque\Libs\AceConfig-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:289
 ValidateOptionsTable = <function> defined @Masque\Libs\AceConfig-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:276
 UnregisterAllCallbacks = <function> defined @AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
}
_ = "Warlock"
_ = "WARLOCK"
classId = 9
(*temporary) = nil
(*temporary) = 9
(*temporary) = "attempt to call global 'GetNumSpecializationsForClassID' (a nil value)"

2x Masque\Masque-90002.lua:107: attempt to call method 'EnhanceDatabase' (a nil value)
[string "@Masque\Masque-90002.lua"]:107: in function <Masque\Masque.lua:73>
[string "=[C]"]: ?
[string "@Masque\Libs\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <...aceMasque\Libs\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@Masque\Libs\AceAddon-3.0\AceAddon-3.0-13.lua"]:498: in function `InitializeAddon'
[string "@Masque\Libs\AceAddon-3.0\AceAddon-3.0-13.lua"]:623: in function <...aceMasque\Libs\AceAddon-3.0\AceAddon-3.0.lua:615>

Since I guess the release was 7.2.1 and now 7.2.2 I am occasionally getting errors using masque to skin my action bars with the dominos addon

This error will pop up randomly

1x [ADDON_ACTION_BLOCKED] AddOn 'Masque' tried to call the protected function 'MultiBarRightButton11:Show()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function Show' FrameXML\ActionButton.lua:363: in function <FrameXML\ActionButton.lua:337> [C]: in function ActionButton_Update'
FrameXML\ActionButton.lua:812: in function `ActionButton_OnEvent'
FrameXML\ActionButton.lua:252: in function <FrameXML\ActionButton.lua:244>

Locals:

Please add regions for artifact and azerite item display. Blizzard's container item buttons, for example, call these regions .IconBorder and .IconOverlay. It seems they intend to use .IconOverlay for future item types.

Hi StormFX,

I've tested the latest alpha version and as soon as I enabled Masque I get a lot of error including stack overflow errors and the game freezes when icons or frames are shown where Masque is activated.
If I disable Masque the errors are gone.

Just as an additional information:
I am using the Masque:Caith skin with the following addons being skinned:

AdiButtonAuras
Bartender4
flyPlateBuffs
Raven
TellMeWhen

Thank you very much for your effort in advance.

Please see the errors in the code blocks:

2x OmniCC\core\display-Display.lua:216: stack overflow OmniCC\core\display-Display.lua:216: in function GetCooldownWithHighestPriority'
OmniCC\core\display-Display.lua:131: in function UpdatePrimaryCooldown' OmniCC\core\display-Display.lua:124: in function RemoveCooldown'
OmniCC\core\cooldown.lua:86: in function <OmniCC\core\cooldown.lua:82>
OmniCC\core\cooldown.lua:96: in function <OmniCC\core\cooldown.lua:92>
OmniCC\core\cooldown.lua:117: in function <OmniCC\core\cooldown.lua:114>
[C]: in function Hide' flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:420: in function <flyPlateBuffs\flyPlateBuffs.lua:415> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:685: in function <flyPlateBuffs\flyPlateBuffs.lua:620> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:708: in function <flyPlateBuffs\flyPlateBuffs.lua:701> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:960: in function func'
Masque\Core\Callback.lua:44: in function <Masque\Core\Callback.lua:37>
...
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:708: in function <flyPlateBuffs\flyPlateBuffs.lua:701>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:960: in function func' Masque\Core\Callback.lua:44: in function <Masque\Core\Callback.lua:37> Masque\Core\Group-Group.lua:59: in function <Masque\Core\Group.lua:52> Masque\Core\Group-Group.lua:192: in function ReSkin'
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:985: in function <flyPlateBuffs\flyPlateBuffs.lua:948>

Locals:
InCombatSkipped`

27x OmniCC\core\cooldown.lua:86: stack overflow OmniCC\core\cooldown.lua:86: in function <OmniCC\core\cooldown.lua:82> OmniCC\core\cooldown.lua:96: in function <OmniCC\core\cooldown.lua:92> OmniCC\core\cooldown.lua:117: in function <OmniCC\core\cooldown.lua:114> [C]: in function Hide'
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:420: in function <flyPlateBuffs\flyPlateBuffs.lua:415>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:685: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:708: in function <flyPlateBuffs\flyPlateBuffs.lua:701>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:960: in function func' Masque\Core\Callback.lua:44: in function <Masque\Core\Callback.lua:37> Masque\Core\Group-Group.lua:59: in function <Masque\Core\Group.lua:52> Masque\Core\Group-Group.lua:192: in function ReSkin'
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214>
...
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:708: in function <flyPlateBuffs\flyPlateBuffs.lua:701>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:960: in function func' Masque\Core\Callback.lua:44: in function <Masque\Core\Callback.lua:37> Masque\Core\Group-Group.lua:59: in function <Masque\Core\Group.lua:52> Masque\Core\Group-Group.lua:192: in function ReSkin'
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:985: in function <flyPlateBuffs\flyPlateBuffs.lua:948>

Locals:
InCombatSkipped`

2x OmniCC\core\timer.lua:197: stack overflow OmniCC\core\timer.lua:197: in function GetTimerText'
OmniCC\core\timer.lua:119: in function Update' OmniCC\core\timer.lua:65: in function GetOrCreate'
OmniCC\core\display-Display.lua:147: in function UpdateTimer' OmniCC\core\display-Display.lua:116: in function AddCooldown'
OmniCC\core\cooldown.lua:76: in function <OmniCC\core\cooldown.lua:67>
OmniCC\core\cooldown.lua:94: in function <OmniCC\core\cooldown.lua:92>
OmniCC\core\cooldown.lua:117: in function <OmniCC\core\cooldown.lua:114>
[C]: ?
[C]: in function SetCooldown' flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:453: in function <flyPlateBuffs\flyPlateBuffs.lua:415> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:685: in function <flyPlateBuffs\flyPlateBuffs.lua:620> ... flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:708: in function <flyPlateBuffs\flyPlateBuffs.lua:701> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:960: in function func'
Masque\Core\Callback.lua:44: in function <Masque\Core\Callback.lua:37>
Masque\Core\Group-Group.lua:59: in function <Masque\Core\Group.lua:52>
Masque\Core\Group-Group.lua:192: in function `ReSkin'
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:725: in function <flyPlateBuffs\flyPlateBuffs.lua:714>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:980: in function <flyPlateBuffs\flyPlateBuffs.lua:948>

Locals:
self =

29x OmniCC\core\cooldown.lua:93: stack overflow OmniCC\core\cooldown.lua:93: in function <OmniCC\core\cooldown.lua:92> OmniCC\core\cooldown.lua:117: in function <OmniCC\core\cooldown.lua:114> [C]: in function Hide'
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:420: in function <flyPlateBuffs\flyPlateBuffs.lua:415>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:685: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:708: in function <flyPlateBuffs\flyPlateBuffs.lua:701>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:960: in function func' Masque\Core\Callback.lua:44: in function <Masque\Core\Callback.lua:37> Masque\Core\Group-Group.lua:59: in function <Masque\Core\Group.lua:52> Masque\Core\Group-Group.lua:192: in function ReSkin'
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
...
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:708: in function <flyPlateBuffs\flyPlateBuffs.lua:701>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:960: in function func' Masque\Core\Callback.lua:44: in function <Masque\Core\Callback.lua:37> Masque\Core\Group-Group.lua:59: in function <Masque\Core\Group.lua:52> Masque\Core\Group-Group.lua:192: in function ReSkin'
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:725: in function <flyPlateBuffs\flyPlateBuffs.lua:714>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:980: in function <flyPlateBuffs\flyPlateBuffs.lua:948>

Locals:
cooldown = {
0 =
_occ_priority = 1
_occ_show = true
_occ_kind = "default"
_occ_duration = 5
_occ_start = 4775.842000
_occ_settings =

28x Masque\Core\Regions\Backdrop.lua:122: stack overflow Masque\Core\Regions\Backdrop.lua:122: in function func'
Masque\Core\Core.lua:127: in function <Masque\Core\Core.lua:124>
Masque\Core\Button.lua:84: in function <Masque\Core\Button.lua:59>
Masque\Core\Group-Group.lua:188: in function ReSkin' flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:708: in function <flyPlateBuffs\flyPlateBuffs.lua:701> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:960: in function func'
Masque\Core\Callback.lua:44: in function <Masque\Core\Callback.lua:37>
Masque\Core\Group-Group.lua:59: in function <Masque\Core\Group.lua:52>
Masque\Core\Group-Group.lua:192: in function ReSkin' flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214> ... flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:708: in function <flyPlateBuffs\flyPlateBuffs.lua:701> flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:960: in function func'
Masque\Core\Callback.lua:44: in function <Masque\Core\Callback.lua:37>
Masque\Core\Group-Group.lua:59: in function <Masque\Core\Group.lua:52>
Masque\Core\Group-Group.lua:192: in function `ReSkin'
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:259: in function <flyPlateBuffs\flyPlateBuffs.lua:214>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:698: in function <flyPlateBuffs\flyPlateBuffs.lua:620>
flyPlateBuffs\flyPlateBuffs-8.0.1.06.lua:985: in function <flyPlateBuffs\flyPlateBuffs.lua:948>

Locals:
Enabled = false
Button = {
0 =
__MSQ_Shape = "Square"
durationSize = 18
__MSQ_NormalHook = true
duration = 5
border = {
}
__MSQ_bType = "Button"
__MSQ_oType = "Button"
stacktext = {
}
expiration = 4780.842000
__MSQ_Normal = {
}
icon = 463284
texture = {
}
stackSize = 18
stackBg = {
}
id = 1
__MSQ_NormalSkin =

• Update the Classic ToC to 11307.

Add support for the Cooldown region's BlingTexture attribute so that skin authors can use custom textures. If possible, perhaps add an option for users to toggle this feature.

They are all colored based on what you have the equipped color set to. I can't find a way to fix this other than disabling the addon.

Make sure that the region defaults are updated to the latest client builds.

I installed Masque today to use it on WeakAuras. I applied Clean Icons - Square to my WeakAuras.
As you can see on the following picture it is working most of the time. But sometimes when new Auras (in this case - Buffs) appear masque is not applied to them. You can see that on the 14 seconds blue buff on the image.

Add a contributors page to the Wiki for those who help with localization, etc.

Masque currently has limited support for empty buttons. Expand this so that skins can specify different texture settings depending on whether the button is empty or not.

https://github.com/Zinoh/Masque/commit/09482effd86b29b4443bdb9f998d1c3d9dca75c5#diff-29640bbe49e3344125235d5c78a95054L155

Simple fix.

Also, is it intended that the chargeCooldown region only be usable by Action buttons? Due to the line above:

155: if bType ~= "Action" then return end

In my local copy I simply moved that line to below the chargeCooldown related stuff to test it out in my local copy of TellMeWhen (which hasn't updated to the new parameters yet so using the Legacy setting). Wasn't sure of your intention though.

A new feature was added that gives charged abilities their own cooldown. Masque should catch-and-resize those that use the native API and provide a method for those that don't.

WeakAuras is not only dynamically creating groups based on the installed auras, but also is reusing buttons. That is we have a pool of buttons that gets reused between different groups. I recently fixed that we never informed MSQ that a button moved to a new group.

But due to user reports of that leading to bugs, we need to revert that:
WeakAuras/WeakAuras2#1131

The user has configured masque to be globally disabled.

If I read the code correctly, what is happening is that on the RemoveButton (which was entirely superflous since AddButton does that already), the Button is skinned with a "Blizzard" skin.

This is typically not a problem since that skin would later be overriden by the correct skin.

Except if the new group is disabled.

This can be reproduced by with the above PR reverted, and with these two auras, which show the buffs on the player's target/focus. Applying buffs with/without target/focus should show the issues pretty much immediately.

!nBvuZjUnq4Fn9Xmd2hbsEmHyAOtodf5KR9fLtylB0eBjFwYqipC)27URSbooAA60x6mmeLvR2D1333UcEapHZSC2DYnCwfNLHFatfnMTG15FjMZEDEEUv64tVy84HdUC0WbdgpiC0OXxZZVy4LC2UEhUCu41xgmACWWbxf(PGRW9VIZe601MMfgL2XztIItIwcjTwKk5XHC2kr6lq(A1qYJnAjCGuNYOTuT5enoybCYCLwzx7xdl9wH1UgvrHSbDpMUpDgWLzYvT55j7QHOEF0dlM(4dW(0)kABeHyDillNLz9X12UsUrQDm4uQx5SNNCdl5zwYnlHG1IjLvxk2bbFVRlAKKRSfrpabNSbjtkkDR5mTOsA7R0w9HsZ5n1iYuTwahgmacPSmVdMsMVakXsvH(aK1yCcey4XGVLgbXuTw5ZPLcRLVIUmPOXQ2sNQpR(Dp1Qv9M8uJoKRuvcNKcwQOuIqkBLPjdVYE2PrwafHhtZ2bxqvksF1WjmaxX0KxYxRf6mzg)wOcaY0j0UPaXAG4S8M7M9iRpUDQN4GraVcAGPav3aWgWJcNGkaVcAkA1Nx2KLrrXK8GWterGSKRk884bn1mnfCy)wm4jB(ZR)TXlE6Q6)avrozJwu(eOEiCniGctMQx)HisRdY986JnrGeEIJuOSmqqHgF2RVSsms2E5gHkWzRek9h379A(pM)E(EFJqrj0fdmPt(QlyQbK1iPhheEONfbMZ2FMAmLzMTA2wfKaKeBTotvceQhRZqjcRT7V9UgLvqcN)DTVGagRZjMsqA0xSrAXQsV45fPS(guy7wIaaLG))I)WehRWH(sqXHBgXj4Nq67prFpe)21DN7iGBNNKm)ZlN9R3N43iezUPLIciBZFm5HzXrC2APQynqFJgEwfA)0H)7deoBpYrdQovVGcKJyp6cmbUaaSxrtgNfZMDxKhA8nZRADoJE(gzdmATdm(aGw6hXLdJe6QK)XZC84nfeGdpaI9kBvzWyDc23Zn(UQqKjkRx7NyTVL7uIJ2GZ(f7rbaM51OE77F93Bfz4mVV)1KKFEi4BgtLVFT1z2JTqOQ9ZnZnql6rz(8rLoupbT6DgTsoEcjtJqd)wRO6llUDR4juEa0ML06V37W21qFqj0KyPc)hEa(9EY9Kxt)BEZ9hFd)WtUDVy3bmN73cCMhLPXxBKjEJF2KbC7fbdOEbuoC7p)eH1PsFz3DDti2pe7CYEkdBaaAyiQ24)1d

!nBvxVjoou0Fn7JvIKY225rGgMbjMaloDhP9bZ4K4eSQJDuSdu6dZV99ETtGSSSDz1(YiHOP3C)YNZ5En0aAcLyOKN57PKkkjh)aMkB0haRR(wmL82QIcd3sNF3Jp9uq4J3)Rp(0Opn(HWhPf3n(bk5yNdXb3tjmv2oDZATqzPKzrXjrBGkuZY404qkjLL9kK8wfuPyTIdbKzfALX1iwwJfEaISqOeMD(NHh9wHNTnIYsEd6ESR57mGpMZtBlksowdz9lrlxp)LLW7D)lRTHfI9bxkxKB8510MY3ZvwceL4nkz7SjKKTKKjBGK1IfLulzhHKtuSkExuUqGcWzs7UZjzDd3LeY6OLlr)AvNBnRV5By5IwdGdJgbbYLfDWuYQ1qlkfLQZqwJ2YqGHgd(k1mhT0A4BZKmJHM6omzOXQwPv0Jp(3EPvJ4D(LgTixjQywUlzzmjhHusQUjhpYE2PHxcnHhtZpcWGidPVAicnWveLZl(B1mvopNof6aGmTmLDoqSAipBM88Ixi959Kub0ncqdanvrdaUapYSmxd4vqZrR(6sMTjkk2jpC4jIiqvkeLEg5SMAHYLC49TyYFAA(SnYpLoLeGQilVrXK)oOEC4AqGln5IE9hIiTwO2RQhAYbsyeduOKCqqHg361xgoMjtVCZHkqSvmH629(KM)283Z3NgekLWilWKw(B2G5AqwJKECq4Gb0r)dZNzATmxFqroiGcGKyRXQRsGu9sDokriTD)T31O8sNW5)24liGX(CMwcsJ(MnsXsLEXZRCE9euyB3GaGRa)8I)WghdZI(6GIZNmhNGFcDFFV77X432UZChbmDvsYQVUzXN)sI)fHiZnxYkHQT6LKLlIJOKDCr5oG(Ey8vvO9Bh()Vq4QZidwuDPEbfidyp3bygCaayVYTLCrmzXZrEOXpmN2ATA1Q98gy1AhyCdGw2T4Y5vcDDY)AmdxVjGeC(2oCw5GihwX7G9tCJFQkezcz9o)gRtJCxsCUxqj)IzqcOK5nI3)X3)TwwoUZ7hFp5klbFxRR8ZRTw9jSfsvTFVjmhuYTdk91tRlQEgk9d2T6C8cw2TdLuzN)hhMoE04jO(a4nJtS)rxeB2bdcsykX468)YnWF0DU30vRxCj(GBM9xz3Jmx7xdCLRLDlW2Zt8g)Qohy37cg5MgqbX0)(LegRi71Jp3TJ40ASRj8DvypGqJdr9g9p)

In the alpha, skins with borders are no longer creating the border on target frames. This includes:

• TellMeWhen (https://github.com/ascott18/TellMeWhen) - ascott18/TellMeWhen#1684
• https://github.com/ascott18/Masque-Skinner-Blizz-Buffs
• https://github.com/ascott18/Masque-Skinner-ShadowedUF
• Probably my two other "Masque Skinner" addons as well, although I don't use Pitbull or Zperl and so haven't tested them specifically

TellMeWhen above, ShadowedUF buffs left, Dominos below (which is working correctly); Using skin "Renaitre: Square":

Core/Regions/Normal.lua will throw an error if a generic frame is passed due to the opening line not first testing for the .GetNormalTexture method.