Feature Request: Item Button Artifact and Azerite Regions about masque HOT 15 CLOSED

From what I can tell from the code, it's only applicable to [inventory] item buttons. Does it display on an action button that has an equipped item on it? Do you have a screenshot of these regions in action? I don't actively play and from my understanding, I'd have to purchase the expansion and play awhile (to obtain the items) to even see it in action.

from masque.

Yeah, I also dont have the expansion, so I just hacked to API instead to force items in the netherweave bag to be artifact/azerite:

from masque.

The tooltips also change from looking at Blizz's code, but that doesnt really matter for us and I didn't hack that.

from masque.

I guess I shouldn't be surprised that they reused the jewel crafting corners, given that's basically all they've done (rehash rehashed content) for the last few expansions. :p I'm assuming that's the IconBorder, so what's the overlay do?

Is Blizzard's version is getting misplaced in the stack or something? I can't imagine skin authors wanting to customize that layer, but I've been wrong before.

from masque.

The bottom image is IconOverlay. It shows over the normal artwork and its used to mark azerite items.
The top image is IconBorder. It has been in the game since they started highlighting items by rarity. It is the normal quality colored artwork you see on the Supply Bag, and it is replaced by a different fancier texture, still colored by rarity, when an item is an artifact.

Basically they did a mess and implemented the two artworks in completely different manners. Looking at the code, they intend to use IconOverlay to apply different artworks to future special item types, instead of using the messier IconBorder system.

from masque.

So the top image, IconBorder, is the border that appears only on artifacts while normal items still use the old border without the corner trim, right? And IconOverlay isn't currently used?

from masque.

IconOverlay is currently used. It marks azerite items.
You are correct about IconBorder.

from masque.

Artifacts were all the rage last expansion. Azerite is all the rage this one.

from masque.

So, normal items still use the old border (rarity colors) and overlay (colored, blurred edges like on quest items) and it swaps the textures depending on if it's an artifact or Azerite item? IE, if it's Azerite, the Overlay is swapped to the JC-like texture and if it's an artifact, the Border is swapped to the other JC-like texture?

from masque.

Almost. If its Azerite the Overlay is swapped to the "Azerite Crystal" texture and shown (its normally a hidden layer). You got the artifact one right, which does texture swapping only and its not an independent layer.

from masque.

Well, it's normally hidden unless it's a quest item, or in this case, Azerite. :p Anyhow, it sounds like a mess. I'll have to look at it myself. I may add some static settings, but I doubt I'll be bothered with monitoring texture swaps.

from masque.

Sorry for the delay on this. A couple of things:

• Bagnon doesn't use the IconBorder region, it uses the Border region. I'm not sure if this is due to Masque not supporting the IconBorder or if it's just being reused.
• Only the size and offsets will be supported at the moment. The colors and textures are controlled by the game/add-on.

from masque.

• Yes, Bagnon just lets the default UI code "do its own thing" to the IconOverlay and IconBorder textures.
• Alright

from masque.

As I mentioned and if memory serves from my tests, Bagnon uses the Border region, not the IconBorder region. The default UI uses the IconBorder region.

from masque.

Ignore my previous comment. Bagnon actually uses a custom region. In any case, the latest alpha should address this, so closing.

from masque.