Bug: AddButton not Applying the Correct Skin about masque HOT 10 CLOSED

So the issue is that RemoveButton is bypassing the group's disabled state and applying the default skin when it shouldn't, right?

Edit: Since you seem to have a testing environment in place already, try the following:

Change this line in AddButton:

From:

						Parent:RemoveButton(Button)

to:

						ButtonData = ButtonData or Parent.Buttons[Button]
						Parent.Buttons[Button] = nil

The reskinning of the button in RemoveButton when called in AddButton is redundant. This should address that. It also allows for only the button to be passed when changing groups, as it pulls the ButtonData from the old group prior to the reassignment. This is just a quick fix to see if it fixes the issue. As I said in the other ticket, I'm in the middle of a rewrite so a permanent solution may be awhile.

from masque.

I've made a commit that should address this. I'll leave the ticket open until I get a release finished and it's live-tested.

from masque.

Sorry for not responding, I was trying to create a small test case of what we do, but somehow it didn't behave like I expected.

I just tested your actual commit, and with that it seems fine! Thanks!

from masque.

Any idea when you are going to do a release?

from masque.

I'm rewriting a lot of it in my spare time, but I've got quite a bit of it finished. I'd say I'm about 70-75% done. Hopefully, within the next two weeks, if everything goes well.

from masque.

Please do tell us before a release, and we can arrange a bit of testing on our discord.

from masque.

Will do.

from masque.

I've released an alpha for testing purposes. I still have some improvements to make, but at least this will get some of the stuff I needed to do out of the way.

from masque.

I just tested this alpha and it seemed to work nicely. Once that masque version is out, I intend to commit something like InfusOnWoW/WeakAuras2@85bfb2a to WeakAuras.

Note, that not every aura currently has a uniqueId, so we won't be using staticIds for all auras yet, but that's coming at some point.

from masque.

Since this issue is resolved, I'm going to close this. If you run into an issues, let me know.

from masque.