Now, if change to light mode : <a target="_blank" rel="noopener noreferrer nofollo

Nice! <g-emoji class="g-emoji" alias="smile" fallback-src="https://github.githubassets

Color Matters (e.g. support light mode) about egui_node_graph HOT 5 CLOSED

setzer22 commented on July 23, 2024

Color Matters (e.g. support light mode)

from egui_node_graph.

Comments (5)

setzer22 commented on July 23, 2024 1

This is pretty nice! Thanks for taking the time

Personally I like the colors, it feels like it has enough contrast and is similar to the original theme. Could you submit this as a pull request? 😄

change the color of connections for each data type

This can be implemented in several ways. I think the most flexible option is to pass an immutable reference to the UserState in the data_type_color method here:

egui_node_graph/egui_node_graph/src/traits.rs

Lines 10 to 19 in c6c5176

 /// This trait must be implemented by the `DataType` generic parameter of the 

 /// [`Graph`]. This trait tells the library how to visually expose data types 

 /// to the user. 

 pub trait DataTypeTrait: PartialEq + Eq { 

 // The associated port color of this datatype 

 fn data_type_color(&self) -> egui::Color32; 

 // The name of this datatype 

 fn name(&self) -> &str; 

 }

This would only allow customization beyond egui's light / dark theme, for users that have other kinds of needs.

make it possible to specify the background color of title for each node template

I think it's more flexible if we make the titlebar color a property of the node itself, not its template. This allows more custom behavior in case someone needs it (like, I don't know, a color picker node having the same color in the titlebar 🤔. This would be possible by adding a titlebar_color method here:

egui_node_graph/egui_node_graph/src/traits.rs

Lines 21 to 26 in c6c5176

 /// This trait must be implemented for the `NodeData` generic parameter of the 

 /// [`Graph`]. This trait allows customizing some aspects of the node drawing. 

 pub trait NodeDataTrait 

 where 

 Self: Sized, 

 {

Is this something you'd enjoy working on? I can take a look at it, but since you're already halfway there with the color changes I think it'd make sense if you want to tackle it :)

from egui_node_graph.

setzer22 commented on July 23, 2024 1

Nice! 😄 Looking forward to it

from egui_node_graph.

setzer22 commented on July 23, 2024 1

With your latest changes, I think we can now close this. Thanks again! 🎉

from egui_node_graph.

kkngsm commented on July 23, 2024

I would like to suggest other color-related functions.

change the color of connections for each data type.
make it possible to specify the background color of title for each node template.

from egui_node_graph.

kkngsm commented on July 23, 2024

make it possible to specify the background color of title for each node template

I think it's more flexible if we make the titlebar color a property of the node itself, not its template.

Indeed, your idea is great.
I am implementing this now.

from egui_node_graph.

Color Matters (e.g. support light mode) about egui_node_graph HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	/// This trait must be implemented by the `DataType` generic parameter of the
	/// [`Graph`]. This trait tells the library how to visually expose data types
	/// to the user.
	pub trait DataTypeTrait: PartialEq + Eq {
	// The associated port color of this datatype
	fn data_type_color(&self) -> egui::Color32;

	// The name of this datatype
	fn name(&self) -> &str;
	}

	/// This trait must be implemented for the `NodeData` generic parameter of the
	/// [`Graph`]. This trait allows customizing some aspects of the node drawing.
	pub trait NodeDataTrait
	where
	Self: Sized,
	{