runway20 / popoverview Goto Github PK

The popover view does not render the background correctly on iOS 4 (tested on 4.3.5 iPhone 3GS).

This class is brilliant, however I've been struggling to get it working in multiple orientations; show a popover in portrait mode, rotate to landscape mode and it's nowhere near the point that I originally specified.

I've tried setting the autoresizingMask to have flexible left/top margins but this doesn't seem to work either.

I've also tried dismissing the popover then calling one of the show... methods again in response to an orientation event but this seems to result in the popover disappearing completely.

Any assistance would be greatly appreciated :)

The line below (to get the topView) returns the DCIntrospect window instead of the application's window. I realize that DCIntrospect is kind of a unique-purpose tool and the conflict won't arise in production because DCIntrospect should never be used in production, but just wanted to give people a heads up in case they had issues with the Popover not showing. No error is thrown, just found it by tracing through the code.

  // get the top view
// http://stackoverflow.com/questions/3843411/getting-reference-to-the-top-most-view-window-in-ios-application/8045804#8045804
 topView = [[[[UIApplication sharedApplication] keyWindow] subviews] lastObject];

There is an issue where if someone were to double tap on a cell where PopoverView is being used it will sometimes generate two instances of PopoverView. (One per tap) which will cause the application to crash... Is there a way to enforce only one PopoverView to be open at one time?

Here is the current code I am using in - (void)tableView:(UITableView *)TableView
didSelectRowAtIndexPath:(NSIndexPath *)indexPath

[PopoverView showPopoverAtPoint:cell.center inView:self.view withTitle:title withContentView:sti.view delegate:self];

"...full blog post" link (http://blog.getsherpa.com/blog/2012/09/14/popoverview-a-flexible-modal-content-view-for-ios/) is broken:

404 Not Found

Code: NoSuchKey
Message: The specified key does not exist.
Key: blog/2012/09/14/popoverview-a-flexible-modal-content-view-for-ios/index.html
RequestId: D7C4DD86CCBDBC14
HostId: bxXuqQuubNRnJcjM9kIEQbuy40Q3Ia2QBLXxwGvuRf2tFu5GIHjufMndydLzQrzj

An Error Occurred While Attempting to Retrieve a Custom Error Document

Code: NoSuchKey
Message: The specified key does not exist.
Key: error.html

My content view is a UIViewController contains a UITableView, the cell is clickable, but the table view is not scrollable. It just crash, without any helpful information.

Crash when popoverView dismiss! I use ios sdk is 6.0 version.(my english is bad, i hope you understand..,thank you very much!!)
Crash message:
Thread 1
com.apple.main-thread
0CA::Layer::commit_if_needed(CA::Transaction_,void(),(CA::Layer,unsigned int, unsigned int ,void), void_)

Code:
UIButton *btn = (UIButton *)sender;
NSString *text = @"这是闲暇做的小应用,提供给大家免费使用。QQ:410139419。";
[PopoverView showPopoverAtPoint:btn.center inView:self.view withText:text delegate:nil];

Don't support scroll when there're many items.

The popover view is not responding for the touch events. The "didSelectItemAtIndex" is not been called. I'm using ARC.

is it possible to make it looks like the one in the picture

http://www.iphone3gsystem.fr/wp-content/uploads/2012/11/eurosport.jpg

Hello, i have tried your PopoverView project today, and i think is really great! I have a question about it, there is a way to insert a UIScrollView with UIImageView?...i want insert in it some Image download from the web and loaded runtime when the user swipe left or right in the PopoverView...it's possible?

Popover views don't always orient themselves as expected. In situations where the application is not using auto rotate to handle orientation changes, popoverview opens in portrait regardless of the device's actual orientation. Apple's built-in UIPopoverController resolves this by basing it's orientation on that of the status bar. Can this be altered to do the same? Or alternatively, maybe an additional optional delegate method could be added that would allow us to override the default orientation if desired?

Thanks, and fantastic job on this. Very nicely done.

Can we don't disable the other gestures when the popover is showing and automatically dismiss the popover if the user taps on other spot or scroll the tableview.

Thanks
Jake

A popoverview may be added to a hud view when displaying. Cause it is appended to the top window. The problem is in some case a singleton hud view could always be interacted by a popoverview.

The topView in showAtPoint:inView:withContentView: may lead to a hidden view.

Maybe this works better ?

NSArray* windowViews = [[[UIApplication sharedApplication] keyWindow] subviews];
for (int i = windowViews.count - 1; i >= 0 ; i--)
{
topView = [windowViews objectAtIndex:i];
if (!topView.isHidden)
break;
}


when I press button a little quick, e.g. double click……
then the popover may overlay and can not dismiss.

after all, I use some flag to avoid this happen.
-(void)structTypeBtnClick:(UIButton*)sender{
_typeBtn = sender;
if (_typeBtn.selected) {
return;
}

[PopoverView showPopoverAtPoint:CGPointMake(530, 960) inView:self.view withContentView:_switchControl delegate:self];
_typeBtn.selected=YES;

}

but, There must be a better way to resolve this issue.

Hi,

I'm having a problem when adding a UITableView to the popoverView. The TableView is showing properly, but the first tap on it is lost (the didDeselectRowAtIndexPath method is not being called).

After the first tap on the table, it works as is intended (the didDeselectRowAtIndexPath method is called normally).

This is the code I'm using:

self.myTable = [[UITableView alloc] initWithFrame:CGRectMake(0, 0, 240, 120)];
self.myTable.delegate = self;
self.myTable.dataSource = self;

self.pv = [PopoverView showPopoverAtPoint:CGPointMake(40, 40)
                                   inView:self.view
                          withContentView:self.myTable
                                 delegate:self];

I tried adding the didDeselectRowAtIndexPath method on the example included and it presents the same behaviour.

I'm also using the component to show a custom calendar view and it works like a charm.

I found a bug when we try inserting a UITableView from a nib file. I tried to do this:

[[NSBundle mainBundle] loadNibNamed:@"MyTableViewNib" owner:self options:nil]; //My .xib file with UITableView inside it
UITableView *myTableView = [nibs objectAtIndex:0]; //Assuming the tableview is the unique object from the nib
[PopoverView showPopoverAtPoint:CGPointMake(0, 0) inView:self.view withTitle:nil withContentView:myTableView delegate:nil]

The size of the table doubles for unknown reason. The size of container is right.

Screenshot: http://img.photobucket.com/albums/v502/alessandro_ufms/Popoverbug.png

Many projects have this very common name already in their project. Perhaps prefix it R20, e.g. R20PopoverView?

Currently the only way to dismiss the popover is to tap above our to the left of the popover. Is there a way to allow for dismissal by tapping below the popover? I tried to changing the UIControlEventTouchUpInside but that didn't work. Any ideas? Thanks!

Line 275 states:

if([view isKindOfClass:[UILabel class]]) {
        //Now make sure all the labels are the full width
        view.frame = CGRectMake(view.frame.origin.x, view.frame.origin.y, totalWidth, view.frame.size.height);
}

But I believe that it shouldn't be checked to be a UILabel unless it is intended to only be used with labels (which makes the method name misleading). I've found that replacing all 3 of those lines with the following works as I believe was intended:

view.frame = CGRectMake(view.frame.origin.x, totalHeight, totalWidth, view.frame.size.height);

Hello!
PopoverView looks great and we'd really like to use it. However, wherever I add it to our app it crashes with a runtime error during

• (void)showAtPoint:(CGPoint)point inView:(UIView *)view withContentView:(UIView *)cView

The crash happens at this line:
self.frame = topViewBounds;

-> Terminating app due to uncaught exception 'CALayerInvalidGeometry', reason: 'CALayer position contains NaN: [nan nan]'

An NSLog I created above that line retrieves:
Frame: X=nan Y=nan W=0.0 H=0.0 - TopViewBounds: X=0.0 Y=0.0 W=0.0 H=0.0

It seems like there is something wrong with creating the PopoverView's frame.

Running in iOS 5 and iOS6 Simulator.

I appreciate any ideas and help!

This is related to Issue #4 - unfortunately PopoverView does not support being displayed on an already rotated view.

Is this being planned/worked on? Otherwise I might give it a stab.

The Clang analyzer found some leaks in PopoverView.m. It looks like just autoreleasing those three items fixes the problem, but wanted to bring it up before assuming they were actually leaks.

If you run the Xcode analyzer on the files you'll see the leaks. Take a look and let me know what you think.

The popover view is not responding for the touch events. The "didSelectItemAtIndex" on ios6, it only responds for index 0, all items above index 0 don't work when you click on them

I tried to update CocoaPods myself, but they want the push to come from the original repo.

The PopoverView.podspec file in runway20/PopoverView looks like it has been updated, but it refers to a different repo (cocoa-factory/PopoverView) and a tag ("0.0.2") that only exists on that other repo.

Some instrux here: https://github.com/CocoaPods/CocoaPods/wiki/Contributing-to-the-master-repo#sharing-podspecs

And discussion on my push attempt here: CocoaPods/Specs#3672

Thank you!

I can not find the interface to setting it ,just for help ,thinks.

Hi.

Had a problem working with table view in PopOvover. (with latest code)
Resolved by adding changes in this code in your class

//Add a tap gesture recognizer to the large invisible view (self), which will detect taps anywhere on the screen.
UITapGestureRecognizer *tap = [[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(tapped:)];
tap.cancelsTouchesInView = NO;// we need this to add possability to enable working witht able view
[self addGestureRecognizer:tap];
[tap release];

Actually there is only one line was added :
tap.cancelsTouchesInView = NO;// we need this to add possability to enable working witht able view

Really hope this will be useful fro you.

Thanks for you Class!!!

So I'm not sure if any others have experienced this, but reading through other posts I didn't find anything that was exact.

Currently I have a project that uses a splitViewController. When in landscape I can tap a button in the mainView (leftside view) and the popupView shows up just as expected. However, if I rotate to portrait, swipe right to display the mainView on top of the detailView, then tap the same button the popupView appears behind the mainView on the detailView. If I slide the mainView out of the way the popupView remains there on the detailView.

Any help with this would be great. I'll mess around with things a bit to see if I can fix on my own, just thought I'd mention here.

Thanks!