Giter Club home page Giter Club logo

Comments (6)

ocrickard avatar ocrickard commented on August 29, 2024

Hey, yeah, this is actually the second or third time this has come up. We have struggled to find different ways to fix it, and the only good one that I came up with was adding a totally new window. I have a different branch on my local machine that has that code, though according to one of our peers here (sorry, it would take me awhile to find who) said it has problems with rotation. I'll try to push the branch to github today so you can take a look.

from popoverview.

ocrickard avatar ocrickard commented on August 29, 2024

Looks like I already pushed it: https://github.com/runway20/PopoverView/tree/New-Window

Let me know if this works for you. If it does, maybe I can spend some time in the next couple weeks configuring the rotation support properly.

from popoverview.

jai avatar jai commented on August 29, 2024

Sure will check it out. Thanks for the great work by the way! I also semi-hacked a version of the PopoverView into a full-width popover. It 'kinda' supports rotation (dismisses when rotated but you can re-show it in landscape and it will resize to fit screen). It's really dirty but you can check it out in our beta app, in the photo gallery page (the comments popup): http://i.zodiobeta.com - currently a lot of the resizing happens outside the PopoverView class so I can't push it up yet, still trying to clean it up.

from popoverview.

ocrickard avatar ocrickard commented on August 29, 2024

Nice, I'll check that out! I certainly didn't write the component with rotation in mind (the app I've spent the last year on is iPhone portrait only), so it's a real challenge to get it working right.

from popoverview.

jai avatar jai commented on August 29, 2024

Yeah I just need to find a way to make it dynamically redraw instead of forcibly resizing it from the outside. Also supporting keyboard appearing/disappearing at the same time isn't fun. Any comments on the app are appreciated, and thanks again!

from popoverview.

ocrickard avatar ocrickard commented on August 29, 2024

Interesting. I'll leave comments through your feedback system so it's not here on GitHub. If you get a clean branch ready, we can talk about merging changes.

from popoverview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.