Giter Club home page Giter Club logo

Comments (6)

gavanderhoorn avatar gavanderhoorn commented on September 21, 2024

This also came up over at abb_experimental: ros-industrial/abb_experimental#129.

And nit-picking, but:

there's no real dependency on it for the actual content of this repository that only has support packages but nothing related to control

is not entirely true.

All support packages come with .launch files which depend on abb_driver.

We can remove it all, but that will require someone to write documentation/tutorials to explain how users are supposed to create .launch files for their robots.

We see the same thing in kuka_experimental: there support packages do not come with any .launch files other than load_...launch and test_...launch, and every so often questions are posted / emailed about how to "control real robots".

from abb.

gavanderhoorn avatar gavanderhoorn commented on September 21, 2024

And another related discussion: ros-industrial/ros_industrial_issues#50 -- with a potential approach to at least notifying users as to why the provided .launch files don't work if they don't install abb_driver (or RViz in that case).

from abb.

gonzalocasas avatar gonzalocasas commented on September 21, 2024

I see. The options discussed in the rviz one are interesting. I would have assumed that adding a little comment to the launch file saying <!-- Make sure rviz is installed to use this launch file --> would suffice. I think the same applies here, this doesn't need to be overengineered, a simple note inside these files should be enough. But if you think that's not a viable option, feel free to close this.

from abb.

gavanderhoorn avatar gavanderhoorn commented on September 21, 2024

I'll release abb_driver for Noetic.

That should take care of this.

I agree with you the dependency is unfortunate.

At least with any ROS 2 packages, we (I) won't be making that mistake again.

from abb.

gonzalocasas avatar gonzalocasas commented on September 21, 2024

Thanks!

from abb.

gavanderhoorn avatar gavanderhoorn commented on September 21, 2024

Done.

Should be part of the next sync.

from abb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.