pdil / pdcolorpicker Goto Github PK

There should be an alpha slider in addition to the hue slider to allow user to change transparency of color.

To-Do

• Create generic "slider" class
  • Name: PDColorPickerSliderView
  • Allow initializer to define what color component the slider represents
  • Define background color or view to display when the transparency is less than 1.0
• Create generic slider delegate protocol
  • Transmits whatever the changeable value is to the protocol implementer when changed
  • For example:

    protocol PDColorPickerSliderViewDelegate: class {
      func valueChanged(in slider: PDColorPickerSliderView, to newValue: CGFloat)
    }
    

• Replace PDColorPickerViewController layout code with vertical UIStackView (brightness/saturation slider, hue slider, alpha slider) for easier management
• Provide property in PDColorPickerViewController to display or hide alpha slider
  • If hidden, default of 1.0 is used
  • Possibly provide ability to set a different default alpha while still hiding the alpha slider?

Add property (allowsDragAndDrop) to PDColorPickerViewController that either enables or disables the ability to drag the color preview on iPad running iOS 11.0+.

Example:

public var allowsDragAndDrop: Bool {
  didSet {
    if allowsDragAndDrop {
      // enable
    } else {
      // disable
    }
  }
}

The restructuring/renaming of files and folders in the repo is causing the Travis build to fail due to the incorrect TEST_HOST name.

Expected behavior

can build properly in swift 4.2

Actual behavior

Cannot override mutable property with read-only property 'state'

Steps to reproduce behavior

pod install & after that build the project.

===

• Xcode version: 10.0
• iOS version:
• Device(s):

• Conform to CustomStringConvertible instead of manually creating a description string.
• Allow retrieval of red, green, blue values (in addition to hue, saturation, brightness).
• Better safety in init(fromString:)
  • Check for proper string format
  • Check that all components exist (perhaps allow 3 components with default alpha of 1.0)

Expected behavior

• I would like to be able to publish new branches and create pull requests.

Actual behavior

• I'm getting the current error:

Authentication failed. You may not have permission to access the repository or the repository may have been archived. Open preferences and verify that you're signed in with an account that has permission to access this repository.

Steps to reproduce behavior

• Try to push a brach from GitHubDesktop

Rotating the device causes the dimming view to not display correctly since its frame is set at presentation time. This can possibly be fixed by using AutoLayout in the Dimmable protocol.

All public facing classes, methods, and properties should have properly formatted documentation describing usage, parameters, and return values (where applicable).