Failed to run(linux nogui with xvfb+virtualgl) after 1.1.36 update. about mapshot HOT 4 OPEN

Sorry to hear that it breaks - that being said, it is largely outside my control, so I don't have any useful suggestion I'm afraid.

If I follow correctly, the presence of mapshot mod makes it crash in the xvfb case. Assuming that mapshot is indeed called automatically in that case to create a snapshot, I can imagine it makes sense - calling tons of take_screenshot is more likely to hit rendering corner cases. Though if mapshot is just loaded without issuing a screenshot though it would be weird - the mod basically does nothing in that case.

from mapshot.

Thanks for your notice and advice, I'll try to solve this, will report what I find.

from mapshot.

I tested more on windows and X window in CLI mode, with all other mods removed, similar error and crash log, so I guess it's not caused by xvfb, nor by other mods.
When using mapshot mod in game console, it works correctly.

From the crash log, it seems that it's caused by factorio not being able to reach base mod files in mapshot temporary working dir (CLI mode).
Digging further into crash log and 1.1.36 patch note, I found that it might relate to a bugfix about base mod and --disable-prototype-history:

*Fixed crash when starting game without base mod and with --disable-prototype-history. more
https://forums.factorio.com/98968

So I guess --disable-prototype-history caused factorio failing to reach base mod files in mapshot temporary working dir(CLI mode) after 1.1.36 update.

I tried to remove default "--disable-prototype-history" from mapshot render.go source and rebuild, it worked successfully(albeit much slower) after removing --disable-prototype-history argument.

Still I don't know why factorio cannot reach base mod file in temporary working dir with "--disable-prototype-history" in 1.1.36.

Hope my findings help, thanks for your time.

from mapshot.

That is great, thanks for the investigation, good work!
I don't have time right now to do a proper fix, so for now I've updated the README to refer to your findings & workaround.

I'm not sure what I will do here. Maybe at least I'll add a flag to fiddle with the default parameters - that would allow to work around the issue without having to rebuild.

from mapshot.