Comments (3)
Please make separate issues for separate complaints :)
support just has special significance, so it gets a special name, and a
special order. it's equivalent to "a". b/c/d are just there for
reference, and don't need to be prioritized in the order.
the variables have different styles because they come from different
places. I guess I will switch everything to camelCase, since it bothers
you so much.
The abbreviation is worth saving 1 character because these are
interactively explored in R, where space counts, and "rank" is repeated
5 times, so it saves me 5 width characters on a display output, which is
always limited by the column name. It seemed, and still seems, worth it
to me.
On 04/20/2015 03:17 PM, Florian Halbritter wrote:
I think you should re-think the names of some of the output columns:
- why are the four cells of the contingency table called /support/,
/b/, /c/, and /d/? why do they not appear together in the table
order? --> consider renaming all columns with meaningful variables
names or prefix them, e.g. by /cont/ to make clear they're
conceptually linked- you're using a mix of camelCase and hyphenated variables. ouch.
/userSet/, /dbSet/, etc. vs. cell-type, /data-source/, etc.- for abbreviations that save only one symbol, I sometimes wonder
whether it's really necessary to abbreviate them at all, e.g.
/rnkSup/ (/rankSup/, or even /rankSupport/ (?)), /maxRnk/
(/maxRank/), etc.—
Reply to this email directly or view it on GitHub
#5.
from lola.
Ok, separate issues in future. Mind you, these are not "complaints", but rather suggestions.
I can think of very few cases where "b", "c", "d" make acceptable variable names.
Thank you. I understand they come from different places, but since you're in control of all places, why not standardize them? Or, if you choose to have different naming conventions for annotation files, and for within R, convert between them as necessary.
Righto. In that case I'd vote for going 100% teenager. usrSet, dbSet, dscr, pValLog, suprt, fName, ... I've just saved you another 15 characters or thereabout.
Just joking, ignore the last point.
from lola.
I propose that the case where c, b, and d correspond to variables in a statistical model) is exactly such a case where they are acceptable variable names.
from lola.
Related Issues (20)
- hg38 database HOT 1
- Add in missing cellType/antibody entries for encodeTFBSmm10 HOT 6
- Re-order result columns
- Different results between LOLAweb interactive server and local R package HOT 7
- Inclusion of mm10 JASAPR prediction track into LOLA JASPAR HOT 3
- cistrome_mm10 HOT 2
- runLOLA results table for PEP databases
- PEP file read caching HOT 2
- Can't load an example regionDB. HOT 3
- PEP tag system
- testing for enrichment of significant individual cpgs HOT 2
- Error if GRangesList has names HOT 2
- question: how to test two region sets for differential enrichment with buildRestrictedUniverse? HOT 2
- Each of the 2 combined objects has sequence levels not in the other: HOT 4
- R package error HOT 4
- LOLA runLOLA-regionDB to use for tissue-specific TFBS
- P4 tool not grouping according to the paper!!
- Error by using extractEnrichmentOverlap function
- Fisher test - two sided hypothesis
- Error when trying to load a regionDB
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lola.