node-ci / nci Goto Github PK

As in the title, is it possible to have success and failure notifications integrated with third party services? I am specifically interested in Slack integration.

Hey there,

I am very excited by the idea of a CI server written in Node.js and would love to contribute if that would be of any use? Only thing is, I have no idea how I am supposed to use it?

Any pointers to get started firing it up?

Cheers,

James

Hi. I'm curious, if there is a simple way to catch GitHub's webhook and run build? As I see, your REST API is expecting valid project field, which is missing in the webhook payload. Any suggestions are welcome.

Thanks for this awesome CI Server. I want to contribute to it because I want to use it for one of my projects.
I suggest to update and refactor code to ES6 style. It's more clear and more robust. (This could be done with lebab )
I think it would be better to provide also a Promise-based API (Using async/await ?) (we could conserve a compatibility with callback api) this could make the code base more clear by removing the usage of twostep

After running git clone https://github.com/node-ci/nci-quick-setup && cd nci-quick-setup && npm install
and node_modules/.bin/nci I get the following error:

/nci-quick-setup/node_modules/nci/app.js:255
        if (err) throw err;
                 ^

Error: Cannot find module './node_modules/data.io/lib/server'
    at Function.Module._resolveFilename (module.js:339:15)
    at Function.Module._load (module.js:290:25)
    at Module.require (module.js:367:17)
    at require (internal/module.js:16:19)
    at Object.<anonymous> (/home/orehov/Downloads/nci-quick-setup/node_modules/nci-classic-ui/dataio.js:4:11)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)

Running npm install data.io fixes the problem.

It is more of a suggestion. Maybe it would be better to limit the changes list to maybe last 100 commits. I am building the Linux kernel using nci and just retrieving the changes list takes like several minutes. left alone that amount of information on the screen becomes unmanageable. I would suggest having some kind of a "Show more" button which will then load all of the log messages.

One day the build process hung in step "get sources" on command "git fetch". But I could not cancel it:

Fri, 07 Sep 2018 10:27:27 GMT] [resources error handler] Error is occurred during requesting /builds cancel: Error: Can`t cancel build: no current cmd
    at Group.self.canceled (/home/dmitry/WebstormProjects/nci-app/node_modules/nci/lib/executor/base.js:279:11)
    at Group.<anonymous> (/home/dmitry/WebstormProjects/nci-app/node_modules/twostep/lib/twoStep.js:171:15)
    at next (/home/dmitry/WebstormProjects/nci-app/node_modules/twostep/lib/twoStep.js:159:9)
    at iterateSteps (/home/dmitry/WebstormProjects/nci-app/node_modules/twostep/lib/twoStep.js:164:7)
    at /home/dmitry/WebstormProjects/nci-app/node_modules/twostep/lib/twoStep.js:129:3
    at /home/dmitry/WebstormProjects/nci-app/node_modules/twostep/lib/twoStep.js:187:32
    at Executor.cancel (/home/dmitry/WebstormProjects/nci-app/node_modules/nci/lib/executor/base.js:275:2)
    at Group.<anonymous> (/home/dmitry/WebstormProjects/nci-app/node_modules/nci/lib/distributor.js:504:14)
    at Group.<anonymous> (/home/dmitry/WebstormProjects/nci-app/node_modules/twostep/lib/twoStep.js:171:15)
    at next (/home/dmitry/WebstormProjects/nci-app/node_modules/twostep/lib/twoStep.js:159:9)

NCI cancel method works with self.currentCmd which declared only in project configuration steps

Hi, I'd love to have ability to run scripts without scm since I do scm management in my scripts and I only need nci as a runner. Is it possible to do so?

It happens when I have two opened pages: "main" builds page and some project page. When I initiate a new build from the project page, "Show more builds" button disappears on the main builds page.

I think the git scm could use NodeGit, this would make the code clearer and remove all git command output parsing

I think this flag should only skip build if there are no changes. But it looks like if the withScmChangesOnly is false, nci doesn't even update the repo to find out whether the latter has any changes.

In particular, I have a problem with git webhook, where I can't set withScmChangesOnly flag at all (it's always false). So it always rebuilds old version when webhook is triggered (builds from scheduler are okay, though)