Comments (8)
withScmChangesOnly flag doesn't prevent pulling from repository.
nci tries to get new changes and then skip build if only withScmChangesOnly is true and no scm changes.
There should another reason e.g. maybe it's wrong hook and when nci checks for changes they are absent.
from nci.
Well, I assumed this from this line of code
Also nci-base-webhook
just does builds.create, and I clearly see that builds triggered by user do git pull
and builds triggered by scheduler too. But not builds from webhook.
Any other pointers? Should I close this one and open an issue in nci-base-webhook?
from nci.
Scheduler also does only builds.create
I just checked github-webhook:
git pull
works fine
from nci.
Okay, here are three builds:
- This one is initiated from webhook and is wrong: http://mglawica.org:7000/builds/38 The message
package verwalter-render-0.3.4-3-g94dfaba-amd64 is already in repository
means we have already built it (you can see the whole log at the link). The version is got fromgit describe
in the build - This one is a subsequent from the scheduler: http://mglawica.org:7000/builds/39 which builds an new version and shows the changelog
- This one has been done yesterday, so you can see that it has a revision
94dfaba
from error message in build 38 linked above: http://mglawica.org:7000/builds/37
In github logs I see hook with code 200 that initiated the build, webhook request content follows. Headers:
Request URL: http://mglawica.org:7000/webhooks/verwalter/github/xxxx
Request method: POST
content-type: application/json
Expect:
User-Agent: GitHub-Hookshot/0b0c52f
X-GitHub-Delivery: 34db4680-33bd-11e6-95f2-f0a6c5e21353
X-GitHub-Event: push
Body (partial, note revisions):
{
"ref": "refs/heads/master",
"before": "94dfabaf8baf45ad9490dea68c5c403b233b4980",
"after": "2b8c9557e444ea6dc98b670f1086b9524d93f4cf",
...
The only issue I see at github log is the following "push" event with a tag, which returns error code 406. I assume that it's fine.
from nci.
Well, there is a git pull
in the log, so I'm not sure what the issue here. Maybe it tries to pull too fast? I.e. we need to sleep a little? :) Any ideas how to debug the issue?
from nci.
@tailhook could you check that with latest nci (1.0.9 currently)?
Some things changed, especially the way nci implements work with git scm.
from nci.
Yes, it works now. Not sure since what version, but I'm closing it anyway.
from nci.
from nci.
Related Issues (12)
- Can't figure out how to use this... HOT 3
- Integration with GitHub or Bitbucket HOT 2
- should ignore files like .DS_Store in data/projects HOT 2
- [Suggestion] Update code style to ES6 HOT 6
- [Suggestion] Use NodeGit for Git SCM HOT 1
- Builds without scm HOT 4
- [Bug] Cancel build in "get sources" step HOT 1
- "Show more builds" button disappears HOT 1
- Notify X when build failed or succeeded (hooks) HOT 4
- Missing data.io dependency HOT 8
- Limit the changes list on the first build HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nci.