In GitLab by @azul on Jun 15, 2020, 16:58

Currently image files are listed among the wikis and the app even tries to open them.

In GitLab by @azul on May 28, 2020, 14:48

no need for a trash on every page item.

In GitLab by @azul on May 18, 2020, 11:50

Apparently, make doesn't pull nodejs-webpack.

In GitLab by @azul on May 28, 2020, 14:49

In GitLab by @azul on May 28, 2020, 14:49

Make it editable on click.

In GitLab by @azul on May 18, 2020, 16:04

Currently we simply fetch all the markdown for all wikis in one go.
We probably want to reduce this so large numbers of wiki pages are possible without too much aditional trafic.

For #17 it would be good if we can fetch markdown for a single wiki or maybe a list of wikis as well.

The app currently still creates an empty database table (see lib/Migration/Version000000Date20200323224230.php) and it also still has code to store pages in the database (lib/Db/PageMapper.php).

The latter should be removed for sure. For the former, either we should update it to provide a metadata cache (see the Notes app for example) or completely remove all database-related code for now.

In GitLab by @azul on May 28, 2020, 08:24

In order to make use of images in the same folder it would be great if we could use relative links.
Ideally we'd fix this in nextcloud text itself.
Luckily there's already a pull request for it.

Follow up on the pull request and make it work.

As this is a complex topic especially taking into account access rights etc. try to focus on the basic rendering for now.

• get back to julius in the pull request - propose to focus on display only first
• rebase the pull request
• try it out
• fix whatever is missing

In GitLab by @azul on Jul 30, 2020, 17:43

Click on plus sign and "Create a wiki... " opens breadcrumb with wiki name entry

Currently we use the rack-wheel commonly used for settings as icon for our app. We certainly need to find a better alternative.

Probably something from fontawesome would work as a starter. Some ideas:

My favourites:

• https://fontawesome.com/v4.7.0/icon/umbrella
• https://fontawesome.com/v4.7.0/icon/star-half-o
• https://fontawesome.com/v4.7.0/icon/bolt
• https://fontawesome.com/v4.7.0/icon/cubes
• https://fontawesome.com/v4.7.0/icon/paw
• https://fontawesome.com/v4.7.0/icon/fast-forward

Related to text/wiki:

• https://fontawesome.com/v4.7.0/icon/align-center
• https://fontawesome.com/v4.7.0/icon/paragraph

Other suggestions:

• https://fontawesome.com/v4.7.0/icon/exchange
• https://fontawesome.com/v4.7.0/icon/hand-peace-o
• https://fontawesome.com/v4.7.0/icon/asterisk
• https://fontawesome.com/v4.7.0/icon/suitcase
• https://fontawesome.com/v4.7.0/icon/leaf
• https://fontawesome.com/v4.7.0/icon/bomb
• https://fontawesome.com/v4.7.0/icon/random
• https://fontawesome.com/v4.7.0/icon/bullhorn

In GitLab by @mejo- on Jul 21, 2020, 18:02

Since 34e6c3b, I'm unable to build the assets with npm run dev:

$ npm run dev

> [email protected] dev /nextcloud/server/apps-extra/wiki
> NODE_ENV=development webpack --progress --config webpack.dev.js

Error: No files matching the pattern "/nextcloud/server/apps-extra/wiki/**/*.s?(c|a)ss" were found.
    at /nextcloud/server/apps-extra/wiki/node_modules/stylelint/lib/standalone.js:207:12
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] dev: `NODE_ENV=development webpack --progress --config webpack.dev.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/vagrant/.npm/_logs/2020-06-05T11_01_09_720Z-debug.log

Only after manually downgrading stylelint to "^8.4.0", the error is gone:

NODE_ENV=development npm install stylelint@^8.4.0

At the moment, Service::PageService is a simple wrapper class around Fs::PageMapper. I'm not sure whether this code structure makes sense or whether it would be better to merge both into one class Fs::PageService.

At least I don't expect us to add other backends (than the file backend), so I don't see why the abstraction should be helpful. The notes app also doesn't have this separation.

After deleting a page we should allow restoring it.

In GitLab by @azul on May 18, 2020, 11:49

We can reuse this to display the markdown of previous versions

In GitLab by @azul on May 28, 2020, 14:44

In GitLab by @azul on Jul 11, 2020, 09:18

We currently do not allow navigating into a subdirectory.
The pages list does not load the files in that directory so the currentPage can not be picked from them.

• Cleanup and squash branch commits
• See whether we can get rid of backend code

In GitLab by @azul on May 18, 2020, 15:59

• find a cleaner solution than importing the CSS from text app with relative links (@import './../../apps/text/css/prosemirror';)
• avoid copying all the css
• allow for defining our own Component that uses EditorWrapper.
• maybe use https://github.com/juliushaertl/nextcloud-text

Missing from !17

In GitLab by @azul on May 28, 2020, 08:39

Similar to #21 but for links instead of image sources.

Not sure if we will use relative links ourselves. But it would be good to support them anyway.

• Create an issue for this proposing basic functionality and additional file-id for later.
• learn how the link rendering in the editor works
• replace the link element for relative links
• optionally add the file-id when editing such links
  for now one will have to link the file again
  But that should be easy to do. So no need for automation
• make use of the file-id to resolve files in other directories when loading via url
• make use of the file-id to resolve files in other directories when loading directly in the viewer

In GitLab by @azul on Jun 11, 2020, 17:51

Centered but only so wide it does not overlap the actions

In GitLab by @azul on May 18, 2020, 15:56

Update the local currentPage state after changes have been commited in edit mode so that preview and edit mode are synchronized. At the moment, opening a page in preview mode after it has been edited results in the old version being loaded.

Missing from !17

A designer just confirmed that the current "edit mode" icon is very confusing. He as well recommended to use a pencil icon instead.

With the current implementation status, EditorWrapper shows some JS errors in the browser debugger. We should look into them and fix em.

In GitLab by @mejo- on Jul 27, 2020, 17:22

In GitLab by @azul on Jul 11, 2020, 10:06

Links in the same folder and subfolders should always be correct (unless the file was moved)
But absolute links on the same domain and relative links that navigate out of the folder
may differ for different users.
In order to prevent these inconsistencies from breaking links all the time
find the file by fileid and open it in the location it has from the perspective of the user browsing.

In GitLab by @azul on Jun 15, 2020, 16:56

We want to display the page title in the HTML <title>.

My impression is that we no longer need the cancelNewPage() logic in App.vue as creating a new page results in really creating the file on the server immediately anyway, right?

In GitLab by @azul on Jun 11, 2020, 17:30

It also breaks some of the title updates

We want to open files in view mode per default and have a toggle to switch to edit mode and back.

• Make version preview a modal to emphasize the fact that it's merely a preview
• Allow to close the modal to get out of the preview
• Add a big "restore to this version" button to this modal

At the moment, our back-end PageController sends full pages with content as response to find and findAll. That's superfluous now that the Text app fetches the page content.

Make the find* functions in PageController send only pageTitle and pageID.

In GitLab by @azul on May 28, 2020, 14:47

Combine various action elemens in one location:

• Edit toggle
• Delete
• Sidebar toggle

In GitLab by @azul on May 28, 2020, 14:46

If a new page is created one still has to click the edit toggle to start editing.
Open in edit mode by default.

In GitLab by @azul on Aug 4, 2020, 10:16

We should update the list of pages with what is happening on the server:

• When creating a new page as user1, user2 should see the new page pop up in the list
• When renaming a page, other users should see the change without a reload
• Editing a page should move it to the top for other users
• it would be nice to see an last edited timestamp next to pages
• it would be nice to see if an page is being edited right now.

In GitLab by @azul on Jul 30, 2020, 16:18

I fixed the this.wikiName issue.

However i am still seeing 500 response codes from the server.

Here's an excerpt from the logs:

proxy_1              | nginx.1    | nextcloud.local 192.168.15.1 - - [30/Jul/2020:14:11:20 +0000] "POST /index.php/apps/wiki/_wikis HTTP/1.1" 500 2
nextcloud_1          | {"reqId":"yYp2hkhou2olwy9LEKzD","level":2,"time":"2020-07-30T14:11:20+00:00","remoteAddr":"192.168.15.6","user":"admin","app":"no app in context","method":"POST","url":"/index.php/apps/wiki/_wikis","message":"Host nextcloud.local was not connected to because it violates local access rules"
nextcloud_1          | {"reqId":"yYp2hkhou2olwy9LEKzD","level":3,"time":"2020-07-30T14:11:20+00:00","remoteAddr":"192.168.15.6","user":"admin","app":"circles","method":"POST","url":"/index.php/apps/wiki/_wikis","message":"fail to initialise circle share to nextcloud.local for circle 6043978b90ec1b - {\"body\":{\"circleId\":\"6043978b90ec1b\",\"frameId\":\"3912d141d736f6967bb7b5a369d88717\"},\"timeout\":3,\"connect_timeout\":3} - Host violates local access rules"
nextcloud_1          | {"reqId":"yYp2hkhou2olwy9LEKzD","level":4,"time":"2020-07-30T14:11:20+00:00","remoteAddr":"192.168.15.6","user":"admin","app":"circles","method":"POST","url":"/index.php/apps/wiki/_wikis","message":"fail to create frame for circle 6043978b90ec1b - Host violates local access rules"

This looks familiar to me from when i first played with sharing via the circles App API. I thought i was doing sth. wrong so i did not report any issue. Funny thing also is... it seems to have worked never the less.

In GitLab by @azul on May 28, 2020, 08:15

• make the server render the wiki page for all subpaths of the wiki app
• add vue router and enable it
• use vue router to display the content of a given page for a matching route
• use vue links in the page list sidebar
• test navigation and history

We want the collective folder + circle to be owned by a vehicle user

In GitLab by @azul on May 18, 2020, 11:50

In GitLab by @azul on Jul 31, 2020, 10:17

I have a folder called Wiki_ in my nextcloud.local instance. We should require a name for new wikis.

We need a handler that deals with filename conflicts when creating/updating pages. The notes app transparantly generates a non-conflicting filename (by sanitizing the file name and optionally adding numbers). We probably should copy this behaviour.

We decided to merge the meaning of page filename and page title.

• Add an edit field for the page title above text editor.
  • Send request to update filename to back-end at or
  • Let back-end handle filename conflicts (already done)
  • Make the back-end replace '/' in title with -

The recommendation of a designer was to seperate the editor formatting toolbar from the content and instead put it into an own header bar along with the edit toggle.

That way, the content (title+page content) would be separated in a fixed area where nothing changes regardless of the view/edit mode.

Probably that's not easy to implement though given that we currently reuse the editor component from Text/Viewer apps.

Now that we have a public Gitlab repo, we should update the corresponding fields in appinfo/info.xml.

We should give the name a more specific name. I'm all for renaming it to Collective<Something>:

• CollectiveWiki
• CollectiveWhiteboard

I'd favour the first, but don't have strong feelings about it. @azul, what's your thoughts on it?

In GitLab by @azul on May 28, 2020, 14:45

Right now, the text editor is completely reloaded when switching between files, which results in bad UX. We probably have to fix this (or add support for a solution) upstream.

In GitLab by @azul on Jul 11, 2020, 09:19

The link renderer currently only checks for ?fileId= in the url.

This is also present for files on another nextcloud instance. Make sure the domain is the same.