Giter Club home page Giter Club logo

Comments (11)

mejo- avatar mejo- commented on June 10, 2024

In GitLab by @azul on Jun 12, 2020, 21:39

This is more complex than it sounds.

First of all... how do we know the page is empty?
Well... we can have the preview load it and then detect it's empty.
Not very fancy but it works.

If the page is empty we switch to edit mode.
This will cause the title to loose focus for new pages.

So we only do this for pages with an existing title that are empty.

Now we are in edit mode. What happens if the user switches to read only mode?
The preview gets loaded again... sees that the page is empty and switches back to edit mode.

So we have two options: Either we disable the read only switch for empty pages. Or we end up with two types of edit mode... the initial one based on the content of the page and the one that was explicitly selected by the user.

I'll think about it some more but i am tempted to not implement this for now.

from collectives.

mejo- avatar mejo- commented on June 10, 2024

In GitLab by @azul on Jun 13, 2020, 20:13

mentioned in commit 79e0bee

from collectives.

mejo- avatar mejo- commented on June 10, 2024

In GitLab by @azul on Jun 13, 2020, 20:15

closed via commit 79e0bee

from collectives.

mejo- avatar mejo- commented on June 10, 2024

In GitLab by @azul on Jun 13, 2020, 20:15

closed via commit 5adb870

from collectives.

mejo- avatar mejo- commented on June 10, 2024

In GitLab by @azul on Jun 13, 2020, 20:15

closed via merge request !31

from collectives.

mejo- avatar mejo- commented on June 10, 2024

In GitLab by @azul on Jun 25, 2020, 11:37

mentioned in commit 5adb870

from collectives.

mejo- avatar mejo- commented on June 10, 2024

mentioned in commit a1355fce47468652576f93197bab4da9ca81336c

from collectives.

mejo- avatar mejo- commented on June 10, 2024

mentioned in commit ab83c5b1f32f5d9fcef3d37065c21be8ab304206

from collectives.

mejo- avatar mejo- commented on June 10, 2024

mentioned in commit ff1bb8bbcb48fa79077eeb0810cb4fdc66a16d87

from collectives.

mejo- avatar mejo- commented on June 10, 2024

mentioned in commit a0841c633afc5051b811c50fc9b53b15fe6adefc

from collectives.

mejo- avatar mejo- commented on June 10, 2024

mentioned in commit 5b036ab6dfd931cf88a04d6a3b0c7d4fba17dac1

from collectives.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.