mazedigital / association_ui_editor Goto Github PK

If the assosiation editor is 'Editor' the editor icon is shown with the css selector:

.field[data-editor='aui-editor'] .item

but the data-editor for Editor (Create new) is aui-editor-new.

If I can make a suggestion, I think a simple 'Edit' text next to 'Remove' would be more clear.

Thanks

Fun one: With focus in any field (i.e. an unrelated one) hitting enter triggers the Create new overlay.

Naturally you need the Editor (Create new) option selected.

Incidentally would this maybe be better suited as link text, rather than a button? As it is it shares perhaps a tad too much prominence with the primary Save Changes/Create Entry CTA.

Dear @hananils/association-ui-funders,

In order to build this editor it would be nice, if you could give us a few insights how you'd like to use inline editing:

• Are you primarily editing existing entries?
• Are you most likely using the editor to create new associations?
• How complex are your associations? Do you rely on nested associations (entries linking to entries that are linking to entries …)?
• Is there anything important we should keep in mind?

Thanks!

If an associative field has sorting enabled, events are conflicting:
The sorting breaks the opening action.

• http://tympanus.net/Development/ItemTransitions/index.html
• http://tympanus.net/Development/ItemTransitions/index2.html
• http://tympanus.net/Development/ArticleIntroEffects/index7.html
• http://tympanus.net/Development/PageTransitions/

Referencing: mazedigital/association_ui_selector#23

When I select the Association Editor: 'Editor: Create New' option, I can only create new Assosciation entries. The icons that allow editing existing entries disappear:

Is there a way to have both editing and creating new entries turned on?

From #2:

Would love if deep-linking/pre-populating was considered. Would it be possible to deep link to a parent entry, but trigger the associations interface to open (and potentially default data?). Not necessarily a requirement, but interesting to know if it'd be possible!

When a selector has an existing value the input is pushed to the right (I assume to simulate the cursor being placed after the value), however this doesn't account for the icon (only visible when the association is saved), and so ends up with unexpected positioning. When the icon isn't there (before you save the entry) it's positioned as expected.

See mazedigital/association_ui_selector#14.

Most likely something that hananils/association_ui_selector has to handle.

See mazedigital/association_ui_selector#21.

Some customers are confused as to what is happening when they submit an entry, especially with a download that might take some time, and there is a period of no feedback.

My suggestion is to replace the the submit button with an animation as soon as it’s clicked. Upon reload it will be replaced with a new one then anyway. This will make it clear there is something happening. Could as well be applied to the whole overlay.

When have an Association field that relates to many sections, the "Create New" button doesn't know how to handle this. Clicking on 'Create New' in this scenario opens the modal with the below error:

Suggestion is that something similar to the With Selected interface could be created, where a select box is added next to the button with the possible section values. Selecting one of these and then Create New would open the modal based off that section.

See mazedigital/association_ui_selector#21.

Not sure if this should be handled by this extension or by hananils/association_ui_selector.

I get the following error when trying to install this extension in an PHP 7.2 environment:

Fatal error: Access level to extension_association_ui_selector::$provides must be protected (as in class Extension) or weaker in /is/htdocs/wp11073211_5RUB980JDE/www/symphony-php-72/extensions/association_ui_selector/extension.driver.php on line 0

The Remove action is currently overlapping the item content, see #9.

/cc @johannahoerrmann

Again, I hope this is in the right place!

Let's see if I can remember my exact workflow:

I had an association field set up to a section, and an entry already saved. I edited the section to change the association to a different section. When editing the existing entry the association now reads 1, I removed it, created a new entry using the 'Create new' button (using the Editor (Create new) option), successfully create the entry (I get a success message within the overlay), however I get an error in the main header:

Some errors were encountered while attempting to save.

And the association isn't created. I was able to then search and select the new entry and successfully save the entry.

So it all worked out in the end, but had a couple of bumps along the way. The error in the Symphony logs is:

01/08/2014 21:48 > Fatal Error: Javascript - Uncaught TypeError: undefined is not a function in file http://localhost:8888/stubbington_ark/extensions/association_ui_editor/assets/aui.editor.publish.js on line 177

I don't see the icon in Chrome: Version 36.0.1985.125 on OSX Mavericks
I see the icon in: Firefox v30
I don't see the icon in: Safari 7.0.5 (9537.77.4)

See #16.

Reference how it should look like:

(I get a bit confused about which extension does what, apologies if this is in the wrong place)

I've only just updated everything to the latest versions, and I may be alone, but I literally only just found out by accident that the document icon is for editing the associated entry - purely by accident. If anything I'd expect it to be the 'new entry' button… however I didn't realise it was a button at all… Perhaps because it's greyed out slightly I assumed it was just a decoration icon. It doesn't say 'click me to edit this entry' to me. What do others think, just me?

Would something with a pencil not be a little clearer? I'm guessing you're going for a slightly different metaphor than 'edit', more like 'view this entry'? At the moment it's the kind of thing I feel I'd have to explain to a client, not that it would take much explaining :)

Overall it's working great by the way Nils - you guys have done a fantastic job! It really does revolutionise the backend.

So I was playing around with an Association field and noticed that if I have just selected an item from the Selectize box the edit icon appears but I can't actually click it to edit the entry until I have saved the parent Section entry. Is this standard behaviour or should it edit in realtime upon selection?

I accidentally clicked an area outside of the association select UI and it opened a page on top as if creating an new association.

Should we isolate the Create New to just the button area and not the whole row? So that it's inline with other button actions in the backend.

In Chrome on Mac the bottom border of aui-editor-page is not visible because of the max-height and overflow:hidden of the #contents div.
The above are inline styles which are being applied when I click 'Create New' association.

aui-editor has padding: 1rem 0 0 1.8rem; but I think it shoud be padding: 1rem 1.8rem 0 1.8rem; for the editor to have the same spacing on the right side of the page as on the left.

After saving an associated entry edited in Editor in an entry with shown drawer, the associated entry in Editor also displays its drawer. While this is probably aligned with the default publish features, it is visually confusing.

Maybe the drawer should be omitted for the Editor.

Hi Nils,

Looking at the UI as it stands, I think it's looking and feeling great. I still think that an icon/more visual prompt to edit should be considered. Will get me thinking cap on to suggest one or two things here.. I know Icons aren't really the Symphony way so it needs to fit into the current scheme of UI presentation.

The other thing that has cropped up for me is the depth issue when you have a child association which in turn has it's very own association:

We really do lose quite a bit of screen real estate when it goes deeper. What if we collapsed the UI down to a minimum for nested associations and used something similar to the below to navigate back up the tree?

Just a thought really.