Editor icon not visible on Editor (Create new) about association_ui_editor HOT 6 CLOSED

If I can make a suggestion, I think a simple 'Edit' text next to 'Remove' would be more clear.

There is one big problem: how do you handle multiple buttons (e. g. edit + remove) in localised contexts with longer words (e. g. bearbeiten + löschen)?

from association_ui_editor.

Hi Nils,
I got the same issue => Editor icon not visible on Editor (Create new), and I still can click the editor on the left of item, But when i reorder the items then the editor link disappear.

from association_ui_editor.

That seems to be a CSS issue: the icon is a background image.
I'll check that. Thanks!

from association_ui_editor.

There is one big problem: how do you handle multiple buttons (e. g. edit + remove) in localised contexts with longer words (e. g. bearbeiten + löschen)?

Then maybe an 'x' icon for remove and a 'pen' icon for edit but both in the same place (on the right).
That way you can put padding-right on the value span so that the absolute positioned icons don't float above the text value (another issue - right now if the value is long 'Remove' floats above it).

from association_ui_editor.

.field[data-editor='aui-editor'] .multi .item,
.field[data-editor='aui-editor-new'] .multi .item {
    padding-left: 1.3rem;
    background-position: 1rem center;
}

.aui-editor-trigger {
    position: absolute;
    top: 0.5rem;
    left: -0.5rem;
    overflow: hidden;
    width: 2.8rem;
    height: 2rem;
    text-indent: -1000em;
    border: none;
    background-image: url(editor.svg);
    background-repeat: no-repeat;
    background-position: 80% center;
    background-size: 0.8rem 10rem;
    cursor: pointer;
}

CSS isusse solved.

But when reorder items the editor link disappear i'm sure that's javascript issus.

from association_ui_editor.

If the assosiation editor is 'Editor' the editor icon is shown with the css selector

The CSS issue should be solved here: 95b9da7

Then maybe an 'x' icon for remove and a 'pen' icon for edit but both in the same place (on the right).

I'd like to keep the interface consistent with the core, so I'm not fond of replacing the the remove link with an icon. See #7.

Still, using an icon to open a secondary layer is fine in my eyes because it's a different kind of action. This action is about opening a associated page on top of the current one and although you can edit data on that page, I think an icon referencing that page fits best here. So I'd like to stick with it instead of a pen (I know a pen is often used for editing, but it doesn't make sense at all: we don't use pens, we type).

(another issue - right now if the value is long 'Remove' floats above it)

Good catch. Will add a separate issue for that.

from association_ui_editor.