makeup-js / makeup-expander Goto Github PK

Both hostContainerClass and simulateSpacebarClick can be used as options properties, but not documented yet.

When an app uses lasso-babel-transform, it will attempt to transform any node_modules/ packages that has a .babelrc file. In this case, it sees the .babelrc in makeup-expander/ and attempts to compile it, then runs into an error requiring babel-plugin-transform-object-assign because that is currently a devDependency rather than a dependency. Since the code here is already compiled, we wouldn't want it to get transformed anyway, so the simple fix is to exclude .babelrc via .npmignore blacklist or files: [] whitelist.

I did not make a PR, because I imagine this affects many/all of the makeup repos.

We may also want to consider changing this behavior in https://github.com/lasso-js/lasso-babel-transform

cc @mlrawlings

Version used: 0.0.3
I can't able to see the add function in makeup-exit-emitter.

I want to update the code to use a getter/setter API (i.e. instance.expanded = true) rather than expand(), collapse() and isExpanded methods.

Currently it looks like expander assumes that the content is closed by default, but shouldn't it first use the existing aria-expanded value if it exists?

I'm currently using this as new Expander(this.el, {click: true});, so only passing in click config. From the current defaults, I also pick up autoCollapse: true. It seems that these may conflict. Here are the repro steps:

1. Click menu trigger (expands content)
2. Click a menu item (item takes focus)
3. Click menu trigger

I would expect step 3 to collapse the menu. When the focus leaves the item, it initially triggers a collapse per

When this utility has created event listeners for things like document touch events, or focus events, they may not get removed when the component has been destroyed (say, by Marko). This causes issues when they are still attached to components but the makeup utility that created them no longer exists.

As a reference, @DylanPiercey created a utility to help manage listeners, and easily cancel all of them in one fell swoop: https://github.com/marko-js/utils/blob/master/packages/abort-group/README.md