autoCollapse conflicts with click behavior about makeup-expander HOT 7 CLOSED

Thanks @yomed. Will take a look.

from makeup-expander.

The bug lies in the makeup-exit-emitter dependency. Clicking menu trigger in step 3 should not emit a focusExit event like it currently does, which in turn causes expander to collapse. Will fix.

from makeup-expander.

@yomed, can you try upgrading to v0.1.0? Note that autoCollapse has now been set to false by default, and that events were renamed to expanderExpand and expanderCollapse (we will rename these again, when we get consensus).

from makeup-expander.

Thanks @ianmcburnie, that fixed the main issue. Changing the event names actually caused another issue (that's somewhat related).

I'm using the events like this, in order to easily catch them with Marko:

<span w-bind w-on-expanderExpand="handleExpand" w-on-expanderCollapse="handleCollapse">

The camelCase custom events should work fine, per marko-js-archive/marko-widgets#19

I believe there is a bug in marko-widgets, because it is incorrectly transforming the events to expanderexpand and expandercollapse. I would open an issue there... but marko-widgets doesn't really have active development anymore. We might want to consider this issue when deciding the final names.

from makeup-expander.

@ianmcburnie Should the new event names be expander-expand and expander-collapse?

from makeup-expander.

Yep. I was holding back on renaming all the makeup events, because well... it's a bit of a manual chore, but if the camel case is causing an actual issue with Marko I guess I should stop being lazy and rename them... starting with this one :-)

from makeup-expander.

v0.2.0 published with new event names.

from makeup-expander.